fixed production runtime crashes

Author: ascandone

analysis/hover.go

@@ -113,6 +113,10 @@ func hoverOnSendStatement(sendStatement parser.SendStatement, position parser.Po
 }
 
 func hoverOnLiteral(lit parser.Literal, position parser.Position) Hover {
+	if lit == nil {
+		return nil
+	}
+
 	if !lit.GetRange().Contains(position) {
 		return nil
 	}
@@ -140,6 +144,10 @@ func hoverOnLiteral(lit parser.Literal, position parser.Position) Hover {
 }
 
 func hoverOnSource(source parser.Source, position parser.Position) Hover {
+	if source == nil {
+		return nil
+	}
+
 	if !source.GetRange().Contains(position) {
 		return nil
 	}
@@ -174,7 +182,7 @@ func hoverOnSource(source parser.Source, position parser.Position) Hover {
 	case *parser.SourceInorder:
 		for _, source := range source.Sources {
 			// TODO binary search
-			if !source.GetRange().Contains(position) {
+			if source == nil || !source.GetRange().Contains(position) {
 				continue
 			}
 

analysis/hover_test.go

@@ -314,3 +314,50 @@ func TestHoverOnFnOriginDocs(t *testing.T) {
 	}
 
 }
+
+func TestHoverFaultTolerance(t *testing.T) {
+	t.Run("missing lit", func(t *testing.T) {
+		input := `
+			send [COIN 10] (
+				source = max <invalidtk> from @a
+				destination = @a
+			)
+		`
+
+		rng := RangeOfIndexed(input, "<invalidtk>", 0)
+		program := parser.Parse(input).Value
+		hover := analysis.HoverOn(program, rng.Start)
+		assert.Nil(t, hover)
+	})
+
+	t.Run("missing source", func(t *testing.T) {
+		input := `
+			send [COIN 10] (
+				source = <invalidtk>
+				destination = @a
+			)
+		`
+
+		rng := RangeOfIndexed(input, "<invalidtk>", 0)
+		program := parser.Parse(input).Value
+		hover := analysis.HoverOn(program, rng.Start)
+		assert.Nil(t, hover)
+	})
+
+	t.Run("missing source in inorder", func(t *testing.T) {
+		input := `
+			send [COIN 10] (
+				source = {
+				 	@a
+					<invalidtk>
+				}
+				destination = @a
+			)
+		`
+
+		rng := RangeOfIndexed(input, "<invalidtk>", 0)
+		program := parser.Parse(input).Value
+		hover := analysis.HoverOn(program, rng.Start)
+		assert.Nil(t, hover)
+	})
+}