feat(badge): defined the semantic-release badge in the lift results rather than scaffold results

Author: travi

src/semantic-release/lifter-test.js

@@ -25,7 +25,20 @@ suite('semantic-release lifter', () => {
   test('that results are returned', async () => {
     githubWorkflowsTester.default.resolves(false);
 
-    assert.deepEqual(await lift({projectRoot}), {});
+    assert.deepEqual(
+      await lift({projectRoot}),
+      {
+        badges: {
+          contribution: {
+            'semantic-release': {
+              img: 'https://img.shields.io/badge/semantic--release-angular-e10079?logo=semantic-release',
+              text: 'semantic-release: angular',
+              link: 'https://github.com/semantic-release/semantic-release'
+            }
+          }
+        }
+      }
+    );
     assert.notCalled(githubWorkflowsLifter.default);
   });
 
@@ -34,7 +47,20 @@ suite('semantic-release lifter', () => {
     fs.readFile.withArgs(`${projectRoot}/.nvmrc`, 'utf-8').resolves(nodeVersion);
     githubWorkflowsTester.default.withArgs({projectRoot}).resolves(true);
 
-    assert.deepEqual(await lift({projectRoot}), {});
+    assert.deepEqual(
+      await lift({projectRoot}),
+      {
+        badges: {
+          contribution: {
+            'semantic-release': {
+              img: 'https://img.shields.io/badge/semantic--release-angular-e10079?logo=semantic-release',
+              text: 'semantic-release: angular',
+              link: 'https://github.com/semantic-release/semantic-release'
+            }
+          }
+        }
+      }
+    );
     assert.calledWith(githubWorkflowsLifter.default, {projectRoot, nodeVersion});
   });
 });

src/semantic-release/lifter.js

@@ -9,5 +9,15 @@ export default async function ({projectRoot}) {
     await liftCiProvider({projectRoot, nodeVersion});
   }
 
-  return {};
+  return {
+    badges: {
+      contribution: {
+        'semantic-release': {
+          img: 'https://img.shields.io/badge/semantic--release-angular-e10079?logo=semantic-release',
+          text: 'semantic-release: angular',
+          link: 'https://github.com/semantic-release/semantic-release'
+        }
+      }
+    }
+  };
 }

src/semantic-release/scaffolder-test.js

@@ -19,20 +19,7 @@ suite('semantic-release scaffolder', () => {
   teardown(() => sandbox.restore());
 
   test('that that the badge and version string are generated', async () => {
-    assert.deepEqual(
-      await scaffoldSemanticRelease({projectRoot}),
-      {
-        badges: {
-          contribution: {
-            'semantic-release': {
-              img: 'https://img.shields.io/badge/semantic--release-angular-e10079?logo=semantic-release',
-              text: 'semantic-release: angular',
-              link: 'https://github.com/semantic-release/semantic-release'
-            }
-          }
-        }
-      }
-    );
+    assert.deepEqual(await scaffoldSemanticRelease({projectRoot}), {});
 
     assert.calledWith(
       jsCore.mergeIntoExistingPackageJson,

src/semantic-release/scaffolder.js

@@ -3,15 +3,5 @@ import {mergeIntoExistingPackageJson} from '@form8ion/javascript-core';
 export default async function ({projectRoot}) {
   await mergeIntoExistingPackageJson({projectRoot, config: {version: '0.0.0-semantically-released'}});
 
-  return {
-    badges: {
-      contribution: {
-        'semantic-release': {
-          img: 'https://img.shields.io/badge/semantic--release-angular-e10079?logo=semantic-release',
-          text: 'semantic-release: angular',
-          link: 'https://github.com/semantic-release/semantic-release'
-        }
-      }
-    }
-  };
+  return {};
 }