Refactor formatter logic #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced Prettier and Biome api calls with `tinyexec` for formatting and streamlined formatter execution. Deprecate `pathToFormatterConfig` option.
AlemTuzlak
reviewed
Feb 4, 2025
| stdinStream.push(fileContent); | ||
| stdinStream.push(null); | ||
|
|
||
| const { process } = exec(formatter, options, {}); |
There was a problem hiding this comment.
finally got the time to go through this, this all looks good but I have a question about this specific bit here, does this require you to have the formatter globally installed? or can it execute biome/prettier from the node_modules, eg I have a project using biome, I don't have to do npm i -g biome for this to work?
There was a problem hiding this comment.
Correct, it runs the formatter from node_modules, no need for global install, and I doubt that global formatter will work here.
There was a problem hiding this comment.
awesome, that's what I wanted to hear
AlemTuzlak
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19, #26
Description
Replaced Prettier and Biome API calls with
tinyexecprocess execution.Type of change
Please mark relevant options with an
xin the brackets.This might be a breaking change. SVG will no longer be formatted if Biome is set as a formatter.
I found and fixed some bugs while working on the PR. Here's what I did:
test-apps/remix-vite/public/icons/types.tsfile.How Has This Been Tested?
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
Screenshots (if appropriate):
Questions (if appropriate):