Skip to content

Commit f000435

Browse files
WillieRuemmeleWillieRuemmele
authored
Wr/decompose ps2 custom perm (#1483)
* test: add snapshot test, passing now, should fail * fix: fixed customPermission child xml tag
1 parent 6639250 commit f000435

File tree

17 files changed

+193
-6
lines changed

17 files changed

+193
-6
lines changed

‎src/convert/transformers/decomposedPermissionSetTransformer.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ export class DecomposedPermissionSetTransformer extends BaseMetadataTransformer
123123
return [...writeInfosForChildren, ...writeInfoForParent];
124124
}
125125
}
126-
/** for a component, parse the xml and create an json object with contents, child typeId, etc */
126+
/** for a component, parse the xml and create a json object with contents, child typeId, etc */
127127
const getComposedMetadataEntries = async (component: SourceComponent): Promise<ComposedMetadata[]> =>
128128
// composedMetadata might be undefined if you call toSourceFormat() from a non-source-backed Component
129129
Object.entries((await component.parseXml())[component.type.name] ?? {}).map(

‎src/registry/presets/decomposePermissionSetBeta2.json‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"applicationvisibility": "permissionset",
44
"classaccess": "permissionset",
55
"custommetadatatypeaccess": "permissionset",
6-
"custompermissions": "permissionset",
6+
"custompermission": "permissionset",
77
"customsettingaccess": "permissionset",
88
"externalcredentialprincipalaccess": "permissionset",
99
"externaldatasourceaccess": "permissionset",
@@ -28,7 +28,7 @@
2828
"applicationVisibilities": "applicationvisibility",
2929
"classAccesses": "classaccess",
3030
"customMetadataTypeAccesses": "custommetadatatypeaccess",
31-
"customPermissions": "custompermissions",
31+
"customPermissions": "custompermission",
3232
"customSettingAccesses": "customsettingaccess",
3333
"externalCredentialPrincipalAccesses": "externalcredentialprincipalaccess",
3434
"externalDataSourceAccesses": "externaldatasourceaccess",
@@ -44,7 +44,7 @@
4444
"applicationVisibility": "applicationvisibility",
4545
"classAccess": "classaccess",
4646
"customMetadataTypeAccess": "custommetadatatypeaccess",
47-
"customPermission": "custompermissions",
47+
"customPermission": "custompermission",
4848
"customSettingAccess": "customsettingaccess",
4949
"externalCredentialPrincipalAccess": "externalcredentialprincipalaccess",
5050
"externalDataSourceAccess": "externaldatasourceaccess",
@@ -82,9 +82,9 @@
8282
"suffix": "customMetadataTypeAccess",
8383
"uniqueIdElement": "name"
8484
},
85-
"custompermissions": {
85+
"custompermission": {
8686
"directoryName": "",
87-
"id": "custompermissions",
87+
"id": "custompermission",
8888
"isAddressable": false,
8989
"name": "CustomPermission",
9090
"suffix": "customPermission",

‎test/snapshot/sampleProjects/preset-decomposedPS2/__snapshots__/verify-md-files.expected/package.xml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<members>dreamhouse</members>
55
<members>ebikes</members>
66
<members>noObjectSettings</members>
7+
<members>withCustomPermission</members>
78
<name>PermissionSet</name>
89
</types>
910
<version>60.0</version>

‎test/snapshot/sampleProjects/preset-decomposedPS2/__snapshots__/verify-md-files.expected/permissionsets/withCustomPermission.permissionset‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<PermissionSet xmlns="http://soap.sforce.com/2006/04/metadata">
3+
<applicationVisibilities>
4+
<application>withCustomPermission</application>
5+
<visible>true</visible>
6+
</applicationVisibilities>
7+
<classAccesses>
8+
<apexClass>PagedResult</apexClass>
9+
<enabled>true</enabled>
10+
</classAccesses>
11+
<classAccesses>
12+
<apexClass>PropertyController</apexClass>
13+
<enabled>true</enabled>
14+
</classAccesses>
15+
<classAccesses>
16+
<apexClass>SampleDataController</apexClass>
17+
<enabled>true</enabled>
18+
</classAccesses>
19+
<customPermissions>
20+
<enabled>true</enabled>
21+
<name>myCustomPerm</name>
22+
</customPermissions>
23+
<customPermissions>
24+
<enabled>true</enabled>
25+
<name>myCustomPerm1</name>
26+
</customPermissions>
27+
<hasActivationRequired>false</hasActivationRequired>
28+
<label>withCustomPermission</label>
29+
</PermissionSet>

‎test/snapshot/sampleProjects/preset-decomposedPS2/__snapshots__/verify-source-files.expected/force-app/main/default/permissionsets/withCustomPermission/withCustomPermission.applicationVisibility-meta.xml‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<PermissionSet>
3+
<applicationVisibilities>
4+
<application>withCustomPermission</application>
5+
<visible>true</visible>
6+
</applicationVisibilities>
7+
</PermissionSet>

‎test/snapshot/sampleProjects/preset-decomposedPS2/__snapshots__/verify-source-files.expected/force-app/main/default/permissionsets/withCustomPermission/withCustomPermission.classAccess-meta.xml‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<PermissionSet>
3+
<classAccesses>
4+
<apexClass>PagedResult</apexClass>
5+
<enabled>true</enabled>
6+
</classAccesses>
7+
<classAccesses>
8+
<apexClass>PropertyController</apexClass>
9+
<enabled>true</enabled>
10+
</classAccesses>
11+
<classAccesses>
12+
<apexClass>SampleDataController</apexClass>
13+
<enabled>true</enabled>
14+
</classAccesses>
15+
</PermissionSet>

‎test/snapshot/sampleProjects/preset-decomposedPS2/__snapshots__/verify-source-files.expected/force-app/main/default/permissionsets/withCustomPermission/withCustomPermission.customPermission-meta.xml‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<PermissionSet>
3+
<customPermissions>
4+
<enabled>true</enabled>
5+
<name>myCustomPerm</name>
6+
</customPermissions>
7+
<customPermissions>
8+
<enabled>true</enabled>
9+
<name>myCustomPerm1</name>
10+
</customPermissions>
11+
</PermissionSet>

‎test/snapshot/sampleProjects/preset-decomposedPS2/__snapshots__/verify-source-files.expected/force-app/main/default/permissionsets/withCustomPermission/withCustomPermission.permissionset-meta.xml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<PermissionSet xmlns="http://soap.sforce.com/2006/04/metadata">
3+
<hasActivationRequired>false</hasActivationRequired>
4+
<label>withCustomPermission</label>
5+
</PermissionSet>

‎test/snapshot/sampleProjects/preset-decomposedPS2/force-app/main/default/permissionsets/withCustomPermission/withCustomPermission.applicationVisibility-meta.xml‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<PermissionSet>
3+
<applicationVisibilities>
4+
<application>withCustomPermission</application>
5+
<visible>true</visible>
6+
</applicationVisibilities>
7+
</PermissionSet>

‎test/snapshot/sampleProjects/preset-decomposedPS2/force-app/main/default/permissionsets/withCustomPermission/withCustomPermission.classAccess-meta.xml‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<PermissionSet>
3+
<classAccesses>
4+
<apexClass>PagedResult</apexClass>
5+
<enabled>true</enabled>
6+
</classAccesses>
7+
<classAccesses>
8+
<apexClass>PropertyController</apexClass>
9+
<enabled>true</enabled>
10+
</classAccesses>
11+
<classAccesses>
12+
<apexClass>SampleDataController</apexClass>
13+
<enabled>true</enabled>
14+
</classAccesses>
15+
</PermissionSet>

0 commit comments

Comments
 (0)