Merge main into v3 (#504)

* fix: works with TS4+ and jsforce types (#413)

* fix: works with TS4+ and jsforce types

* style: remove no-longer-applicable comment

* fix: latest dev-packages for sinon/types

* chore(release): 2.23.4 [ci skip]

* fix: w-9299422 (login url from config) and fs-parallelization

* style: use the enum for prod url

* test: some UT for config resolution

* chore(release): 2.23.5 [ci skip]

* feat: exported function checkLightningDomain() (#415)

* feat: exported function checkLightningDomain()

* chore: clean stubs

Co-authored-by: Shane McLaughlin <[email protected]>

* chore(release): 2.24.0 [ci skip]

* style: attempt as a copy/paste

* chore: better library

* fix: rewrite polling client

* test: it really waits on requests to complete before making the next

* fix: puts some types back in dependencies

* chore: fix link to logger docs

* chore(release): 2.24.1 [ci skip]

* chore(release): 2.24.2 [ci skip]

* chore: sync git2gus.json (#428) [skip ci]

* feat: @W-9517449@ Allow signupTargetLoginUrl to be overridden via env var (#429)

Fixes #427

* chore(release): 2.25.0 [ci skip]

* fix: set retries to INFINITELY for polling client

* chore(release): 2.25.1 [ci skip]

* feat: update generate password functionality (#432)

* feat: update generate password functionality

@W-5829533@

* chore: refactoring the code

@W-5829533@

* chore: updating test case

* chore: code refactoring and error handling

* chore: refactoring the code based on the comments

* chore: test case changes

* chore: updating test case

* chore: adding test case for length

* chore: updated test cases

* chore: code refactoring

Co-authored-by: Shane McLaughlin <[email protected]>

* chore(release): 2.26.0 [ci skip]

* fix: force:org:open force:org:open --urlonly display bug (#439)

* fix: modified regex used for finding access tokens

@W-6336711@

* chore: test case changes

* chore(release): 2.26.1 [ci skip]

* feat: Core URL class SfdcUrl (#420)

* feat: new class SfdcUrl (skeleton)

* chore: test emitWarning on insecure url

* chore: add lookup optionally createdOrgInstance and more tests

* chore: allow URL input in constructor

* chore: add domain cache to warnings

* chore: cache as a module

* chore: add method description

* chore: refactor with SfdcUrl class

* chore: add test for warning signal cache

* chore: remove unused from sfdc

* chore: defaults to Prod + use Env from kit in tests

* chore: test cleanup + better comments + typos

* chore: fix comment

* chore: use type safe functions + add tests for lookup error

* chore: better document methods

* chore: remove unused stub

* chore: simplify stub with a throw

* chore: use process.emitWarning

* chore: remove unused + make cache private

* chore: cnames don't have protocol add one for a proper url

* fix: keep backward compatibility for getJwtAudienceUrl exported fx

* chore: unset env var afterEach

* chore: add isInternalUrl to sfdc

* test: nuts for core

* test: run nuts

* test: add nuts

* test: rename required nut

* test: don't require nuts yet

* test: skip config (known messages issue)

* test: auth env checks

* test: nuts will be on their own branch

* test: no nuts

Co-authored-by: Shane McLaughlin <[email protected]>

* chore(release): 2.27.0 [ci skip]

* fix: improve error message when providing an invalid username

* fix: dont fail when trying to unset sf config keys (#456)

* chore(release): 2.27.1 [ci skip]

* fix: improve error handling while removing config props

* chore(release): 2.27.2 [ci skip]

* test: sm/external-nuts-from-orb (#460)

* chore: improve error msg

* feat: add custom templates config

* feat: add validator for custom templates config

* chore: add deprecations (#470)

* chore: add deprecations

* chore: deprecate fs

* feat: update config name

* docs: doc feedback

* chore(release): 2.28.0 [ci skip]

* fix: crmforce.mil

* chore(release): 2.28.1 [ci skip]

* fix: support for .mil sandboxes

* test: confirm trailing slash behavior

* Updated/Added CODEOWNERS with ECCN

* chore(release): 2.28.2 [ci skip]

* Update messages/core.json

Co-authored-by: Juliet Shackell <[email protected]>

* Update messages/core.json

Co-authored-by: Juliet Shackell <[email protected]>

* Update messages/core.json

Co-authored-by: Juliet Shackell <[email protected]>

* fix: fix unit test

* fix: force new release

* chore(release): 2.28.3 [ci skip]

* feat: warning and telemetry events

* feat: warning and telemetry events

* test: warning and telemetry events, support for --watch

* feat: use warnings instead of process in sfdx-core

* chore: also allow json import for docs

* fix: transfer listeners when upgrading the global instance to newer version

* feat: cleans up old listeners from upgraded instance

* test: no only UT

* chore: bump dev-scripts

* chore: don't export lib/src

* chore: a few return types

* chore: ts record type instead of anyjson for objects

* chore: re-enable plugin-config NUTs (#494)

* fix: bump jsforce types and run unit tests on Windows (#485)

* chore: run unit tests on Windows

* chore: fix scripts

* chore: bump @salesforce/prettier-config

* chore: bump @salesforce/dev-scripts

* chore: skip keychain UT on windows

* chore: fix fs UTs on windows

* chore: use os.EOL instead of hardcoded newline char

* chore: fix UT that was causing a mem leak on windows

* chore: fix project UTs on windows

* chore: add plugin-data to external-nut job

* chore: bump @types/jsforce

Co-authored-by: Shane McLaughlin <[email protected]>

* chore(release): 2.28.4 [ci skip]

* chore: jsdoc public method

* docs: jsdoc for public method

* chore: linter (return types)

* chore: remove Bunyan return type from method in attempt to fix NUTs

* chore(release): 2.29.0 [ci skip]

* feat: delete scratch orgs and sandboxes (#491)

* fix: scratch org delete logic & tests

* chore: add comments, jsdoc

* chore: add error if no devhub found

* chore: delete sandboxes

* chore: small cleanup

* chore: add sandboxProcessNotFoundByOrgId error

* feat: new guards for props on messages (type: unknown)

* refactor: error guards and fewer conditionals

* refactor: reduce var scoping

* feat: isSandbox and no guards

* test: dry createOrg method

* refactor: improvements from review

* fix: message renaming

* chore: bump sinon/types

Co-authored-by: mshanemc <[email protected]>
Co-authored-by: Cristian Dominguez <[email protected]>

* chore(release): 2.30.0 [ci skip]

* chore(deps): bump path-parse from 1.0.6 to 1.0.7 in /examples (#463)

Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump semver-regex from 3.1.2 to 3.1.3 (#481)

Bumps [semver-regex](https://github.com/sindresorhus/semver-regex) from 3.1.2 to 3.1.3.
- [Release notes](https://github.com/sindresorhus/semver-regex/releases)
- [Commits](https://github.com/sindresorhus/semver-regex/commits)

---
updated-dependencies:
- dependency-name: semver-regex
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shane McLaughlin <[email protected]>

* fix: better output for authUrl errors

* chore(release): 2.30.1 [ci skip]

* feat: bump version of jsforce

* chore(release): 2.31.0 [ci skip]

* chore: bump dev-scripts to v1 (#496)

* chore: bump dev-scripts to v1

* chore: bump dev-scripts

Co-authored-by: mshanemc <[email protected]>

* Update config.json

* chore(release): 2.31.1 [ci skip]

* fix: no maxquery warning when records.length is 0

* test: ut for warnings

* feat: switch sfdx-faye with faye

* test: resovles instead of return a promise function

* Update package.json

Bumping version for release.  @W-0@

* chore(release): 2.32.0 [ci skip]

* feat: sandbox creation

* fix: sandbox create, UT, auth failing

* chore: minor refactor for lifecycle

* chore: clean up UTs

* chore: code review I

* chore: create and export listener types

* chore: hook emitting sandbox auth info

* chore(release): 2.33.0 [ci skip]

* chore: finish merge

* chore: linting

* chore: fix windows tests

* fix: faye doesn't use custom stuff passed it

* chore: code review

* chore(release): 2.33.1 [ci skip]

* chore: remove sfdx-faye

Co-authored-by: peternhale <[email protected]>
Co-authored-by: Shane McLaughlin <[email protected]>
Co-authored-by: SF-CLI-BOT <[email protected]>
Co-authored-by: Steve Hetzel <[email protected]>
Co-authored-by: Benjamin <[email protected]>
Co-authored-by: Willie Ruemmele <[email protected]>
Co-authored-by: Vamsi-Mundra-Salesforce <[email protected]>
Co-authored-by: jfeng-salesforce <[email protected]>
Co-authored-by: jayree <[email protected]>
Co-authored-by: vamsimundra <[email protected]>
Co-authored-by: Cristian Dominguez <[email protected]>
Co-authored-by: Cristian Dominguez <[email protected]>
Co-authored-by: Xiaoyi Chen <[email protected]>
Co-authored-by: svc-scm <[email protected]>
Co-authored-by: Juliet Shackell <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Willie Ruemmele <[email protected]>

.circleci/config.yml

@@ -118,6 +118,7 @@ workflows:
             parameters:
               os:
                 - linux
+                - windows
               node_version:
                 - latest
                 - lts

.git2gus/config.json

@@ -1,4 +1,5 @@
 {
   "productTag": "a1aB00000004Bx8IAE",
-  "defaultBuild": "offcore.tooling.52"
+  "defaultBuild": "offcore.tooling.53",
+  "issueTypeLabels": { "feature": "USER STORY", "bug": "BUG P3" }
 }

.gitignore

@@ -36,3 +36,5 @@ node_modules
 .DS_Store
 .idea
 /Library
+
+.vscode/settings.json

.husky/commit-msg

@@ -0,0 +1,4 @@
+#!/bin/sh
+. "$(dirname "$0")/_/husky.sh"
+
+yarn commitlint --edit

.husky/pre-commit

@@ -0,0 +1,4 @@
+#!/bin/sh
+. "$(dirname "$0")/_/husky.sh"
+
+yarn lint && yarn pretty-quick --staged

.husky/pre-push

@@ -0,0 +1,4 @@
+#!/bin/sh
+. "$(dirname "$0")/_/husky.sh"
+
+yarn build && yarn test

.mocharc.json

@@ -1,6 +1,8 @@
 {
   "require": "test/init.js, ts-node/register, source-map-support/register",
   "watch-extensions": "ts",
+  "watch-files": ["src", "test"],
+  "spec": ["./test/**/*.ts"],
   "recursive": true,
   "reporter": "spec",
   "timeout": 5000

CHANGELOG.md

@@ -4,19 +4,17 @@ All notable changes to this project will be documented in this file. See [standa
 
 ### [3.7.2](https://github.com/forcedotcom/sfdx-core/compare/v3.7.1...v3.7.2) (2021-10-28)
 
-
 ### Bug Fixes
 
-* make @types/sfdx-faye a dependendcy ([683680b](https://github.com/forcedotcom/sfdx-core/commit/683680b8133048f71d25ef4df7aa24d9700dc5e8))
+- make @types/sfdx-faye a dependendcy ([683680b](https://github.com/forcedotcom/sfdx-core/commit/683680b8133048f71d25ef4df7aa24d9700dc5e8))
 
 ### [3.7.1](https://github.com/forcedotcom/sfdx-core/compare/v3.7.0...v3.7.1) (2021-10-28)
 
 ## [3.7.0](https://github.com/forcedotcom/sfdx-core/compare/v3.6.6...v3.7.0) (2021-10-12)
 
-
 ### Features
 
-* use jsforce v2 ([#457](https://github.com/forcedotcom/sfdx-core/issues/457)) ([4a9094e](https://github.com/forcedotcom/sfdx-core/commit/4a9094e958288cdcc6c69f5d87b10a70a437d8e9))
+- use jsforce v2 ([#457](https://github.com/forcedotcom/sfdx-core/issues/457)) ([4a9094e](https://github.com/forcedotcom/sfdx-core/commit/4a9094e958288cdcc6c69f5d87b10a70a437d8e9))
 
 ### [3.6.6](https://github.com/forcedotcom/sfdx-core/compare/v3.6.5...v3.6.6) (2021-10-08)
 
@@ -222,6 +220,81 @@ All notable changes to this project will be documented in this file. See [standa
 - add GlobalInfo config file ([#397](https://github.com/forcedotcom/sfdx-core/issues/397)) ([579998b](https://github.com/forcedotcom/sfdx-core/commit/579998b6ee70dbb9772e65896bbabf6d812aae23))
 - default to reading files from cache ([12b5930](https://github.com/forcedotcom/sfdx-core/commit/12b59301df96395c4edcbfb0816dbddd45af95db))
 
+### [2.33.1](https://github.com/forcedotcom/sfdx-core/compare/v2.33.0...v2.33.1) (2021-12-15)
+
+### Bug Fixes
+
+- faye doesn't use custom stuff passed it ([b1cefc7](https://github.com/forcedotcom/sfdx-core/commit/b1cefc76afde7f0dd56ed72b5539a47c118eef63))
+
+## [2.33.0](https://github.com/forcedotcom/sfdx-core/compare/v2.32.0...v2.33.0) (2021-12-14)
+
+### Features
+
+- sandbox creation ([314dcf1](https://github.com/forcedotcom/sfdx-core/commit/314dcf164d93bd0e3a5f4763a4dfcdde7d0cb14a))
+
+## [2.32.0](https://github.com/forcedotcom/sfdx-core/compare/v2.31.1...v2.32.0) (2021-12-14)
+
+### Features
+
+- switch sfdx-faye with faye ([a0545e5](https://github.com/forcedotcom/sfdx-core/commit/a0545e57d5041c97e499f284afbd7fcb16cf2247))
+
+### Bug Fixes
+
+- no maxquery warning when records.length is 0 ([758f912](https://github.com/forcedotcom/sfdx-core/commit/758f912a23bd3e9f8d4f854f3e07682dd4d4c4aa))
+
+### [2.31.1](https://github.com/forcedotcom/sfdx-core/compare/v2.31.0...v2.31.1) (2021-12-06)
+
+## [2.31.0](https://github.com/forcedotcom/sfdx-core/compare/v2.30.1...v2.31.0) (2021-11-30)
+
+### Features
+
+- bump version of jsforce ([7d89024](https://github.com/forcedotcom/sfdx-core/commit/7d89024f593968c031af22ac817efc26d00fcd54))
+
+### [2.30.1](https://github.com/forcedotcom/sfdx-core/compare/v2.30.0...v2.30.1) (2021-11-30)
+
+### Bug Fixes
+
+- better output for authUrl errors ([f3ec729](https://github.com/forcedotcom/sfdx-core/commit/f3ec7298bdbd3194d3d14bfea09f47f413669376))
+
+## [2.30.0](https://github.com/forcedotcom/sfdx-core/compare/v2.29.0...v2.30.0) (2021-11-25)
+
+### Features
+
+- delete scratch orgs and sandboxes ([#491](https://github.com/forcedotcom/sfdx-core/issues/491)) ([468c348](https://github.com/forcedotcom/sfdx-core/commit/468c348f0ecc69ddeea02927bf7a26ca660a86ca))
+
+## [2.29.0](https://github.com/forcedotcom/sfdx-core/compare/v2.28.4...v2.29.0) (2021-11-17)
+
+### Features
+
+- cleans up old listeners from upgraded instance ([e3f2d69](https://github.com/forcedotcom/sfdx-core/commit/e3f2d69ccd5c096d37addb1b982e19354175f11a))
+- use warnings instead of process in sfdx-core ([c1f7e98](https://github.com/forcedotcom/sfdx-core/commit/c1f7e98f6b19d57da1a2ee0cdf58e449079f0ee7))
+- warning and telemetry events ([80a8039](https://github.com/forcedotcom/sfdx-core/commit/80a8039e2f686d973ddbc24c9a2980fb93928d13))
+- warning and telemetry events ([a04b293](https://github.com/forcedotcom/sfdx-core/commit/a04b29355c8ca6c7e37e071ccc159aff5e5e9ca0))
+
+### Bug Fixes
+
+- transfer listeners when upgrading the global instance to newer version ([0a40831](https://github.com/forcedotcom/sfdx-core/commit/0a408317c132548771ced0fe196178d2e9c76232))
+
+### [2.28.4](https://github.com/forcedotcom/sfdx-core/compare/v2.28.3...v2.28.4) (2021-11-10)
+
+### Bug Fixes
+
+- bump jsforce types and run unit tests on Windows ([#485](https://github.com/forcedotcom/sfdx-core/issues/485)) ([3952c8f](https://github.com/forcedotcom/sfdx-core/commit/3952c8fe248531a0597477ed12240f611048caba))
+
+### [2.28.3](https://github.com/forcedotcom/sfdx-core/compare/v2.28.2...v2.28.3) (2021-11-08)
+
+### Bug Fixes
+
+- fix unit test ([d903c04](https://github.com/forcedotcom/sfdx-core/commit/d903c04e5f3e4f01fccb3f00b91560c443013ddf))
+- force new release ([124bb74](https://github.com/forcedotcom/sfdx-core/commit/124bb744c5ecc28cb8babf285c6d8c3032eb7ef6))
+- improve error message when providing an invalid username ([2ab4bbd](https://github.com/forcedotcom/sfdx-core/commit/2ab4bbdefd962283d88ccb735de88c88fe189d39))
+
+### [2.28.2](https://github.com/forcedotcom/sfdx-core/compare/v2.28.1...v2.28.2) (2021-10-13)
+
+### Bug Fixes
+
+- support for .mil sandboxes ([9ef35c7](https://github.com/forcedotcom/sfdx-core/commit/9ef35c7b1ef0fe974c3bd3b89b862a436e00f7d9))
+
 ### [2.28.1](https://github.com/forcedotcom/sfdx-core/compare/v2.28.0...v2.28.1) (2021-10-06)
 
 ### Bug Fixes

CODEOWNERS

@@ -0,0 +1,2 @@
+# Comment line immediately above ownership line is reserved for related gus information. Please be careful while editing.
+#ECCN:Open Source

LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2018, Salesforce.com, Inc.
+Copyright (c) 2021, Salesforce.com, Inc.
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

examples/yarn.lock

@@ -1046,9 +1046,9 @@ path-is-absolute@^1.0.0:
   integrity sha1-F0uSaHNVNP+8es5r9TpanhtcX18=
 
 path-parse@^1.0.6:
-  version "1.0.6"
-  resolved "https://registry.npmjs.org/path-parse/-/path-parse-1.0.6.tgz#d62dbb5679405d72c4737ec58600e9ddcf06d24c"
-  integrity sha512-GSmOT2EbHrINBf9SR7CDELwlJ8AENk3Qn7OikK4nFYAu3Ote2+JYNVvkpAEQm3/TLNEJFD/xZJjzyxg3KBWOzw==
+  version "1.0.7"
+  resolved "https://registry.yarnpkg.com/path-parse/-/path-parse-1.0.7.tgz#fbc114b60ca42b30d9daf5858e4bd68bbedb6735"
+  integrity sha512-LDJzPVEEEPR+y48z93A0Ed0yXb8pAByGWo/k5YYdYgpY2/2EsOsksJrq7lOHxryrVOn1ejG6oAp8ahvOIQD8sw==
 
 path-to-regexp@^1.7.0:
   version "1.7.0"

messages/core.json

@@ -12,9 +12,9 @@
   "OrgDataNotAvailableErrorAction2": "Use `sfdx force:config:set` to update the defaultusername.",
   "OrgDataNotAvailableErrorAction3": "Use `sfdx force:org:create` to create a new org.",
   "OrgDataNotAvailableErrorAction4": "Use `sfdx force:auth` to authenticate an existing org.",
-  "NamedOrgNotFound": "No AuthInfo found for name %s",
-  "NoAliasesFound": "Nothing to set",
-  "InvalidFormat": "Setting aliases must be in the format <key>=<value> but found: [%s]",
+  "NamedOrgNotFound": "No authorization information found for %s %s.",
+  "NoAliasesFound": "Nothing to set.",
+  "InvalidFormat": "Setting aliases must be in the format <key>=<value> but found: [%s].",
   "NoAuthInfoFound": "No authorization information can be found.",
   "InvalidJsonCasing": "All JSON input must have heads down camelcase keys.  E.g., { sfdcLoginUrl: \"https://login.salesforce.com\" }\nFound \"%s\" at %s"
 }

messages/core.md

@@ -41,7 +41,7 @@ An attempt to refresh the authentication token failed with a 'Data Not Found Err
 
 # namedOrgNotFound
 
-No AuthInfo found for name %s.
+No authorization information found for %s.
 
 # noAliasesFound
 

messages/org.md

@@ -5,3 +5,39 @@ The provided dev hub username %s is not a valid dev hub.
 # noUsernameFound
 
 No username found.
+
+# noDevHubFound
+
+Unable to associate this scratch org with a DevHub.
+
+# deleteOrgHubError
+
+The Dev Hub org cannot be deleted.
+
+# insufficientAccessToDelete
+
+You do not have the appropriate permissions to delete a scratch org. Please contact your Salesforce admin.
+
+# scratchOrgNotFound
+
+Attempting to delete an expired or deleted org
+
+# sandboxDeleteFailed
+
+The sandbox org deletion failed with a result of %s.
+
+# sandboxNotFound
+
+We can't find a SandboxProcess for the sandbox org %s.
+
+# sandboxInfoCreateFailed
+
+The sandbox org creation failed with a result of %s.
+
+# missingAuthUsername
+
+The sandbox %s does not have an authorized username.
+
+# orgPollingTimeout
+
+Sandbox status is %s; timed out waiting for completion.

package.json

@@ -3,19 +3,21 @@
   "version": "3.7.2",
   "description": "Core libraries to interact with SFDX projects, orgs, and APIs.",
   "main": "lib/exported",
+  "types": "lib/exported.d.ts",
   "license": "BSD-3-Clause",
   "scripts": {
     "build": "sf-build",
     "ci-docs": "yarn sf-ci-docs",
     "clean": "sf-clean",
-    "clean-all": "-clean all",
+    "clean-all": "sf-clean all",
     "compile": "sf-compile",
     "docs": "sf-docs",
     "format": "sf-format",
     "lint": "sf-lint",
     "lint-fix": "yarn sf-lint --fix",
     "postcompile": "tsc -p test && tsc -p typedocExamples",
-    "prepack": "sf-build",
+    "prepack": "sf-prepack",
+    "prepare": "sf-install",
     "pretest": "sf-compile-test",
     "test": "sf-test"
   },
@@ -31,13 +33,6 @@
     "messages",
     "!lib/**/*.map"
   ],
-  "husky": {
-    "hooks": {
-      "commit-msg": "sf-husky-commit-msg",
-      "pre-commit": "sf-husky-pre-commit",
-      "pre-push": "sf-husky-pre-push"
-    }
-  },
   "dependencies": {
     "@salesforce/bunyan": "^2.0.0",
     "@salesforce/kit": "^1.5.8",
@@ -46,53 +41,50 @@
     "@types/graceful-fs": "^4.1.5",
     "@types/jsforce": "^1.9.29",
     "@types/mkdirp": "^1.0.1",
-    "@types/sfdx-faye": "^1.0.0",
+    "@types/semver": "^7.3.9",
     "change-case": "^4.1.2",
     "debug": "^3.1.0",
+    "faye": "^1.4.0",
     "form-data": "^4.0.0",
     "graceful-fs": "^4.2.4",
     "jsen": "0.6.6",
     "jsforce": "2.0.0-beta.7",
     "jsonwebtoken": "8.5.0",
     "mkdirp": "1.0.4",
-    "sfdx-faye": "^1.0.9",
     "ts-retry-promise": "^0.6.0"
   },
   "devDependencies": {
-    "@salesforce/dev-config": "^2.0.0",
-    "@salesforce/dev-scripts": "^0.9.18",
+    "@salesforce/dev-config": "^2.1.2",
+    "@salesforce/dev-scripts": "^1.0.2",
     "@salesforce/prettier-config": "^0.0.2",
     "@salesforce/ts-sinon": "^1.3.15",
     "@types/debug": "0.0.30",
     "@types/jsen": "0.0.19",
     "@types/jsonwebtoken": "8.3.2",
-    "@types/sfdx-faye": "^1.0.0",
     "@types/shelljs": "0.7.8",
-    "@types/sinon": "^9.0.8",
     "@typescript-eslint/eslint-plugin": "^4.2.0",
     "@typescript-eslint/parser": "4.26.0",
     "chai": "^4.2.0",
     "commitizen": "^3.0.5",
     "eslint": "^6.8.0",
     "eslint-config-prettier": "^6.11.0",
     "eslint-config-salesforce": "^0.1.6",
-    "eslint-config-salesforce-license": "^0.1.0",
+    "eslint-config-salesforce-license": "^0.1.6",
     "eslint-config-salesforce-typescript": "^0.2.7",
     "eslint-plugin-header": "^3.0.0",
     "eslint-plugin-import": "^2.20.2",
     "eslint-plugin-jsdoc": "^27.0.3",
     "eslint-plugin-prettier": "^3.1.3",
-    "husky": "^4.2.5",
-    "mocha": "^7.2.0",
+    "husky": "^7.0.4",
+    "mocha": "^8.4.0",
     "nyc": "^15.1.0",
     "prettier": "^2.0.5",
-    "pretty-quick": "^2.0.1",
+    "pretty-quick": "^3.1.0",
     "shelljs": "0.8.1",
-    "sinon": "^9.0.2",
-    "ts-node": "^8.10.2",
+    "sinon": "10.0.0",
+    "ts-node": "^10.0.0",
     "typescript": "^4.1.3"
   },
-  "types": "lib/exported.d.ts",
   "repository": {
     "type": "git",
     "url": "https://github.com/forcedotcom/sfdx-core.git"

src/config/configStore.ts

@@ -331,8 +331,7 @@ export abstract class BaseConfigStore<
 
   // Allows extended classes the ability to override the set method. i.e. maybe they want
   // nested object set from kit.
-  // NOTE: Key and value must stay string and value to be reliably overwritten.
-  protected setMethod(contents: ConfigContents, key: string, value?: ConfigValue) {
+  protected setMethod(contents: ConfigContents, key: string, value?: ConfigValue): void {
     set(contents, key, value);
   }
 

src/crypto/keyChainImpl.ts

@@ -79,7 +79,7 @@ const _validateProgram = async (
   programPath: string,
   fsIfc: FsIfc,
   isExeIfc: (mode: number, gid: number, uid: number) => boolean
-) => {
+): Promise<void> => {
   let noPermission;
   try {
     const stats = fsIfc.statSync(programPath);
@@ -134,7 +134,7 @@ export class KeychainAccess implements PasswordStore {
   /**
    * Validates the os level program is executable.
    */
-  public async validateProgram() {
+  public async validateProgram(): Promise<void> {
     await _validateProgram(this.osImpl.getProgram(), this.fsIfc, _isExe);
   }
 

src/exported.ts

@@ -61,7 +61,17 @@ export {
 
 export { Messages } from './messages';
 
-export { Org } from './org/org';
+export {
+  Org,
+  SandboxProcessObject,
+  StatusEvent,
+  SandboxEvents,
+  SandboxUserAuthResponse,
+  SandboxUserAuthRequest,
+  SandboxRequest,
+  OrgTypes,
+  ResultEvent,
+} from './org';
 
 export { OrgConfigProperties, ORG_CONFIG_ALLOWED_PROPERTIES } from './org/orgConfigProperties';