Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forget some files in npmjs.com #9

Closed
tani opened this issue Jun 17, 2019 · 6 comments
Closed

Forget some files in npmjs.com #9

tani opened this issue Jun 17, 2019 · 6 comments

Comments

@tani
Copy link

tani commented Jun 17, 2019

Hi @foliojs, @devongovett you forgot to upload a few files to npmjs.com. We cannot use this library now. Can you bump up version?

@devongovett
Copy link
Member

What’s missing?

@tani
Copy link
Author

tani commented Jun 17, 2019

There is no javascript files,

$ ls node_modules/unicode-properties
LICENSE  node_modules/  package.json  readme.md

@devongovett
Copy link
Member

Should be fixed by 8737993 in v1.2.1. npm's files config is not very intuitive 😦.

@tani
Copy link
Author

tani commented Jun 17, 2019

Thanks!

@tani
Copy link
Author

tani commented Jun 17, 2019

@devongovett Oh, excuse me? you still forget to update package.json because you wrote "main": "dist/unicode-properties.cjs.js" there. we still cannot use your library as cjs. You should update it to "main": "unicode-properties.cjs.js".

I agree what you said. npm not intuitive for developers.

@devongovett
Copy link
Member

wow, I'm on a roll. should be fixed in v1.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants