@@ -70,8 +70,8 @@ permissions:
7070
7171jobs :
7272 package-preview :
73- if : github.ref == 'refs/heads/recipe-v26'
74- needs : [ci-required, curated-tests-android, curated-tests-ios]
73+ if : github.ref == 'refs/heads/recipe-v26' || (github.event_name == 'pull_request' && needs.upgrade-check.outputs.upgrade == 'true')
74+ needs : [release-check, upgrade-check, ci-required, curated-tests-android, curated-tests-ios]
7575 runs-on : ubuntu-24.04
7676 permissions :
7777 contents : read
@@ -86,17 +86,18 @@ jobs:
8686 run : python3 scripts/package-preview.py preview-input preview-packages
8787 - uses : actions/upload-artifact@v7
8888 with :
89- name : nodejs-mobile-26.10.0-0 -preview
89+ name : nodejs-mobile-${{ needs.release-check.outputs.version }} -preview
9090 path : preview-packages
9191 retention-days : 90
9292 if-no-files-found : error
9393
9494 # Flavor matrices are inline expressions, not a helper job (a full VM boot
9595 # to echo two constants earns nothing). Android always runs both flavors
9696 # (ubuntu+KVM is 1x-billed and plentiful); iOS drops to full-only on
97- # pull_request because hosted macOS concurrency is capped far below Linux
97+ # ordinary pull_request because hosted macOS concurrency is capped far below Linux
9898 # and two PRs running the complete iOS matrix could queue the release
99- # pipeline behind them. What the lite iOS leg uniquely catches —
99+ # pipeline behind them. Upstream upgrades build and smoke both iOS flavors.
100+ # What the lite iOS leg uniquely catches —
100101 # lite-specific configure/link breakage — is still caught at compile time
101102 # on the merge run. Pushes and releases run both. See docs/TESTING.md,
102103 # "Flavors, and what's required to merge".
@@ -319,11 +320,11 @@ jobs:
319320 path : out_android
320321
321322 build-ios :
322- needs : release-check
323+ needs : [ release-check, upgrade-check]
323324 strategy :
324325 fail-fast : false
325326 matrix :
326- flavor : ${{ github.event_name == 'pull_request' && fromJSON('["full"]') || fromJSON('["full","lite"]') }}
327+ flavor : ${{ github.event_name == 'pull_request' && needs.upgrade-check.outputs.upgrade != 'true' && fromJSON('["full"]') || fromJSON('["full","lite"]') }}
327328 config :
328329 # x86_64 (Intel Mac) simulator support was dropped for v24 — Intel
329330 # Macs are EOL.
@@ -567,9 +568,9 @@ jobs:
567568 strategy :
568569 fail-fast : false
569570 matrix :
570- flavor : ${{ github.event_name == 'pull_request' && fromJSON('["full"]') || fromJSON('["full","lite"]') }}
571+ flavor : ${{ github.event_name == 'pull_request' && needs.upgrade-check.outputs.upgrade != 'true' && fromJSON('["full"]') || fromJSON('["full","lite"]') }}
571572 runs-on : macos-26
572- needs : [build-ios]
573+ needs : [build-ios, upgrade-check ]
573574 env :
574575 NODEJS_MOBILE_FLAVOR : ${{ matrix.flavor }}
575576 FLAVOR_SUFFIX : ${{ matrix.flavor == 'lite' && '-lite' || '' }}
@@ -696,11 +697,11 @@ jobs:
696697 # Boot smoke for iOS: install the testnode app on a booted simulator and run a
697698 # console.log via the freshly built NodeMobile.xcframework.
698699 smoke-ios :
699- needs : [combine-ios]
700+ needs : [combine-ios, upgrade-check ]
700701 strategy :
701702 fail-fast : false
702703 matrix :
703- flavor : ${{ github.event_name == 'pull_request' && fromJSON('["full"]') || fromJSON('["full","lite"]') }}
704+ flavor : ${{ github.event_name == 'pull_request' && needs.upgrade-check.outputs.upgrade != 'true' && fromJSON('["full"]') || fromJSON('["full","lite"]') }}
704705 runs-on : macos-26
705706 env :
706707 NODEJS_MOBILE_FLAVOR : ${{ matrix.flavor }}
@@ -1223,13 +1224,23 @@ jobs:
12231224 fetch-depth : 1
12241225
12251226 - name : Check the pinned upstream base is on this fork
1227+ env :
1228+ GH_TOKEN : ${{ github.token }}
12261229 run : |
12271230 set -euo pipefail
12281231 # || true: grep exits 1 on a comments-only file, which under pipefail
12291232 # would kill the step before the message below ever prints.
12301233 BASE=$(grep -Ev '^\s*(#|$)' upstream-base.txt | head -n1 | tr -d '[:space:]' || true)
12311234 [ -n "$BASE" ] || { echo "::error::no base in upstream-base.txt"; exit 1; }
12321235
1236+ if [[ "$BASE" =~ ^[0-9a-f]{40}$ ]]; then
1237+ WANT=$(gh api "repos/nodejs/node/commits/$BASE" --jq .sha)
1238+ [ "$WANT" = "$BASE" ] || { echo "::error::upstream snapshot SHA mismatch"; exit 1; }
1239+ echo "Verified upstream PR snapshot $BASE; no release ancestry ref is required."
1240+ # release-control.py rejects Cut release/publication for SHA bases.
1241+ exit 0
1242+ fi
1243+
12331244 # Each major keeps an independent upstream ancestry ref.
12341245 MAJOR=${BASE#v}; MAJOR=${MAJOR%%.*}
12351246 BASE_REF=upstream-base
0 commit comments