[Icewind52]

Tracking issue

Related to #8235

Why are the changes needed?

The flyte.active_runs and flyte.active_actions gauges in #8235 need a count of live actions from the database. This adds the repo method the runs sampler will call. The sampler itself is a follow-up PR.

What changes were proposed in this pull request?

Adds ActionRepo. CountActiveActionsByPhase , as suggested in the issue, with two adjustments:

1. Map key. The query groups by (phase, is_root), but a map[int32]int64 keyed by phase alone would let the root and child rows for the same phase overwrite each other. The method returns map[PhaseKey]int64 with PhaseKey{Phase, IsRoot} instead.
2. Non-terminal filter. The query filters with WHERE phase = ANY(<non-terminal phases>) so it reads only live actions.

Note: FAILED and TIMED_OUT count as terminal, so an action waiting between retries isn't counted until it moves back to a live phase.

How was this patch tested?

• TestCountActiveActionsByPhase (embedded Postgres): an empty table, plus live and finished runs with children in every phase. It checks that only non-terminal actions are counted and that roots and children are split.

Mock now regenerated. Adding a method to ActionRepo means runs/repository/mocks/mocks.go needs regenerating, but make mocks currently fails, both locally and in CI:

internal error: package "context" without types was imported from "github.com/eko/gocache/lib/v4/cache"

This started with #7949 (Go 1.26.5 → 1.27.2 in gen.Dockerfile, mockery still v3.7.0). The first failing check-mocks run is 37968610418, and it still fails today (40579043741). The job stays green because the timed macro in the Makefile ignores mockery's exit code, so nothing is written and git diff finds no changes. make mocks exits 0 locally too.

This is what I observed, not sure if this is a real regression.

Labels

• added

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

[pingsutw]

LGTM, just one nit

[Copilot]

🟢 Approval recommended

No active review issues were identified for the live-action counting changes.

No open issues 🎉

1 file not reviewed

• runs/repository/mocks/mocks.go: Generated file

What changed in this PR

Adds repository support for counting live actions, preparing for the flyte.active_runs and flyte.active_actions gauges tracked in #8235. The sampler remains a follow-up change.

Changes:

• Adds CountActiveActionsByPhase, returning counts keyed by phase and root/child status.
• Filters the aggregate query to non-terminal phases.
• Updates the mock and adds database tests for empty results, terminal exclusion, and root/child separation.

File	Description
runs/​repository/​mocks/​mocks.go	Adds mock support for the new count method.
runs/​repository/​interfaces/​action.go	Defines the count method and composite PhaseKey.
runs/​repository/​impl/​action.go	Defines active phases and implements the aggregate query.
runs/​repository/​impl/​action_test.go	Tests filtering, grouped counts, and gauge totals.

_{Review effort: Balanced}

[0yukali0]

+1, LGTM.

The new test is also ideal.
It uses both active and non-active actions to verify that the function returns the correct counts grouped by phase and is_root.