Fix master branch build (#8065)

* Make build deterministic

Signed-off-by: Jason Parraga <sovietaced@gmail.com>

* Pin minio

Signed-off-by: Jason Parraga <sovietaced@gmail.com>

---------

Signed-off-by: Jason Parraga <sovietaced@gmail.com>

Author: Sovietaced

flyteadmin/script/integration/k8s/integration.yaml

@@ -152,7 +152,7 @@ spec:
           persistentVolumeClaim:
             claimName: minio-volume-claim
       containers:
-        - image: "minio/minio:edge"
+        - image: "quay.io/minio/minio:RELEASE.2025-09-07T16-13-09Z"
           name: minio
           env:
             - name: MINIO_ACCESS_KEY

flyteadmin/tests/launch_plan_test.go

@@ -12,6 +12,7 @@ import (
 
 	"github.com/golang/protobuf/proto"
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 
 	"github.com/flyteorg/flyte/flyteidl/clients/go/coreutils"
 	"github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/admin"
@@ -237,47 +238,47 @@ func TestEnableDisableLaunchPlan(t *testing.T) {
 	createWorkflowReq := getWorkflowCreateRequest()
 
 	_, err := client.CreateWorkflow(ctx, &createWorkflowReq)
-	assert.Nil(t, err)
+	require.NoError(t, err, "create workflow")
 
 	createLaunchPlanReq := getLaunchPlanCreateRequest(createWorkflowReq.Id)
 	_, err = client.CreateLaunchPlan(ctx, &createLaunchPlanReq)
-	assert.Nil(t, err)
+	require.NoError(t, err, "create launch plan")
 
 	// Test that enabling a launch plan succeeds.
 	_, err = client.UpdateLaunchPlan(ctx, &admin.LaunchPlanUpdateRequest{
 		Id:    &launchPlanIdentifier,
 		State: admin.LaunchPlanState_ACTIVE,
 	})
-	assert.Nil(t, err)
+	require.NoError(t, err, "activate launch plan")
 	enabledLaunchPlan, err := client.GetLaunchPlan(ctx, &admin.ObjectGetRequest{
 		Id: createLaunchPlanReq.Id,
 	})
-	assert.Nil(t, err)
+	require.NoError(t, err, "get active launch plan")
 	assert.Equal(t, admin.LaunchPlanState_ACTIVE, enabledLaunchPlan.Closure.State)
 
 	// Make sure successive calls to set active are ... successful.
 	_, err = client.UpdateLaunchPlan(ctx, &admin.LaunchPlanUpdateRequest{
 		Id:    createLaunchPlanReq.Id,
 		State: admin.LaunchPlanState_ACTIVE,
 	})
-	assert.Nil(t, err)
+	require.NoError(t, err, "activate launch plan again")
 	enabledLaunchPlan, err = client.GetLaunchPlan(ctx, &admin.ObjectGetRequest{
 		Id: createLaunchPlanReq.Id,
 	})
-	assert.Nil(t, err)
+	require.NoError(t, err, "get active launch plan again")
 	assert.Equal(t, admin.LaunchPlanState_ACTIVE, enabledLaunchPlan.Closure.State)
 
 	// Test that disabling a launch plan succeeds.
 	_, err = client.UpdateLaunchPlan(ctx, &admin.LaunchPlanUpdateRequest{
 		Id:    &launchPlanIdentifier,
 		State: admin.LaunchPlanState_INACTIVE,
 	})
-	assert.Nil(t, err)
+	require.NoError(t, err, "deactivate launch plan")
 
 	disabledLaunchPlan, err := client.GetLaunchPlan(ctx, &admin.ObjectGetRequest{
 		Id: createLaunchPlanReq.Id,
 	})
-	assert.Nil(t, err)
+	require.NoError(t, err, "get inactive launch plan")
 	assert.Equal(t, admin.LaunchPlanState_INACTIVE, disabledLaunchPlan.Closure.State)
 }
 
@@ -293,18 +294,18 @@ func TestUpdateActiveLaunchPlanVersion(t *testing.T) {
 	createWorkflowReq := getWorkflowCreateRequest()
 
 	_, err := client.CreateWorkflow(ctx, &createWorkflowReq)
-	assert.Nil(t, err)
+	require.NoError(t, err, "create workflow")
 
 	// Create a test launch plan and set it to active.
 	createLaunchPlanReq := getLaunchPlanCreateRequest(createWorkflowReq.Id)
 	_, err = client.CreateLaunchPlan(ctx, &createLaunchPlanReq)
-	assert.Nil(t, err)
+	require.NoError(t, err, "create original launch plan")
 
 	_, err = client.UpdateLaunchPlan(ctx, &admin.LaunchPlanUpdateRequest{
 		Id:    &launchPlanIdentifier,
 		State: admin.LaunchPlanState_ACTIVE,
 	})
-	assert.Nil(t, err)
+	require.NoError(t, err, "activate original launch plan")
 
 	// Create a new version of the launch plan and set that to active.
 	newIdentifier := core.Identifier{
@@ -317,25 +318,25 @@ func TestUpdateActiveLaunchPlanVersion(t *testing.T) {
 	createNewLaunchPlanReq := getLaunchPlanCreateRequest(createWorkflowReq.Id)
 	createNewLaunchPlanReq.Id = &newIdentifier
 	_, err = client.CreateLaunchPlan(ctx, &createNewLaunchPlanReq)
-	assert.Nil(t, err)
+	require.NoError(t, err, "create new launch plan version")
 
 	_, err = client.UpdateLaunchPlan(ctx, &admin.LaunchPlanUpdateRequest{
 		Id:    &newIdentifier,
 		State: admin.LaunchPlanState_ACTIVE,
 	})
-	assert.Nil(t, err)
+	require.NoError(t, err, "activate new launch plan version")
 
 	enabledLaunchPlan, err := client.GetLaunchPlan(ctx, &admin.ObjectGetRequest{
 		Id: &newIdentifier,
 	})
-	assert.Nil(t, err)
+	require.NoError(t, err, "get new launch plan version")
 	assert.Equal(t, admin.LaunchPlanState_ACTIVE, enabledLaunchPlan.Closure.State)
 
 	// Assert that by enabling a specific launch version admin also disables the previously active version.
 	disabledLaunchPlan, err := client.GetLaunchPlan(ctx, &admin.ObjectGetRequest{
 		Id: &launchPlanIdentifier,
 	})
-	assert.Nil(t, err)
+	require.NoError(t, err, "get original launch plan version")
 	assert.Equal(t, admin.LaunchPlanState_INACTIVE, disabledLaunchPlan.Closure.State)
 }
 

flyteidl/generate_protos.sh

@@ -7,8 +7,8 @@ rm -rf $DIR/gen
 # Override system locale during protos/docs generation to ensure consistent sorting (differences in system locale could e.g. lead to differently ordered docs)
 export LC_ALL=C.UTF-8
 
-# Buf migration
-docker run -u $(id -u):$(id -g) -e "BUF_CACHE_DIR=/tmp/cache" --volume "$(pwd):/workspace" --workdir /workspace bufbuild/buf generate
+# Pin Buf because its bundled well-known protobuf types affect Swagger descriptions.
+docker run -u $(id -u):$(id -g) -e "BUF_CACHE_DIR=/tmp/cache" --volume "$(pwd):/workspace" --workdir /workspace bufbuild/buf:1.57.2 generate
 
 # Unfortunately the python protoc plugin does not add __init__.py files to the generated code
 # (as described in https://github.com/protocolbuffers/protobuf/issues/881). One of the