Skip to content

Commit e3d8a3f

Browse files
committed
Fix tests for lazy artifact registry credentials
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
1 parent d00344a commit e3d8a3f

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎internal/controller/helmchart_controller_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2516,7 +2516,7 @@ func TestHelmChartReconciler_reconcileSourceFromOCI_authStrategy(t *testing.T) {
25162516
provider: "aws",
25172517
providerImg: "oci://123456789000.dkr.ecr.us-east-2.amazonaws.com/test",
25182518
assertConditions: []metav1.Condition{
2519-
*conditions.TrueCondition(sourcev1.FetchFailedCondition, "Unknown", "unknown build error: failed to get credential from"),
2519+
*conditions.TrueCondition(sourcev1.FetchFailedCondition, "Unknown", "unknown build error: unable to get authentication data from OIDC: failed to get access token for artifact registry"),
25202520
},
25212521
},
25222522
{

‎internal/controller/ocirepository_controller_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -690,7 +690,7 @@ func TestOCIRepository_reconcileSource_authStrategy(t *testing.T) {
690690
crane.Insecure,
691691
},
692692
assertConditions: []metav1.Condition{
693-
*conditions.TrueCondition(sourcev1.FetchFailedCondition, sourcev1.AuthenticationFailedReason, "%s", "failed to get credential from"),
693+
*conditions.TrueCondition(sourcev1.FetchFailedCondition, sourcev1.OCIPullFailedReason, "%s", "failed to get access token for artifact registry"),
694694
},
695695
},
696696
{
@@ -3127,7 +3127,7 @@ func TestOCIRepository_objectLevelWorkloadIdentityFeatureGate(t *testing.T) {
31273127
}
31283128
logOCIRepoStatus(t, resultobj)
31293129
return !conditions.IsReady(resultobj) &&
3130-
conditions.GetReason(resultobj, meta.ReadyCondition) == sourcev1.AuthenticationFailedReason
3130+
conditions.GetReason(resultobj, meta.ReadyCondition) == sourcev1.OCIPullFailedReason
31313131
}).Should(BeTrue())
31323132
}
31333133

0 commit comments

Comments
 (0)