Skip to content

Commit ef1c93e

Browse files
committedNov 24, 2021
Remove unnecessary function alias declarations.
1 parent 3e08247 commit ef1c93e

File tree

4 files changed

+18
-45
lines changed

4 files changed

+18
-45
lines changed
 

Diff for: ‎lib/src/media_stream.dart

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,16 @@
11
import 'media_stream_track.dart';
22

3-
typedef MediaTrackCallback = void Function(MediaStreamTrack track);
4-
53
///https://w3c.github.io/mediacapture-main/#mediastream
64
abstract class MediaStream {
75
MediaStream(this._id, this._ownerTag);
86
final String _id;
97
final String _ownerTag;
108

119
/// The event type of this event handler is addtrack.
12-
MediaTrackCallback? onAddTrack;
10+
Function(MediaStreamTrack track)? onAddTrack;
1311

1412
/// The event type of this event handler is removetrack.
15-
MediaTrackCallback? onRemoveTrack;
13+
Function(MediaStreamTrack track)? onRemoveTrack;
1614

1715
String get id => _id;
1816

Diff for: ‎lib/src/rtc_data_channel.dart

+2-7
Original file line numberDiff line numberDiff line change
@@ -61,16 +61,11 @@ class RTCDataChannelMessage {
6161
Uint8List get binary => _data;
6262
}
6363

64-
typedef RTCDataChannelStateCallback = void Function(RTCDataChannelState state);
65-
66-
typedef RTCDataChannelOnMessageCallback = void Function(
67-
RTCDataChannelMessage data);
68-
6964
abstract class RTCDataChannel {
7065
RTCDataChannel();
7166

72-
RTCDataChannelStateCallback? onDataChannelState;
73-
RTCDataChannelOnMessageCallback? onMessage;
67+
Function(RTCDataChannelState state)? onDataChannelState;
68+
Function(RTCDataChannelMessage data)? onMessage;
7469

7570
/// Get current state.
7671
RTCDataChannelState? get state;

Diff for: ‎lib/src/rtc_peerconnection.dart

+12-30
Original file line numberDiff line numberDiff line change
@@ -13,42 +13,24 @@ import 'rtc_session_description.dart';
1313
import 'rtc_stats_report.dart';
1414
import 'rtc_track_event.dart';
1515

16-
typedef SignalingStateCallback = void Function(RTCSignalingState state);
17-
typedef PeerConnectionStateCallback = void Function(
18-
RTCPeerConnectionState state);
19-
typedef IceGatheringStateCallback = void Function(RTCIceGatheringState state);
20-
typedef IceConnectionStateCallback = void Function(RTCIceConnectionState state);
21-
typedef IceCandidateCallback = void Function(RTCIceCandidate candidate);
22-
typedef AddStreamCallback = void Function(MediaStream stream);
23-
typedef RemoveStreamCallback = void Function(MediaStream stream);
24-
typedef AddTrackCallback = void Function(
25-
MediaStream stream, MediaStreamTrack track);
26-
typedef RemoveTrackCallback = void Function(
27-
MediaStream stream, MediaStreamTrack track);
28-
typedef RTCDataChannelCallback = void Function(RTCDataChannel channel);
29-
typedef RenegotiationNeededCallback = void Function();
30-
31-
/// Unified-Plan
32-
typedef UnifiedPlanTrackCallback = void Function(RTCTrackEvent event);
33-
3416
abstract class RTCPeerConnection {
3517
RTCPeerConnection();
3618

3719
// public: delegate
38-
SignalingStateCallback? onSignalingState;
39-
PeerConnectionStateCallback? onConnectionState;
40-
IceGatheringStateCallback? onIceGatheringState;
41-
IceConnectionStateCallback? onIceConnectionState;
42-
IceCandidateCallback? onIceCandidate;
43-
AddStreamCallback? onAddStream;
44-
RemoveStreamCallback? onRemoveStream;
45-
AddTrackCallback? onAddTrack;
46-
RemoveTrackCallback? onRemoveTrack;
47-
RTCDataChannelCallback? onDataChannel;
48-
RenegotiationNeededCallback? onRenegotiationNeeded;
20+
Function(RTCSignalingState state)? onSignalingState;
21+
Function(RTCPeerConnectionState state)? onConnectionState;
22+
Function(RTCIceGatheringState state)? onIceGatheringState;
23+
Function(RTCIceConnectionState state)? onIceConnectionState;
24+
Function(RTCIceCandidate candidate)? onIceCandidate;
25+
Function(MediaStream stream)? onAddStream;
26+
Function(MediaStream stream)? onRemoveStream;
27+
Function(MediaStream stream, MediaStreamTrack track)? onAddTrack;
28+
Function(MediaStream stream, MediaStreamTrack track)? onRemoveTrack;
29+
Function(RTCDataChannel channel)? onDataChannel;
30+
Function()? onRenegotiationNeeded;
4931

5032
/// Unified-Plan
51-
UnifiedPlanTrackCallback? onTrack;
33+
Function(RTCTrackEvent event)? onTrack;
5234

5335
RTCSignalingState? get signalingState;
5436

Diff for: ‎lib/src/rtc_rtp_receiver.dart

+2-4
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,14 @@ import 'media_stream_track.dart';
33
import 'rtc_rtp_parameters.dart';
44
import 'rtc_stats_report.dart';
55

6-
typedef OnFirstPacketReceivedCallback = void Function(
7-
RTCRtpReceiver rtpReceiver, RTCRtpMediaType mediaType);
8-
96
abstract class RTCRtpReceiver {
107
RTCRtpReceiver();
118

129
Future<List<StatsReport>> getStats();
1310

1411
/// public:
15-
OnFirstPacketReceivedCallback? onFirstPacketReceived;
12+
Function(RTCRtpReceiver rtpReceiver, RTCRtpMediaType mediaType)?
13+
onFirstPacketReceived;
1614

1715
/// The WebRTC specification only defines RTCRtpParameters in terms of senders,
1816
/// but this API also applies them to receivers, similar to ORTC:

0 commit comments

Comments
 (0)
Please sign in to comment.