chore: Improve setting the link sources

Author: marienfressinaud

src/controllers/links/Collections.php

@@ -107,7 +107,7 @@ public function update(Request $request): Response
 
         if (!auth\LinksAccess::canUpdate($user, $link)) {
             $link = $user->obtainLink($link);
-            utils\SourceHelper::setLinkSource($link, $from);
+            $link->setSourceFrom($from);
         }
 
         $form = new forms\links\EditLinkCollections(model: $link);

src/controllers/links/Read.php

@@ -55,7 +55,7 @@ public function create(Request $request): Response
 
         $link = $user->obtainLink($link);
         if (!$link->isPersisted()) {
-            utils\SourceHelper::setLinkSource($link, $from);
+            $link->setSourceFrom($from);
             $link->save();
         }
 
@@ -103,7 +103,7 @@ public function later(Request $request): Response
 
         $link = $user->obtainLink($link);
         if (!$link->isPersisted()) {
-            utils\SourceHelper::setLinkSource($link, $from);
+            $link->setSourceFrom($from);
             $link->save();
         }
 

src/models/Link.php

@@ -353,6 +353,18 @@ public function source(): User|Collection|null
         }
     }
 
+    /**
+     * Set the source properties of the link if "from" is a supported internal path.
+     */
+    public function setSourceFrom(string $from): void
+    {
+        list($source_type, $source_resource_id) = utils\SourceHelper::extractFromPath($from);
+        if ($source_type) {
+            $this->source_type = $source_type;
+            $this->source_resource_id = $source_resource_id;
+        }
+    }
+
     /**
      * Return whether or not the given user has the link URL in its bookmarks.
      */

src/utils/SourceHelper.php

@@ -10,18 +10,6 @@
  */
 class SourceHelper
 {
-    /**
-     * Set the source_* properties of a link if possible.
-     */
-    public static function setLinkSource(models\Link $link, string $from): void
-    {
-        list($source_type, $source_resource_id) = self::extractFromPath($from);
-        if ($source_type) {
-            $link->source_type = $source_type;
-            $link->source_resource_id = $source_resource_id;
-        }
-    }
-
     /**
      * Return the source type and resource id from a path.
      *