tec: Add official support for PHP 8.4

Author: marienfressinaud

.github/workflows/linters.yml

@@ -16,7 +16,7 @@ jobs:
         strategy:
             matrix:
                 operating-system: [ubuntu-22.04]
-                php-versions: ['8.2', '8.3']
+                php-versions: ['8.2', '8.3', '8.4']
 
         name: PHP ${{ matrix.php-versions }} CI on ${{ matrix.operating-system }}
 

.github/workflows/tests.yml

@@ -22,7 +22,7 @@ jobs:
         strategy:
             matrix:
                 operating-system: [ubuntu-22.04]
-                php-versions: ['8.2', '8.3']
+                php-versions: ['8.2', '8.3', '8.4']
 
         services:
             postgres:

.phpunit.xml

@@ -34,7 +34,7 @@
         </testsuite>
     </testsuites>
 
-    <source>
+    <source ignoreIndirectDeprecations="true">
         <include>
             <directory suffix=".php">src</directory>
             <directory suffix=".php">lib/SpiderBits</directory>

lib/SpiderBits/src/Url.php

@@ -131,27 +131,21 @@ public static function sanitize(string $url): string
         $host = trim($host, '.');
         $host = preg_replace('/\.{2,}/', '.', $host);
 
-        if ($host === null) {
-            $host = '';
-        }
-
         // The host can be a valid integer ip address, we want to normalize it
         // to 4 dot-separated decimal values
-        if (filter_var($host, FILTER_VALIDATE_INT) !== false) {
+        if ($host && filter_var($host, FILTER_VALIDATE_INT) !== false) {
             $host = long2ip(intval($host));
-
-            if ($host === false) {
-                $host = '';
-            }
         }
 
         // idn_to_ascii allows to transform an unicode hostname to an
         // ASCII representation
         // @see https://en.wikipedia.org/wiki/Punycode
         // It also lowercases the string.
-        $host = idn_to_ascii($host, IDNA_DEFAULT, INTL_IDNA_VARIANT_UTS46);
+        if ($host) {
+            $host = idn_to_ascii($host, IDNA_DEFAULT, INTL_IDNA_VARIANT_UTS46);
+        }
 
-        if ($host === false) {
+        if (!$host) {
             $host = '';
         }