Add frozen_string_literal: true in order to suppress 'warning: literal string will be frozen in the future'
#4599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Watson <[email protected]>
Signed-off-by: Watson <[email protected]>
Watson1978
force-pushed
the
frozen_string_literal
branch
from
b392ede to
af624d2
Compare
|
Thanks for clarifying the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
To supress
warning: literal string will be frozen in the future,we will require to fix with following proposals.
# frozen_string_literal: truein the beginning of the file# frozen_string_literal: falsein the beginning of the fileRUBYOPT="-disable=frozen_string_literal"as launch optionThese suggestions may be combined.
This PR adds
# frozen_string_literal: trueto all required files.Seems CI will be passed,
however, Fluentd might raise
FrozenErrorexception by unexpected frozen stringif it has not sufficient test suites...
Related to GH-4585
Docs Changes:
Release Note: