Skip to content

Commit 278e40b

Browse files
committed
Handle connection error at start an application
This change will reconnect to fluentd, but following error occurs while reconnecting: > logger-node/node_modules/fluent-logger/node_modules/readable-stream/lib/_stream_writable.js:491 > cb(); > ^ > > TypeError: cb is not a function > at afterWrite (/logger-node/node_modules/fluent-logger/node_modules/readable-stream/lib/_stream_writable.js:491:3) > at onwrite (/logger-node/node_modules/fluent-logger/node_modules/readable-stream/lib/_stream_writable.js:483:7) > at WritableState.onwrite (/logger-node/node_modules/fluent-logger/node_modules/readable-stream/lib/_stream_writable.js:180:5) > at sender.emit (/logger-node/node_modules/fluent-logger/lib/winston.js:46:21) > at callbacks.forEach (/logger-node/node_modules/fluent-logger/lib/sender.js:431:23) > at Array.forEach (<anonymous>) > at _socket.write (/logger-node/node_modules/fluent-logger/lib/sender.js:430:19) > at afterWrite (_stream_writable.js:480:3) > at process._tickCallback (internal/process/next_tick.js:63:19) See also nodejs/node#23895 Signed-off-by: Kenji Okimoto <[email protected]>
1 parent 0ae69ff commit 278e40b

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

lib/sender.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,8 @@ class FluentSender {
104104
}
105105

106106
this._push(tag, timestamp, data, callback);
107-
this._connect(() => {
107+
this._connect((error) => {
108+
error && callback && callback(error);
108109
this._flushSendQueue();
109110
});
110111
}
@@ -206,9 +207,9 @@ class FluentSender {
206207
this._connecting = true;
207208
process.nextTick(() => {
208209
if (this._socket === null) {
209-
this._doConnect(() => {
210+
this._doConnect((error) => {
210211
this._connecting = false;
211-
callback();
212+
callback(error);
212213
});
213214
} else {
214215
if (!this._socket.writable) {
@@ -232,7 +233,7 @@ class FluentSender {
232233
let errorHandler = (err) => {
233234
if (this._socket) {
234235
this._disconnect();
235-
this._handleEvent('error', err);
236+
this._handleEvent('error', err, callback);
236237
}
237238
};
238239
this._socket.on('error', errorHandler);

0 commit comments

Comments
 (0)