Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Abstract Domains IV] A Resolve Value Query #1107

Closed
EagleoutIce opened this issue Oct 25, 2024 · 0 comments · Fixed by #1267
Closed

[Abstract Domains IV] A Resolve Value Query #1107

EagleoutIce opened this issue Oct 25, 2024 · 0 comments · Fixed by #1267
Assignees
@gigalasr
Labels
abstract interpretation Related to abstract interpretation query api relates to the query api
Milestone
Abstract Domains

Comments

@EagleoutIce
Copy link
Member

#1106 gave us resolveValue - praise be! But external flowR-users have no way of accessing our (probably improving) value resolve mechanism! Hence we want to write a new query 🥳.

Currently, the Query API already lists many such queries to gain some inspiration!
In theory we want to have a similar interface to the static slice query - we request the value of a criteria (or a set of criteria) and we receive all calculated values (although the output format is subject to change for now)! For this we require a new message schema, tests, a way of visualizing the query results (especially for the documentation), and of course the main query executor! It is probably best to create a clown and own of the slicing queries and then follow the trail of type errors :D

In the end, please do not forget to add the query documentation to https://github.com/flowr-analysis/flowr/blob/main/src/documentation/print-query-wiki.ts :)
@EagleoutIce EagleoutIce added abstract interpretation Related to abstract interpretation query api relates to the query api labels Oct 25, 2024
@EagleoutIce EagleoutIce added this to the Abstract Domains milestone Oct 25, 2024
@EagleoutIce EagleoutIce mentioned this issue Nov 7, 2024
Open
gigalasr added a commit that referenced this issue Jan 27, 2025
@gigalasr
feat(query): add resolve value query - #1107
552578f
gigalasr added a commit that referenced this issue Jan 27, 2025
@gigalasr
lint(query): fix linting errors - #1107
c205712
gigalasr added a commit that referenced this issue Jan 28, 2025
@gigalasr
feat(query): fix printing of values in resolve value - #1107
da5f680
gigalasr added a commit that referenced this issue Jan 28, 2025
@gigalasr
feat(query): fix printing of values in resolve value - #1107
e5e412e
@gigalasr gigalasr linked a pull request Jan 28, 2025 that will close this issue
[Abstract Domains IV] A resolve value query #1267
Merged
gigalasr added a commit that referenced this issue Jan 28, 2025
@gigalasr
docs(query): add new resolve-value query to docs - #1107
d970a1c
gigalasr added a commit that referenced this issue Jan 28, 2025
@gigalasr
test(query): add test for resolve-value query - #1107
fd534fa
gigalasr added a commit that referenced this issue Jan 28, 2025
@gigalasr
lint(query): fix linting issues - #1107
b154465
gigalasr added a commit that referenced this issue Jan 30, 2025
@gigalasr
refactor(query): use idMap from ast to avoid null check - #1107
4295bac
gigalasr added a commit that referenced this issue Jan 30, 2025
@gigalasr
refactor(test): specify expected value explictly - #1107
ab90607
gigalasr added a commit that referenced this issue Jan 30, 2025
@gigalasr
lint(test): fix linting tests - #1107
416027b
EagleoutIce added a commit that referenced this issue Jan 30, 2025
@gigalasr @EagleoutIce
[Abstract Domains IV] A resolve value query (#1267)
d6ff156 
* feat(query): add resolve value query - #1107

* lint(query): fix linting errors - #1107

* feat(query): fix printing of values in resolve value - #1107

* feat(query): fix printing of values in resolve value - #1107

* docs(query): add new resolve-value query to docs - #1107

* test(query): add test for resolve-value query - #1107

* lint(query): fix linting issues - #1107

* feat(query): apply suggestions from code review

Co-authored-by: Florian Sihler <[email protected]>

* refactor(query): use idMap from ast to avoid null check - #1107

* refactor(test): specify expected value explictly - #1107

* lint(test): fix linting tests - #1107

* Update src/queries/catalog/resolve-value-query/resolve-value-query-format.ts

---------

Co-authored-by: Florian Sihler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gigalasr gigalasr

Labels
abstract interpretation Related to abstract interpretation query api relates to the query api
Projects
None yet
Milestone
Abstract Domains
Development

Successfully merging a pull request may close this issue.

[Abstract Domains IV] A resolve value query flowr-analysis/flowr
2 participants
@EagleoutIce @gigalasr