Skip to content

Commit ebdc458

Browse files
committed
Merge branch 'rails-8' of https://github.com/benedikt/flipper into benedikt-rails-8
2 parents 8080cfd + 3afdefd commit ebdc458

File tree

2 files changed

+19
-31
lines changed

2 files changed

+19
-31
lines changed

.github/workflows/ci.yml

+15-14
Original file line numberDiff line numberDiff line change
@@ -31,32 +31,32 @@ jobs:
3131
ruby: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3"]
3232
rails: ["5.2", "6.0.0", "6.1.0", "7.0.0", "7.1.0", "7.2.0", "8.0.0"]
3333
exclude:
34-
- ruby: "2.6"
35-
rails: "8.0.0"
36-
- ruby: "2.7"
37-
rails: "8.0.0"
38-
- ruby: "3.0"
39-
rails: "8.0.0"
40-
- ruby: "3.1"
41-
rails: "8.0.0"
42-
- ruby: "2.6"
43-
rails: "7.2.0"
44-
- ruby: "2.7"
45-
rails: "7.2.0"
46-
- ruby: "3.0"
47-
rails: "7.2.0"
4834
- ruby: "2.6"
4935
rails: "7.1.0"
5036
- ruby: "2.6"
5137
rails: "7.0.0"
38+
- ruby: "2.6"
39+
rails: "7.2.0"
40+
- ruby: "2.6"
41+
rails: "8.0.0"
5242
- ruby: "2.7"
5343
rails: "7.1.0"
44+
- ruby: "2.7"
45+
rails: "7.2.0"
46+
- ruby: "2.7"
47+
rails: "8.0.0"
5448
- ruby: "3.0"
5549
rails: "5.2"
50+
- ruby: "3.0"
51+
rails: "7.2.0"
52+
- ruby: "3.0"
53+
rails: "8.0.0"
5654
- ruby: "3.1"
5755
rails: "5.2"
5856
- ruby: "3.1"
5957
rails: "6.0.0"
58+
- ruby: "3.1"
59+
rails: "8.0.0"
6060
- ruby: "3.2"
6161
rails: "5.2"
6262
- ruby: "3.2"
@@ -70,6 +70,7 @@ jobs:
7070
- ruby: "3.3"
7171
rails: "6.1.0"
7272
env:
73+
SQLITE3_VERSION: ${{ matrix.rails == '8.0.0' && '2.1.0' || '1.4.1' }}
7374
REDIS_URL: redis://localhost:6379/0
7475
CI: true
7576
RAILS_VERSION: ${{ matrix.rails }}

Gemfile

+4-17
Original file line numberDiff line numberDiff line change
@@ -6,26 +6,14 @@ Dir['flipper-*.gemspec'].each do |gemspec|
66
gemspec(name: "flipper-#{plugin}", development_group: plugin)
77
end
88

9-
rails_version = ENV['RAILS_VERSION'] || '8.0'
10-
sqlite3_version = ENV['SQLITE3_VERSION'] || case rails_version
11-
when /8\.\d+/
12-
'2.1.0'
13-
when /7\.\d+/
14-
'1.4.1'
15-
when /6\.\d+/
16-
'1.4.1'
17-
when /5\.\d+/
18-
'1.3.11'
19-
end
20-
219
gem 'debug'
2210
gem 'rake'
2311
gem 'statsd-ruby', '~> 1.2.1'
2412
gem 'rspec', '~> 3.0'
2513
gem 'rack-test'
26-
gem 'rackup'
27-
gem 'sqlite3', "~> #{sqlite3_version}"
28-
gem 'rails', "~> #{rails_version}"
14+
gem 'rackup', '= 1.0.0'
15+
gem 'sqlite3', "~> #{ENV['SQLITE3_VERSION'] || '1.4.1'}"
16+
gem 'rails', "~> #{ENV['RAILS_VERSION'] || '7.1'}"
2917
gem 'minitest', '~> 5.18'
3018
gem 'minitest-documentation'
3119
gem 'webmock'
@@ -38,9 +26,8 @@ gem 'stackprof-webnav'
3826
gem 'flamegraph'
3927
gem 'mysql2'
4028
gem 'pg'
41-
gem 'cuprite', '0.15.0'
29+
gem 'cuprite'
4230
gem 'puma'
43-
gem 'ferrum', '0.14.0' # until we can upgrae to whatever is after 0.15.0 as that doesn't support 2.7
4431

4532
group(:guard) do
4633
gem 'guard'

0 commit comments

Comments
 (0)