Skip to content

Commit f72730a

Browse files
adaltonclaude
andcommitted
Address PR review feedback: fix phase reference and add feature-defect handling
- AGENTS.md: Correct `/decompose` to `/sync` — the `/sync` phase is what creates Jira issues, not `/decompose` which produces the story breakdown - validate.md: Add explicit handling for feature defects discovered during e2e test execution — mark tests as xfail/skip and note the defect rather than attempting to fix the feature implementation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent b8e2cc0 commit f72730a

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

AGENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ For detailed workflow development guidelines (structure, file conventions, testi
198198

199199
### e2e
200200

201-
- Requires a Jira [QE] Story (typically created by the design workflow's `/decompose` phase) as input
201+
- Requires a Jira [QE] Story (typically created by the design workflow's `/sync` phase) as input
202202
- Jira is read-only — no phase in this workflow writes to Jira
203203
- Discovery-based infrastructure: e2e test framework, harness, auxiliary services, execution commands, and conventions are discovered during `/ingest` — not hardcoded
204204
- Reference suite pattern: before writing tests, identifies the most similar existing e2e test suite and extracts its patterns (imports, setup/teardown, harness usage, assertions, labels)

e2e/skills/validate.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,12 @@ Typical checks for e2e test code (discovered, not hardcoded):
105105
1. Diagnose the failure — is it caused by the new test code or pre-existing?
106106
2. If caused by the new test code: fix it, commit the fix, re-run the check
107107
3. If pre-existing: note it in the validation report, do not fix it
108-
4. If unclear: report to the user
108+
4. If the test is correct but the feature behaves differently than the AC
109+
describes: this is a feature defect, not a test bug. Mark the test as
110+
xfail or skip with a reason referencing the AC, note the defect in the
111+
validation report, and continue. Do not fix the feature implementation —
112+
that is a [DEV] scope issue (see deviation rules in `/code`).
113+
5. If unclear: report to the user
109114

110115
### Step 4: Anti-Pattern Check
111116

0 commit comments

Comments
 (0)