Skip to content

Commit ef41d81

Browse files
twhughestylerflex
authored andcommitted
refactored data into collections and data
1 parent 3353070 commit ef41d81

File tree

23 files changed

+496
-913
lines changed

23 files changed

+496
-913
lines changed

README.md

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -155,10 +155,10 @@ https://www.atlassian.com/git/tutorials/merging-vs-rebasing
155155
- [x] Test with simple run.
156156
- [x] Fix issue with converting to complex.
157157
- [x] **Refactor some webapi internals.**
158-
- [ ] **Add conversions for rest of objects.**
158+
- [x] **Add conversions for rest of objects.**
159159
- [x] **Containers (job batch).**
160160
- [x] **Better handling for runtime status using rich.**
161-
- [ ] **Add example notebooks and make consistent.**
161+
- [x] **Add example notebooks and make consistent.**
162162
- [x] **Comments / documentations**
163163
- [ ] Get webAPI working without conversion.
164164
- [ ] Use native `Simulation.export()` or `Simulation.json()` for `upload()`.
@@ -185,14 +185,13 @@ https://www.atlassian.com/git/tutorials/merging-vs-rebasing
185185
- [x] Combine fields components (Ex, Ey, Ez, ...)
186186
- [x] Put permittivity monitor into freq-domain field data.
187187
- [x] Get rid of pydantic? <- Not doing it
188-
- [ ] Simplify MonitorData
189-
- [ ] remove MonitorData.monitor and MonitorData.monitor_name attributes.
190-
- [ ] remove MonitorData.load() and MonitorData.export()
191-
- [ ] assert all SimulationData.monitor_data.keys() are in SimulationData.simulation.monitor.keys()
192-
- [ ] provide optional args to SimulationData.export() to only export some MonitorData by key
188+
- [x] Simplify MonitorData
189+
- [x] remove MonitorData.monitor and MonitorData.monitor_name attributes.
190+
- [x] remove MonitorData.load() and MonitorData.export()
191+
- [ ] assert all SimulationData.monitor_data.keys() are in SimulationData.simulation.monitor.keys() <- not necessry.
192+
- [ ] provide optional args to SimulationData.export() to only export some MonitorData by key <- not necessary?
193193
- [ ] Move any interfaces in MonitorData to SimulationData (geometry, plotting, etc).
194-
- [ ] Remove unneeded data or monitor maps.
195-
- [ ] Make monitordata.load_from_data aware of lists
194+
- [x] Make monitordata.load_from_group aware of lists
196195
- [x] Use shapely for geometry ops / plotting? `Geometry.geo(x=0)` -> shapely representation.
197196
- [x] Fix all tests.
198197
- [x] Integrate shapely plotting / kwargs.

notebooks/ModeSolver.ipynb

Lines changed: 10 additions & 172 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)