mode sources and monitors work with conversion

Author: twhughes

README.md

@@ -188,9 +188,6 @@ https://www.atlassian.com/git/tutorials/merging-vs-rebasing
 - [x] Simplify MonitorData
     - [x] remove MonitorData.monitor  and MonitorData.monitor_name attributes.
     - [x] remove MonitorData.load() and MonitorData.export()
-    - [ ] assert all SimulationData.monitor_data.keys() are in SimulationData.simulation.monitor.keys() <- not necessry.
-    - [ ] provide optional args to SimulationData.export() to only export some MonitorData by key <- not necessary?
-    - [ ] Move any interfaces in MonitorData to SimulationData (geometry, plotting, etc).
     - [x] Make monitordata.load_from_group aware of lists
 - [x] Use shapely for geometry ops / plotting?  `Geometry.geo(x=0)` -> shapely representation.
 	- [x] Fix all tests.
@@ -208,12 +205,13 @@ https://www.atlassian.com/git/tutorials/merging-vs-rebasing
 - [ ] Handle Inf as it's own keyword that depends on simulation bounds.
 - [ ] Make Uniform Samplers separate classes? (dont evaluate / store freqs, times)?
 - [ ] setup.cfg for installing packages with more granularity (base, docs, tests)
+- [ ] Move any interfaces in MonitorData to SimulationData (geometry, plotting, etc).
 
 
 #### Requires some focused time
 - [ ] Nail down simulationData interfaces for plotting.
 - [ ] Figue out webAPI running progress issues. (can we get separate status for time-stepping?)
-- [ ] **Conversion for mode monitors / mode sources.**
+- [x] Conversion for mode monitors / mode sources.
 - [ ] Get near2far working correctly.
 - [ ] Use mode solver for the relevant example notebooks.
 - [ ] Document everything fully.

notebooks/Modal_sources_monitors.ipynb

@@ -167,9 +167,9 @@ def load_from_group(cls, hdf5_grp):
             kwargs[data_name] = np.array(data_value)
 
         # handle data stored as np.array() of bytes instead of strings
-        # for str_kwarg in ("field", "direction"):
-        #     if kwargs.get(str_kwarg) is not None:
-        #         kwargs[str_kwarg] = decode_bytes_array(kwargs[str_kwarg])
+        for str_kwarg in ("direction",):
+            if kwargs.get(str_kwarg) is not None:
+                kwargs[str_kwarg] = decode_bytes_array(kwargs[str_kwarg])
 
         # handle data stored as np.array() of bytes instead of strings
         # for str_kwarg in ("x", "y", "z"):

notebooks/data/mode_converter.hdf5

@@ -6,7 +6,6 @@
 
 from .base import Tidy3dBaseModel
 from .types import Symmetry
-from ..log import log
 
 
 class Mode(Tidy3dBaseModel):

notebooks/data/simulation.hdf5

@@ -253,7 +253,10 @@ def download(task_id: TaskId, simulation: Simulation, path: str = "simulation_da
 
 
 def load_data(
-    task_id: TaskId, simulation: Simulation, path: str = "simulation_data.hdf5"
+    task_id: TaskId,
+    simulation: Simulation,
+    path: str = "simulation_data.hdf5",
+    replace_existing=True,
 ) -> SimulationData:
     """Download and Load simultion results into ``SimulationData`` object.
 
@@ -263,13 +266,15 @@ def load_data(
         Unique identifier of task on server.
     path : ``str``
         Download path to .hdf5 data file (including filename).
+    replace_existing: ``bool``
+        Downloads even if file exists (overwriting).
 
     Returns
     -------
     :class:`SimulationData`
         Object containing simulation data.
     """
-    if not os.path.exists(path):
+    if not os.path.exists(path) or replace_existing:
         download(task_id=task_id, simulation=simulation, path=path)
 
     log.info(f"loading SimulationData from {path}")