Skip to content

Commit 4b82eae

Browse files
twhughestylerflex
authored andcommitted
webapi is cleaned up a bit, need to do containers
1 parent 9269a07 commit 4b82eae

File tree

9 files changed

+824
-217
lines changed

9 files changed

+824
-217
lines changed

.pylintrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ max-line-length=100
1010

1111
[pre-commit-hook]
1212
command=custom_pylint
13-
disable=pointless-string-statement, too-many-ancestors, too-few-public-methods, fixme
13+
disable=pointless-string-statement, too-many-ancestors, too-few-public-methods, fixme, logging-not-lazy

README.md

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -150,14 +150,19 @@ https://www.atlassian.com/git/tutorials/merging-vs-rebasing
150150

151151
#### Web Integration (requires solver integration)
152152
- [ ] Get webAPI working with conversion
153-
- [ ] refactor webapi internals.
154-
- [ ] add http / authentication etc.
155-
- [ ] hook webapi to conversion.
156-
- [ ] Test with simple run.
157-
- [ ] Add some example notebooks using supported sources / monitors.
158-
- [ ] Include Nice web api plotting / progressbars using `rich`.
153+
- [x] add http / authentication etc.
154+
- [x] hook webapi to conversion.
155+
- [x] Test with simple run.
156+
- [x] Fix issue with converting to complex.
157+
- [ ] **Refactor some webapi internals.**
158+
- [ ] **Add conversions for rest of objects.**
159+
- [ ] **Containers (job batch).**
160+
- [ ] Rich progressbars.
161+
- [ ] **Add example notebooks and make consistent.**
162+
- [ ] **Comments / documentations**
159163
- [ ] Get webAPI working without conversion.
160-
- [ ] Use native `Simulation.export()` or `Simulation.json()` for ``upload()`.
164+
- [ ] Use native `Simulation.export()` or `Simulation.json()` for `upload()`.
165+
- [ ] Put the tidy3d log inside SimulationData on postprocess.
161166
- [ ] Use native `SimulationData.load()` for `load()`.
162167
- [ ] Test test test and then test more.
163168
---
@@ -290,6 +295,7 @@ https://github.com/crusaderky/python_project_template
290295
---
291296

292297
### Extensions
298+
- [ ] Store server-side log metadata inside SimulationData (credits billed etc)
293299
- [ ] Geometry
294300
- [ ] Erosion / Dilation of polyslabs
295301
- [ ] Vectorize / automatic `inside` based on `intersections`

explore/Progressbar.ipynb

Lines changed: 204 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)