Skip to content

Commit fa2ff04

Browse files
authored
Merge pull request #62 from flexanalytics/fix/model_rowcount_none
Handle potential `None` in rowcounts
2 parents 4f8fa6a + 41aff40 commit fa2ff04

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

macros/upload_models.sql

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@
5050
{%- endset -%}
5151
{% endif %}
5252
{%- set results = run_query(rowcount_query) -%}
53-
{%- set model_rowcount = results.columns[0].values()[0] -%}
53+
{%- set raw_value = results.columns[0].values() | first -%}
54+
{%- set model_rowcount = 0 if raw_value is none else raw_value -%}
5455
{% else %}
5556
{%- set model_rowcount = 0 -%}
5657
{% endif %}
@@ -70,7 +71,7 @@
7071
'{{ tojson(model.tags) }}', {# tags #}
7172
'{{ tojson(model.config.meta) }}', {# meta #}
7273
'{{ null if model.description is not defined else adapter.dispatch('escape_singlequote', 'dbt_observability')(model.description) }}', {# description #}
73-
{{ 0 if model_rowcount is not defined else model_rowcount }} {# total rowcount #}
74+
{{ model_rowcount }}
7475
)
7576
{%- if not loop.last %},{%- endif %}
7677
{%- endfor %}
@@ -93,7 +94,8 @@
9394
select count(*) as model_rowcount from {{ model.schema }}.{{ model.name }}
9495
{%- endset -%}
9596
{%- set results = run_query(rowcount_query) -%}
96-
{%- set model_rowcount = results.columns[0].values()[0] -%}
97+
{%- set raw_value = results.columns[0].values() | first -%}
98+
{%- set model_rowcount = 0 if raw_value is none else raw_value -%}
9799
{% else %}
98100
{%- set model_rowcount = 0 -%}
99101
{% endif %}
@@ -113,7 +115,7 @@
113115
{{ tojson(model.tags) }}, {# tags #}
114116
parse_json('{{ tojson(model.config.meta) }}'), {# meta #}
115117
'{{ null if model.description is not defined else adapter.dispatch('escape_singlequote', 'dbt_observability')(model.description) }}', {# description #}
116-
{{ 0 if model_rowcount is not defined else model_rowcount }} {# total rowcount #}
118+
{{ model_rowcount }} {# total rowcount #}
117119
)
118120
{%- if not loop.last %},{%- endif %}
119121
{%- endfor %}

macros/upload_sources.sql

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@
5353
{%- endset -%}
5454
{% endif %}
5555
{%- set results = run_query(rowcount_query) -%}
56-
{%- set source_rowcount = results.columns[0].values()[0] -%}
56+
{%- set raw_value = results.columns[0].values() | first -%}
57+
{%- set source_rowcount = 0 if raw_value is none else raw_value -%}
5758

5859
{% else %}
5960

@@ -101,7 +102,8 @@
101102
and lower(table_schema) = lower('{{ source.schema }}')
102103
{%- endset -%}
103104
{%- set results = run_query(rowcount_query) -%}
104-
{%- set source_rowcount = results.columns[0].values()[0] -%}
105+
{%- set raw_value = results.columns[0].values() | first -%}
106+
{%- set source_rowcount = 0 if raw_value is none else raw_value -%}
105107
{% else %}
106108
{%- set source_rowcount = 0 -%}
107109
{% endif %}
@@ -117,7 +119,7 @@
117119
'{{ source.identifier }}', {# identifier #}
118120
'{{ adapter.dispatch('escape_singlequote', 'dbt_observability')(source.loaded_at_field) }}', {# loaded_at_field #}
119121
parse_json('{{ tojson(source.freshness) }}'), {# freshness #}
120-
{{ 0 if source_rowcount is not defined else source_rowcount }} {# source_rowcount #}
122+
{{ source_rowcount }} {# source_rowcount #}
121123
)
122124
{%- if not loop.last %},{%- endif %}
123125
{%- endfor %}

0 commit comments

Comments
 (0)