Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helm chart to support vulnerability processing #25832

Open
2 of 19 tasks
noahtalerman opened this issue Jan 28, 2025 · 2 comments
Open
2 of 19 tasks

Update Helm chart to support vulnerability processing #25832

noahtalerman opened this issue Jan 28, 2025 · 2 comments
Assignees
Labels
#g-customer-success Customer success issue. prospect-interkosmos story A user story defining an entire feature

Comments

@noahtalerman
Copy link
Member

noahtalerman commented Jan 28, 2025

Goal

User story
As a Fleet user that deploys Fleet using Fleet's default Helm chart,
I want Fleet's Helm chart, like AWS Terraform, to support vulnerability processing
so that I don't have to update Fleet's default Helm chart myself.

Key result

None.

Original requests

Context

Changes

Product

  • Fleet's Helm chart changes: draft PR is here: Helm Chart: Move vulnerability processing to be a cronjob by default #25488
    • Follow up in PR with the these proposed changes:
      • External vulnerability scanning is off by default
      • 4GB memory by default
      • Why? This way Helm is consistent with AWS Terraform
  • UI changes: No changes.
  • CLI (fleetctl) usage changes: No changes.
  • YAML changes: No changes.
  • REST API changes: No changes.
  • Fleet's agent (fleetd) changes: No changes.
  • Activity changes: No changes.
  • Permissions changes: No changes.
  • Changes to paid features or tiers: No changes.
  • Transparency changes: No changes.
  • First draft of test plan added
  • Other reference documentation changes: No changes.
  • Once shipped, requester has been notified
  • Once shipped, dogfooding issue has been filed
    • @noahtalerman: No dogfooding for this Helm chart change. Fleet uses AWS Terraform to deploy Fleet.

Engineering

  • Test plan is finalized
  • Feature guide changes: No changes.
  • Database schema migrations: No changes.
  • Load testing: No changes.

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

No QA/testing for this Helm chart change.

@pboushy
Copy link
Contributor

pboushy commented Jan 31, 2025

Follow up in PR with the these proposed changes:

  • External vulnerability scanning is off by default
  • 4GB memory by default
  • Why? This way Helm is consistent with AWS Terraform

Do y'all want me to make these 2 changes? (Was waiting to see comments on the PR to confirm that was the request)

@rfairburn
Copy link
Contributor

@pboushy I had planned on commenting directly on the ticket this evening. With those changes, I believe we are in a place that we could approve this and get it pushed through.

Thanks for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#g-customer-success Customer success issue. prospect-interkosmos story A user story defining an entire feature
Development

No branches or pull requests

3 participants