Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMTP setup: tell user about test email #25547

Open
14 of 19 tasks
noahtalerman opened this issue Jan 17, 2025 · 1 comment
Open
14 of 19 tasks

SMTP setup: tell user about test email #25547

noahtalerman opened this issue Jan 17, 2025 · 1 comment
Assignees
Labels
#g-orchestration Orchestration product group :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature

Comments

@noahtalerman
Copy link
Member

noahtalerman commented Jan 17, 2025

Goal

User story
As an admin configuring SMTP,
I want to see a message explaining that saving changes sends a test email
so that I can check my inbox to make sure SMTP is properly configured.

Key result

Original requests

Context

Changes

Product

  • UI changes: Figma
  • CLI (fleetctl) usage changes: No changes
  • YAML changes: No changes
  • REST API changes: No changes
  • Fleet's agent (fleetd) changes: No changes
  • Activity changes: No changes
  • Permissions changes: No changes
  • Changes to paid features or tiers: No changes
  • Transparency changes: No changes
  • First draft of test plan added
  • Other reference documentation changes: No changes
  • Once shipped, requester has been notified
  • Once shipped, dogfooding issue has been filed

Engineering

  • Test plan is finalized @xpkoala
  • Feature guide changes: no need
  • Database schema migrations: no need
  • Load testing: no need

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

  • Requires load testing: no need
  • Risk level: Low
  • Risk description: very low. tooltip change.

Test plan

  1. Go to /settings/organization/smtp and hover over Save button.
    • Should see tooltip explaining that a test email will be sent.
  2. Enable GitOps mode and go to /settings/organization/smtp and hover over disabled Save button.
    • Should see GitOps mode tooltip instead of test email tooltip.
  3. Go to /settings/organization/smtp with FLEET_EMAIL_BACKEND=ses
    • Message displayed instead of the form should now have a border around it.
    • Resize the screen to smallest supported screen size and make sure there are no style issues.

Testing notes

Confirmation

  1. Engineer: Added comment to user story confirming successful completion of test plan.
  2. QA: Added comment to user story confirming successful completion of test plan.
@noahtalerman noahtalerman added #g-orchestration Orchestration product group :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature Epic DO NOT USE. Auto-created by ZenHub, cannot be disabled. and removed Epic DO NOT USE. Auto-created by ZenHub, cannot be disabled. labels Jan 17, 2025
@noahtalerman noahtalerman added ~feature fest Will be reviewed at next Feature Fest and removed ~feature fest Will be reviewed at next Feature Fest labels Feb 6, 2025
@rachaelshaw rachaelshaw assigned sharon-fdm and unassigned rachaelshaw Mar 4, 2025
@noahtalerman
Copy link
Member Author

noahtalerman commented Mar 5, 2025

Hey @sharon-fdm just a reminder that this user story and another user story here are ready to spec.

Can you please complete the "TO-DOs" in the Engineering section so we can estimate these today?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#g-orchestration Orchestration product group :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature
Projects
None yet
Development

No branches or pull requests

3 participants