From ecf075cd1379dd7e2731d99a5e409344e4ce5374 Mon Sep 17 00:00:00 2001 From: Vladimir Date: Thu, 20 Aug 2026 13:28:29 +0800 Subject: [PATCH] Tell public patches that Ubuntu CI does not run test:docs. Why: PR 11 added npm run test:docs and listed it with the other public Node suites. CONTRIBUTING still said those same suites run on Ubuntu CI and in npm test. The PR template also omitted test:docs. Changed: CONTRIBUTING now lists the Ubuntu CI Node suites and says that job skips test:app and test:docs. The PR template checklist includes test:docs. Front-door tests pin both. Verification: npm run agent:verify -- --profile spec-only --paths CONTRIBUTING.md,.github/pull_request_template.md,docs/test/front-door.test.mjs --session-dir task-sessions/test-docs-followup-20260820 Affected: CONTRIBUTING.md .github/pull_request_template.md docs/test/front-door.test.mjs Refs: https://github.com/fiveonecode/simulator-broker/pull/11 https://github.com/fiveonecode/simulator-broker/issues/8 Session: task-sessions/test-docs-followup-20260820 --- .github/pull_request_template.md | 2 +- CONTRIBUTING.md | 5 +++-- docs/test/front-door.test.mjs | 6 ++++++ 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index a071079..c79a764 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -7,7 +7,7 @@ A public patch uses Node.js 20 and the Node suites that match the change. You do not need the agent harness or a task session directory. -- [ ] `npm run test:broker-core` / `npm run test:client` / `npm run test:harness-adoption` as applicable, or I explained why a deterministic test is not available +- [ ] `npm run test:broker-core` / `npm run test:client` / `npm run test:harness-adoption` / `npm run test:docs` as applicable, or I explained why a deterministic test is not available - [ ] I did not commit private paths, credentials, generated Xcode projects, local broker state, or task-session artifacts ## Notes diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 987f944..20b2c08 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -38,8 +38,9 @@ npm run test:harness-adoption Run `npm run test:docs` for doc, README, or template changes; it runs the `docs/test` front-door checks. App work also needs XcodeGen and `npm run test:app`. The full suite is -`npm test`. The same Node suites run on GitHub-hosted Ubuntu CI. That job -does not run `npm run test:app`. +`npm test`. GitHub-hosted Ubuntu CI runs public-surface, `test:broker-core`, +`test:client`, and `test:harness-adoption`. That job does not run +`npm run test:app` or `npm run test:docs`. You do not need to run `agent:context`, `agent:verify`, or `agent:complete`, and you do not need to create a task session directory. diff --git a/docs/test/front-door.test.mjs b/docs/test/front-door.test.mjs index 09b78ed..59bd592 100644 --- a/docs/test/front-door.test.mjs +++ b/docs/test/front-door.test.mjs @@ -138,6 +138,11 @@ test("CONTRIBUTING leads with a public Node-20 patch track that does not require || human.includes("npm test"), "public track must name a Node test command that is not agent:*", ); + assert.ok(human.includes("npm run test:docs"), "public track must name test:docs"); + assert.ok( + human.includes("does not run") && human.includes("npm run test:docs"), + "public track must not claim Ubuntu CI runs test:docs", + ); assert.equal(human.includes("You do not need to run `agent:context`"), true); assert.equal(human.includes("$HOME/.codex"), false); assert.equal(human.includes("npm run agent:context --"), false); @@ -277,6 +282,7 @@ test("PR template is a public-patch checklist and does not require the harness", assert.ok(template.includes("npm run test:broker-core")); assert.ok(template.includes("npm run test:client")); assert.ok(template.includes("npm run test:harness-adoption")); + assert.ok(template.includes("npm run test:docs")); assert.ok(template.includes("Alpha")); assert.ok(template.includes("macOS")); assert.ok(template.includes("Xcode"));