Skip to content

Commit 73fe828

Browse files
roypatShadowCurse
authored andcommitted
chore: apply updated mdformat styles
It seemingly finally got intelligent enough to realize we don't need all these backslashes on the brackets. Signed-off-by: Patrick Roy <[email protected]>
1 parent f735be3 commit 73fe828

12 files changed

+112
-122
lines changed

CHANGELOG.md

+50-51
Large diffs are not rendered by default.

FAQ.md

+4-5
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,10 @@ minimal required device model to the guest operating system while excluding
6060
non-essential functionality (only 6 emulated devices are available: virtio-net,
6161
virtio-balloon, virtio-block, virtio-vsock, serial console, and a minimal
6262
keyboard controller used only to stop the microVM). This, along with a
63-
streamlined kernel loading process enables a \< 125 ms startup time and a \< 5
64-
MiB memory footprint. The Firecracker process also provides a RESTful control
65-
API, handles resource rate limiting for microVMs, and provides a microVM
66-
metadata service to enable the sharing of configuration data between the host
67-
and guest.
63+
streamlined kernel loading process enables a < 125 ms startup time and a < 5 MiB
64+
memory footprint. The Firecracker process also provides a RESTful control API,
65+
handles resource rate limiting for microVMs, and provides a microVM metadata
66+
service to enable the sharing of configuration data between the host and guest.
6867

6968
### What operating systems are supported by Firecracker?
7069

README.md

+9-9
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ The **API endpoint** can be used to:
116116
- Add a [entropy device](docs/entropy.md) to the microVM.
117117
- Start the microVM using a given kernel image, root file system, and boot
118118
arguments.
119-
- \[x86_64 only\] Stop the microVM.
119+
- [x86_64 only] Stop the microVM.
120120

121121
**Built-in Capabilities**:
122122

@@ -130,14 +130,14 @@ The **API endpoint** can be used to:
130130

131131
We test all combinations of:
132132

133-
| Instance | Host OS & Kernel | Guest Rootfs | Guest Kernel |
134-
| :-------- | :---------------- | :----------- | :----------- |
135-
| c5n.metal | al2 linux_5.10 | ubuntu 24.04 | linux_5.10 |
136-
| m5n.metal | al2023 linux_6.1 | | linux_6.1 |
137-
| m6i.metal | | | |
138-
| m6a.metal | | | |
139-
| m6g.metal | | | |
140-
| m7g.metal | | | |
133+
| Instance | Host OS & Kernel | Guest Rootfs | Guest Kernel |
134+
| :-------- | :--------------- | :----------- | :----------- |
135+
| c5n.metal | al2 linux_5.10 | ubuntu 24.04 | linux_5.10 |
136+
| m5n.metal | al2023 linux_6.1 | | linux_6.1 |
137+
| m6i.metal | | | |
138+
| m6a.metal | | | |
139+
| m6g.metal | | | |
140+
| m7g.metal | | | |
141141

142142
## Known issues and Limitations
143143

docs/api_requests/actions.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ curl --unix-socket /tmp/firecracker.socket -i \
3131
-d '{ "action_type": "FlushMetrics" }'
3232
```
3333

34-
## \[Intel and AMD only\] SendCtrlAltDel
34+
## [Intel and AMD only] SendCtrlAltDel
3535

3636
This action will send the CTRL+ALT+DEL key sequence to the microVM. By
3737
convention, this sequence has been used to trigger a soft reboot and, as such,

docs/api_requests/block-io-engine.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ system calls.
66

77
Firecracker 1.0.0 adds support for an asynchronous block device IO engine.
88

9-
> \[!WARNING\]
9+
> [!WARNING]
1010
>
1111
> Support is currently in **developer preview**. See
1212
> [this section](#developer-preview-status) for more info.

docs/api_requests/block-vhost-user.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Vhost-user block device
22

3-
> \[!WARNING\]
3+
> [!WARNING]
44
>
55
> Support is currently in **developer preview**. See
66
> [this section](../RELEASE_POLICY.md#developer-preview-features) for more info.

docs/formal-verification.md

+22-27
Original file line numberDiff line numberDiff line change
@@ -143,45 +143,40 @@ Verification Time: 0.19135727s
143143
## FAQ
144144

145145
**Q:** What is the Kani verifier?\
146-
**A:** The
147-
[Kani Rust Verifier](https://github.com/model-checking/kani) is a bit-precise
148-
model checker for Rust. Kani is particularly useful for verifying unsafe code
149-
blocks in Rust, where the
146+
**A:** The [Kani Rust Verifier](https://github.com/model-checking/kani) is a
147+
bit-precise model checker for Rust. Kani is particularly useful for verifying
148+
unsafe code blocks in Rust, where the
150149
[unsafe superpowers](https://doc.rust-lang.org/stable/book/ch19-01-unsafe-rust.html#unsafe-superpowers)"
151150
are unchecked by the compiler.
152151

153152
**Q:** What safety properties does Kani verify?\
154-
**A:** Kani verifies memory
155-
safety properties (e.g., invalid-pointer dereferences, out-of-bounds array
156-
access), user-specified assertions (i.e., `assert!(...)`), the absence of
157-
`panic!()`s (e.g., `unwrap()` on `None` values), and the absence of some types
158-
of unexpected behavior (e.g., arithmetic overflows). For a full overview, see
159-
the
153+
**A:** Kani verifies memory safety properties (e.g., invalid-pointer
154+
dereferences, out-of-bounds array access), user-specified assertions (i.e.,
155+
`assert!(...)`), the absence of `panic!()`s (e.g., `unwrap()` on `None` values),
156+
and the absence of some types of unexpected behavior (e.g., arithmetic
157+
overflows). For a full overview, see the
160158
[Kani documentation](https://model-checking.github.io/kani/tutorial-kinds-of-failure.html).
161159

162160
**Q:** Do we expect all contributors to write harnesses for newly introduced
163161
code?\
164-
**A:** No. Kani is complementary to unit testing, and we do not have
165-
target for “proof coverage”. We employ formal verification in especially
166-
critical code areas. Generally we do not expect someone who might not be
167-
familiar with formal tools to contribute harnesses. We do expect all contributed
168-
code to pass verification though, just like we expect it to pass unit test!
162+
**A:** No. Kani is complementary to unit testing, and we do not have target for
163+
“proof coverage”. We employ formal verification in especially critical code
164+
areas. Generally we do not expect someone who might not be familiar with formal
165+
tools to contribute harnesses. We do expect all contributed code to pass
166+
verification though, just like we expect it to pass unit test!
169167

170168
**Q:** How should I report issues related to any Firecracker harnesses?\
171-
**A:**
172-
Our Kani harnesses verify safety critical invariants. If you discover a flaw in
173-
a harness, please report it using the
169+
**A:** Our Kani harnesses verify safety critical invariants. If you discover a
170+
flaw in a harness, please report it using the
174171
[security issue disclosure process](https://github.com/firecracker-microvm/firecracker/blob/main/SECURITY.md).
175172

176-
**Q:** How do I know which properties I should prove in the Kani
177-
harness?\
178-
**A:** Generally, these are given by some sort of specification. This
179-
can either be the function contract described in its document (e.g. what
180-
relation between input and output do callers expect?), or even something formal
181-
such as the TCP/IP standard. Don't forget to mention the specification in your
182-
proof harness!
173+
**Q:** How do I know which properties I should prove in the Kani harness?\
174+
**A:** Generally, these are given by some sort of specification. This can either
175+
be the function contract described in its document (e.g. what relation between
176+
input and output do callers expect?), or even something formal such as the
177+
TCP/IP standard. Don't forget to mention the specification in your proof
178+
harness!
183179

184180
**Q:** Where do I debug a broken proof?\
185-
**A:** Check out the Kani book section
186-
on
181+
**A:** Check out the Kani book section on
187182
[debugging verification failures](https://model-checking.github.io/kani/debugging-verification-failures.html).

docs/hugepages.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Backing Guest Memory by Huge Pages
22

3-
> \[!WARNING\]
3+
> [!WARNING]
44
>
55
> Support is currently in **developer preview**. See
66
> [this section](RELEASE_POLICY.md#developer-preview-features) for more info.

docs/prod-host-setup.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -254,18 +254,18 @@ echo "swap partitions present (Recommendation: no swap)" \
254254

255255
### Mitigating hardware vulnerabilities
256256

257-
> \[!CAUTION\]
257+
> [!CAUTION]
258258
>
259259
> Firecracker is not able to mitigate host's hardware vulnerabilities. Adequate
260260
> mitigations need to be put in place when configuring the host.
261261
262-
> \[!CAUTION\]
262+
> [!CAUTION]
263263
>
264264
> Firecracker is designed to provide isolation boundaries between microVMs
265265
> running in different Firecracker processes. It is strongly recommended that
266266
> each Firecracker process corresponds to a workload of a single tenant.
267267
268-
> \[!CAUTION\]
268+
> [!CAUTION]
269269
>
270270
> For security and stability reasons it is highly recommended to load updated
271271
> microcode as soon as possible. Aside from keeping the system firmware
@@ -328,7 +328,7 @@ For vendor-specific recommendations, please consult the resources below:
328328
- ARM:
329329
[Speculative Processor Vulnerability](https://developer.arm.com/support/arm-security-updates/speculative-processor-vulnerability)
330330

331-
##### \[ARM only\] Physical counter directly passed through to the guest
331+
##### [ARM only] Physical counter directly passed through to the guest
332332

333333
On ARM, the physical counter (i.e `CNTPCT`) it is returning the
334334
[actual EL1 physical counter value of the host][1]. From the discussions before

docs/snapshotting/network-for-clones.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
This document presents a strategy to ensure continued network connectivity for
44
multiple clones created from a single Firecracker microVM snapshot.
55

6-
> \[!CAUTION\]
6+
> [!CAUTION]
77
>
88
> This should be considered as just an example to get you started, and we don't
99
> claim this is a performant or secure setup.

docs/snapshotting/snapshot-support.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ workload at that particular point in time.
3737

3838
### Supported platforms
3939

40-
> \[!WARNING\]
40+
> [!WARNING]
4141
>
4242
> The Firecracker snapshot feature is in
4343
> [developer preview](../RELEASE_POLICY.md) on all CPU micro-architectures

tests/README.md

+17-20
Original file line numberDiff line numberDiff line change
@@ -400,36 +400,33 @@ setting to achieve consistent performance. Please see the `test` section of
400400
401401
`Q1:` *I have a shell script that runs my tests and I don't want to rewrite
402402
it.*\
403-
`A1:` Insofar as it makes sense, you should write it as a python test
404-
function. However, you can always call the script from a shim python test
405-
function. You can also add it as a microvm image resource in the s3 bucket (and
406-
it will be made available under `microvm.slot.path`) or copy it over to a guest
407-
filesystem as part of your test.
403+
`A1:` Insofar as it makes sense, you should write it as a python test function.
404+
However, you can always call the script from a shim python test function. You
405+
can also add it as a microvm image resource in the s3 bucket (and it will be
406+
made available under `microvm.slot.path`) or copy it over to a guest filesystem
407+
as part of your test.
408408
409409
`Q2:` *I want to add more tests that I don't want to commit to the Firecracker
410410
repository.*\
411-
`A2:` Before a testrun or test session, just add your test
412-
directory under `tests/`. `pytest` will discover all tests in this tree.
411+
`A2:` Before a testrun or test session, just add your test directory under
412+
`tests/`. `pytest` will discover all tests in this tree.
413413
414-
`Q3:` *I want to have my own test fixtures, and not commit them in the
415-
repo.*\
416-
`A3:` Add a `conftest.py` file in your test directory, and place your
417-
fixtures there. `pytest` will bring them into scope for all your tests.
414+
`Q3:` *I want to have my own test fixtures, and not commit them in the repo.*\
415+
`A3:` Add a `conftest.py` file in your test directory, and place your fixtures
416+
there. `pytest` will bring them into scope for all your tests.
418417
419418
`Q4:` *I want to use more/other microvm test images, but I don't want to add
420419
them to the common s3 bucket.*\
421-
`A4:` Add your custom images to the `build/img`
422-
subdirectory in the Firecracker source tree. This directory is bind-mounted in
423-
the container and used as a local image cache.
420+
`A4:` Add your custom images to the `build/img` subdirectory in the Firecracker
421+
source tree. This directory is bind-mounted in the container and used as a local
422+
image cache.
424423
425424
`Q5:` *How can I get live logger output from the tests?*\
426-
`A5:` Accessing
427-
**pytest.ini** will allow you to modify logger settings.
425+
`A5:` Accessing **pytest.ini** will allow you to modify logger settings.
428426
429427
`Q6:` *Is there a way to speed up integration tests execution time?*\
430-
`A6:` You
431-
can narrow down the test selection as described in the **Running** section. For
432-
example:
428+
`A6:` You can narrow down the test selection as described in the **Running**
429+
section. For example:
433430
434431
1. Pass the `-k substring` option to pytest to only run a subset of tests by
435432
specifying a part of their name.
@@ -643,6 +640,6 @@ sudo pip3 install pytest ipython requests psutil tenacity filelock "urllib3<2.0"
643640
sudo env PYTHONPATH=tests HOME=$HOME ~/.local/bin/ipython3 -i tools/sandbox.py -- --binary-dir ../repro/v1.4.1
644641
```
645642
646-
> \[!WARNING\]
643+
> [!WARNING]
647644
>
648645
> **Notice this runs as root!**

0 commit comments

Comments
 (0)