Skip to content

Commit f3e5ee4

Browse files
authored
chore(py): use Imported.__name__ for exports rather than string literals (#2437)
1 parent 39b7e51 commit f3e5ee4

File tree

9 files changed

+29
-25
lines changed

9 files changed

+29
-25
lines changed

py/packages/genkit/src/genkit/ai/__init__.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -39,17 +39,17 @@
3939
)
4040

4141
__all__ = [
42-
Genkit.__name__,
43-
GenkitRegistry.__name__,
44-
Plugin.__name__,
45-
Document.__name__,
4642
ActionRunContext.__name__,
43+
Document.__name__,
4744
GenerateRequest.__name__,
4845
GenerateResponse.__name__,
4946
GenerateResponseChunk.__name__,
47+
Genkit.__name__,
48+
GenkitRegistry.__name__,
5049
Media.__name__,
5150
MediaPart.__name__,
5251
Message.__name__,
52+
Plugin.__name__,
5353
RetrieverRequest.__name__,
5454
RetrieverResponse.__name__,
5555
Role.__name__,

py/packages/genkit/src/genkit/ai/plugin.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ def plugin_name(self):
4545
"""
4646
return self.name
4747

48+
# TODO: https://github.com/firebase/genkit/issues/2438
49+
# @abc.abstractmethod
4850
def resolve_action(
4951
self, ai: GenkitRegistry, kind: ActionKind, name: str
5052
) -> None:
@@ -60,11 +62,12 @@ def resolve_action(
6062
"""
6163
pass
6264

65+
@abc.abstractmethod
6366
def initialize(self, ai: GenkitRegistry) -> None:
6467
"""Initialize the plugin with the given registry.
6568
6669
Args:
67-
registry: Registry to register plugin functionality.
70+
ai: Registry to register plugin functionality.
6871
6972
Returns:
7073
None, initialization is done by side-effect on the registry.

py/packages/genkit/src/genkit/ai/registry.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,8 @@ def tool(
136136
137137
Args:
138138
description: Description for the tool to be passed to the model.
139-
name: Optional name for the flow. If not provided, uses the function name.
139+
name: Optional name for the flow. If not provided, uses the function
140+
name.
140141
141142
Returns:
142143
A decorator function that registers the tool.

py/packages/genkit/src/genkit/aio/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@
1818

1919
from .channel import Channel
2020

21-
__all__ = ['Channel']
21+
__all__ = [Channel.__name__]

py/packages/genkit/src/genkit/blocks/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,4 @@ def package_name() -> str:
3838
return 'genkit.ai'
3939

4040

41-
__all__ = ['package_name']
41+
__all__ = [package_name.__name__]

py/packages/genkit/src/genkit/blocks/formats/__init__.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ def package_name() -> str:
3030

3131

3232
__all__ = [
33-
'package_name',
34-
Formatter.__name__,
3533
FormatDef.__name__,
34+
Formatter.__name__,
3635
FormatterConfig.__name__,
3736
JsonFormat.__name__,
37+
package_name.__name__,
3838
]

py/packages/genkit/src/genkit/core/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,4 @@ def package_name() -> str:
3737
return 'genkit.core'
3838

3939

40-
__all__ = ['package_name']
40+
__all__ = [package_name.__name__]

py/packages/genkit/src/genkit/core/endpoints/__init__.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@
1919
from .reflection import create_reflection_asgi_app, make_reflection_server
2020

2121
__all__ = [
22-
'create_reflection_asgi_app',
23-
'make_reflection_server',
22+
create_reflection_asgi_app.__name__,
23+
make_reflection_server.__name__,
2424
]

py/packages/genkit/src/genkit/web/manager/__init__.py

+12-12
Original file line numberDiff line numberDiff line change
@@ -29,16 +29,16 @@
2929
from ._server import Server, ServerConfig, ServerLifecycle
3030

3131
__all__ = [
32-
'ASGIServerAdapter',
33-
'AbstractBaseServer',
34-
'GranianAdapter',
35-
'Server',
36-
'ServerConfig',
37-
'ServerLifecycle',
38-
'ServerType',
39-
'ServerManager',
40-
'UvicornAdapter',
41-
'get_health_info',
42-
'get_server_info',
43-
'run_loop',
32+
ASGIServerAdapter.__name__,
33+
AbstractBaseServer.__name__,
34+
get_health_info.__name__,
35+
get_server_info.__name__,
36+
GranianAdapter.__name__,
37+
run_loop.__name__,
38+
Server.__name__,
39+
ServerConfig.__name__,
40+
ServerLifecycle.__name__,
41+
ServerManager.__name__,
42+
ServerType.__name__,
43+
UvicornAdapter.__name__,
4444
]

0 commit comments

Comments
 (0)