-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SecretParams must only use uppercase letters, numbers and underscores #8301
Comments
Hi @jacob-c-decicco, Thanks for opening this issue! We’ve received it and are reviewing it. We’ll provide updates as soon as possible. |
Since it's firebase-tools that enforces this, I'll transfer this issue there. Note: |
I'll raise this with the team internally. |
I'm also running into this issue. I would like to use secret instead of defineString or the deprecated config settings :) . |
@Seanhjlo are you seeing these rules enforced on the contents of secret params? IIUC, they should only affect the name of the secret param, so you should be able to store a case sensitive key no problem. |
@joehan you are absolutely right, brainfart from my part, I read Key must be upper case, and thought it meant my secret key for some reason 😬 |
In our team we use a lowercase prefix for all of our environment variables, but there is a specific check in the python firebase_functions library that forces all SecretParams to be uppercase. Since the JavaScript firebase functions library and Google Secret manager allow for non-snakecase naming, could this library be updated to match those?
The text was updated successfully, but these errors were encountered: