Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecretParams must only use uppercase letters, numbers and underscores #8301

Open
jacob-c-decicco opened this issue Mar 6, 2025 · 6 comments

Comments

@jacob-c-decicco
Copy link

In our team we use a lowercase prefix for all of our environment variables, but there is a specific check in the python firebase_functions library that forces all SecretParams to be uppercase. Since the JavaScript firebase functions library and Google Secret manager allow for non-snakecase naming, could this library be updated to match those?

@CorieW
Copy link

CorieW commented Mar 7, 2025

Hi @jacob-c-decicco,

Thanks for opening this issue! We’ve received it and are reviewing it. We’ll provide updates as soon as possible.

@CorieW
Copy link

CorieW commented Mar 7, 2025

Since it's firebase-tools that enforces this, I'll transfer this issue there.

Note:
If anything does come from this, firebase-functions-python internally enforces uppercase too (here and here).

@CorieW CorieW transferred this issue from firebase/firebase-functions-python Mar 7, 2025
@CorieW
Copy link

CorieW commented Mar 7, 2025

I'll raise this with the team internally.

@Seanhjlo
Copy link

Seanhjlo commented Apr 3, 2025

I'm also running into this issue. I would like to use secret instead of defineString or the deprecated config settings :) .
To add a bit of context, I'm trying to store Stripe's secret key in this. and unfortunately, stripe's key are case sensitive.

@joehan
Copy link
Contributor

joehan commented Apr 8, 2025

I'm also running into this issue. I would like to use secret instead of defineString or the deprecated config settings :) . To add a bit of context, I'm trying to store Stripe's secret key in this. and unfortunately, stripe's key are case sensitive.

@Seanhjlo are you seeing these rules enforced on the contents of secret params? IIUC, they should only affect the name of the secret param, so you should be able to store a case sensitive key no problem.

@Seanhjlo
Copy link

Seanhjlo commented Apr 8, 2025

@joehan you are absolutely right, brainfart from my part, I read Key must be upper case, and thought it meant my secret key for some reason 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants