Fix typo in FIREBASE_DATA_CONNECT_EMULATOR_HOST and cleaned up error handling

Author: joehan

src/emulator/constants.ts

@@ -77,7 +77,7 @@ export class Constants {
   static FIREBASE_DATABASE_EMULATOR_HOST = "FIREBASE_DATABASE_EMULATOR_HOST";
 
   // Environment variable to discover the Data Connect emulator.
-  static FIREBASE_DATACONNECT_EMULATOR_HOST = "FIREBASE_DATACONNECT_EMULATOR_HOST";
+  static FIREBASE_DATACONNECT_EMULATOR_HOST = "FIREBASE_DATA_CONNECT_EMULATOR_HOST";
 
   // Environment variable to override SDK/CLI to point at the Firebase Auth emulator.
   static FIREBASE_AUTH_EMULATOR_HOST = "FIREBASE_AUTH_EMULATOR_HOST";

src/emulator/dataconnect/pgliteServer.ts

@@ -17,7 +17,7 @@ import {
 } from "./pg-gateway/index";
 import { fromNodeSocket } from "./pg-gateway/platforms/node";
 import { logger } from "../../logger";
-import { hasMessage } from "../../error";
+import { hasMessage, FirebaseError } from "../../error";
 import { StringDecoder } from "node:string_decoder";
 
 export const TRUNCATE_TABLES_SQL = `
@@ -140,7 +140,8 @@ export class PostgresServer {
         const db = await PGlite.create(pgliteArgs);
         return db;
       }
-      throw err;
+      logger.debug(`Error from pglite: ${err}`);
+      throw new FirebaseError("Unexpected error starting up Postgres.");
     }
   }
 

src/emulator/env.ts

@@ -46,6 +46,9 @@ export function setEnvVarsForEmulators(
         break;
       case Emulators.DATACONNECT:
         env[Constants.FIREBASE_DATACONNECT_EMULATOR_HOST] = host;
+        // Originally, there was a typo in this env var name. To avoid breaking folks unecessarily,
+        // we'll keep setting this.
+        env["FIREBASE_DATACONNECT_EMULATOR_HOST"] = host;
     }
   }
 }