Make apphosting:backends:delete prompt users on which backend to delete.

Author: annajowang

src/apphosting/backend.ts

@@ -429,6 +429,52 @@ export async function getBackendForLocation(
   }
 }
 
+/**
+ * Fetches
+ *
+ *
+ */
+export async function chooseBackend(
+  projectId: string,
+  backendId: string,
+  chooseBackendPrompt: string,
+  force?: boolean,
+): Promise<apphosting.Backend> {
+  let { unreachable, backends } = await apphosting.listBackends(projectId, "-");
+  if (unreachable && unreachable.length !== 0) {
+    logWarning(
+      `The following locations are currently unreachable: ${unreachable}.\n` +
+	"If your backend is in one of these regions, please try again later.",
+    );
+  }
+  backends = backends.filter(
+    (backend) => apphosting.parseBackendName(backend.name).id === backendId,
+  );
+  if (backends.length === 0) {
+    throw new FirebaseError(`No backend named "${backendId}" found.`);
+  }
+  if (backends.length === 1) {
+    return backends[0];
+  }
+  if (force) {
+    throw new FirebaseError(
+      `Force cannot be used because multiple backends were found with ID ${backendId}.`
+    );
+  }
+
+  const backendsByName = new Map<string, apphosting.Backend>();
+  backends.forEach((backend) =>
+    backendsByName.set(`${apphosting.parseBackendName(backend.name).id}(${apphosting.parseBackendName(backend.name).location})`, backend),
+  );
+  const chosenBackend = await promptOnce({
+    name: "backend",
+    type: "list",
+    message: chooseBackendPrompt,
+    choices: [...backendsByName.keys()],
+  });
+  return backendsByName.get(chosenBackend)!;
+}
+
 /**
  * Fetches a backend from the server. If there are multiple backends with that name (ie multi-regional backends),
  * prompts the user to disambiguate. If the force option is specified and multiple backends have the same name,

src/commands/apphosting-backends-delete.ts

@@ -10,28 +10,25 @@ import {
   deleteBackendAndPoll,
   getBackendForAmbiguousLocation,
   getBackendForLocation,
+  chooseBackend,
 } from "../apphosting/backend";
 import * as ora from "ora";
 
 export const command = new Command("apphosting:backends:delete <backend>")
   .description("delete a Firebase App Hosting backend")
-  .option("-l, --location <location>", "specify the location of the backend", "-")
   .withForce()
   .before(apphosting.ensureApiEnabled)
   .action(async (backendId: string, options: Options) => {
     const projectId = needProjectId(options);
     let location = options.location as string;
     let backend: apphosting.Backend;
-    if (location === "-" || location === "") {
-      backend = await getBackendForAmbiguousLocation(
-        projectId,
-        backendId,
-        "Please select the location of the backend you'd like to delete:",
-      );
-      location = apphosting.parseBackendName(backend.name).location;
-    } else {
-      backend = await getBackendForLocation(projectId, location, backendId);
-    }
+
+    backend = await chooseBackend(
+      projectId,
+      backendId,
+      "Please select the backend you'd like to delete:",
+      options.force,
+    );
 
     utils.logWarning("You are about to permanently delete this backend:");
     printBackendsTable([backend]);