Remove --location from apphosting:builds:get.

Author: annajowang

src/commands/apphosting-builds-get.ts

@@ -4,19 +4,35 @@ import { Command } from "../command";
 import { Options } from "../options";
 import { needProjectId } from "../projectUtils";
 import { logWarning } from "../utils";
+import { FirebaseError } from "../error";
 
 export const command = new Command("apphosting:builds:get <backendId> <buildId>")
   .description("get a build for an App Hosting backend")
-  .option("-l, --location <location>", "specify the region of the backend")
   .before(apphosting.ensureApiEnabled)
   .action(async (backendId: string, buildId: string, options: Options) => {
-    if (options.location !== undefined) {
-      logWarning("--location is being removed in the next major release.");
-    }
-    options.location = options.location ?? "us-central";
     const projectId = needProjectId(options);
-    const location = options.location as string;
-    const build = await apphosting.getBuild(projectId, location, backendId, buildId);
-    logger.info(JSON.stringify(build, null, 2));
-    return build;
+    const builds = await apphosting.listBuilds(projectId, /* location: */ "-", /* backendId */ "-");
+    const matchingBuilds = builds.builds.filter((b) => {
+      const parsedBuild = apphosting.parseBuildName(b.name);
+      if (parsedBuild.backendId === backendId && parsedBuild.buildId === buildId) {
+        return true;
+      }
+    });
+    if (matchingBuilds.length > 0) {
+      if (matchingBuilds.length > 1) {
+        logWarning(
+          `Detected multiple backends with same backendId (${backendId}) and buildId (${buildId}) within the same global location. ` +
+            "Please delete and recreate any backends that share an ID with another. Use `apphosting:backends:list` to see all backends.",
+        );
+      }
+      logger.info(JSON.stringify(matchingBuilds[0], null, 2));
+      return matchingBuilds[0];
+    }
+    if (builds.unreachable && builds.unreachable.length !== 0) {
+      logWarning(
+        `Backends with the following primary regions are unreachable: ${builds.unreachable}.\n` +
+          "If your backend is in one of these regions, please try again later.",
+      );
+    }
+    throw new FirebaseError(`No build ${buildId} found for any backend ${backendId}.`);
   });

src/gcp/apphosting.ts

@@ -357,6 +357,20 @@ export async function deleteBackend(
   return res.body;
 }
 
+/**
+ * Parse a Build name
+ */
+export function parseBuildName(buildName: string): {
+  projectName: string;
+  location: string;
+  backendId: string;
+  buildId: string;
+} {
+  // sample value: "projects/<project-name>/locations/us-central1/backends/<backend-id>/builds/<build-id>"
+  const [, projectName, , location, , backendId, , buildId] = buildName.split("/");
+  return { projectName, location, backendId, buildId };
+}
+
 /**
  * Get a Build by Id
  */