Addressed comments

Author: maneesht

src/init/features/dataconnect/sdk.spec.ts

@@ -5,7 +5,6 @@ import { expect } from "chai";
 import * as sdk from "./sdk";
 import { DataConnectEmulator } from "../../../emulator/dataconnectEmulator";
 import { Config } from "../../../config";
-import { FIXTURE_DIR } from "../../../test/fixtures/config-imports";
 
 const CONNECTOR_YAML_CONTENTS = "connectorId: blah";
 
@@ -18,10 +17,14 @@ describe("init dataconnect:sdk", () => {
     const sandbox = sinon.createSandbox();
     let generateStub: sinon.SinonStub;
     let fsStub: sinon.SinonStub;
+    let emptyConfig: Config;
+    let askProjectWriteFileStub: sinon.SinonStub;
 
     beforeEach(() => {
       fsStub = sandbox.stub(fs, "writeFileSync");
       generateStub = sandbox.stub(DataConnectEmulator, "generate");
+      emptyConfig = new Config({}, { projectDir: process.cwd() });
+      askProjectWriteFileStub = sandbox.stub(emptyConfig, "askWriteProjectFile");
     });
 
     afterEach(() => {
@@ -44,14 +47,11 @@ describe("init dataconnect:sdk", () => {
       it(c.desc, async () => {
         generateStub.resolves();
         fsStub.returns({});
-        await sdk.actuate(c.sdkInfo, new Config({}, { cwd: FIXTURE_DIR }), true);
+
+        await sdk.actuate(c.sdkInfo, emptyConfig);
         expect(generateStub.called).to.equal(c.shouldGenerate);
-        expect(fsStub.args).to.deep.equal([
-          [
-            `${process.cwd()}/dataconnect/connector/connector.yaml`,
-            CONNECTOR_YAML_CONTENTS,
-            "utf8",
-          ],
+        expect(askProjectWriteFileStub.args).to.deep.equal([
+          ["dataconnect/connector/connector.yaml", CONNECTOR_YAML_CONTENTS],
         ]);
       });
     }

src/init/features/dataconnect/sdk.ts

@@ -1,6 +1,5 @@
 import * as yaml from "yaml";
 import * as clc from "colorette";
-import * as fs from "fs";
 import * as path from "path";
 
 import { dirExistsSync } from "../../../fsutils";
@@ -224,17 +223,13 @@ export async function generateSdkYaml(
   return connectorYaml;
 }
 
-export async function actuate(sdkInfo: SDKInfo, config: Config, skipCheck?: boolean) {
+export async function actuate(sdkInfo: SDKInfo, config: Config) {
   const connectorYamlPath = `${sdkInfo.connectorInfo.directory}/connector.yaml`;
   logBullet(`Writing your new SDK configuration to ${connectorYamlPath}`);
-  if (skipCheck) {
-    fs.writeFileSync(connectorYamlPath, sdkInfo.connectorYamlContents);
-  } else {
-    await config.askWriteProjectFile(
-      path.relative(config.projectDir, connectorYamlPath),
-      sdkInfo.connectorYamlContents,
-    );
-  }
+  await config.askWriteProjectFile(
+    path.relative(config.projectDir, connectorYamlPath),
+    sdkInfo.connectorYamlContents,
+  );
 
   const account = getGlobalDefaultAccount();
   await DataConnectEmulator.generate({