Skip to content

Commit b13f1a1

Browse files
hsubox76hsubox76
committed
changes for rollup
1 parent ae80881 commit b13f1a1

File tree

59 files changed

+147
-164
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+147
-164
lines changed

‎config/api-extractor.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@
100100
*
101101
* DEFAULT VALUE: false
102102
*/
103-
// "skipLibCheck": true,
103+
"skipLibCheck": true,
104104
},
105105

106106
/**

‎packages/analytics-compat/tsconfig.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"compilerOptions": {
44
"outDir": "dist"
55
},
6-
"exclude": [
7-
"dist/**/*"
8-
]
9-
}
6+
"exclude": ["dist/**/*"]
7+
}

‎packages/analytics-interop-types/tsconfig.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"compilerOptions": {
44
"noEmit": true
55
},
6-
"exclude": [
7-
"dist/**/*"
8-
]
6+
"exclude": ["dist/**/*"]
97
}

‎packages/analytics-types/tsconfig.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"compilerOptions": {
44
"noEmit": true
55
},
6-
"exclude": [
7-
"dist/**/*"
8-
]
6+
"exclude": ["dist/**/*"]
97
}

‎packages/analytics/rollup.config.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,18 @@ import typescript from 'typescript';
2222
import { generateBuildTargetReplaceConfig } from '../../scripts/build/rollup_replace_build_target';
2323
import { emitModulePackageFile } from '../../scripts/build/rollup_emit_module_package_file';
2424
import pkg from './package.json';
25+
import tsconfig from './tsconfig.json';
2526

2627
const deps = [
2728
...Object.keys(Object.assign({}, pkg.peerDependencies, pkg.dependencies))
2829
];
2930

3031
const buildPlugins = [
3132
typescriptPlugin({
32-
typescript
33+
typescript,
34+
tsconfigOverride: {
35+
exclude: [...tsconfig.exclude, '**/*.test.ts']
36+
}
3337
}),
3438
json({ preferConst: true })
3539
];

‎packages/app-check-interop-types/tsconfig.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"compilerOptions": {
44
"noEmit": true
55
},
6-
"exclude": [
7-
"dist/**/*"
8-
]
6+
"exclude": ["dist/**/*"]
97
}

‎packages/app-check-types/tsconfig.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"compilerOptions": {
44
"noEmit": true
55
},
6-
"exclude": [
7-
"dist/**/*"
8-
]
6+
"exclude": ["dist/**/*"]
97
}

‎packages/app-types/tsconfig.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"compilerOptions": {
44
"noEmit": true
55
},
6-
"exclude": [
7-
"dist/**/*"
8-
]
6+
"exclude": ["dist/**/*"]
97
}

‎packages/app/rollup.config.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,18 @@ import dts from 'rollup-plugin-dts';
2323
import { generateBuildTargetReplaceConfig } from '../../scripts/build/rollup_replace_build_target';
2424
import { emitModulePackageFile } from '../../scripts/build/rollup_emit_module_package_file';
2525
import pkg from './package.json';
26+
import tsconfig from './tsconfig.json';
2627

2728
const deps = Object.keys(
2829
Object.assign({}, pkg.peerDependencies, pkg.dependencies)
2930
);
3031

3132
const buildPlugins = [
3233
typescriptPlugin({
33-
typescript
34+
typescript,
35+
tsconfigOverride: {
36+
exclude: [...tsconfig.exclude, '**/*.test.ts']
37+
}
3438
}),
3539
json({ preferConst: true })
3640
];

‎packages/app/tsconfig.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,5 @@
44
"outDir": "dist",
55
"downlevelIteration": true
66
},
7-
"exclude": [
8-
"dist/**/*"
9-
]
10-
}
7+
"exclude": ["dist/**/*"]
8+
}

‎packages/auth-compat/tsconfig.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"compilerOptions": {
44
"outDir": "dist"
55
},
6-
"exclude": [
7-
"dist/**/*"
8-
]
9-
}
6+
"exclude": ["dist/**/*"]
7+
}

‎packages/auth-interop-types/tsconfig.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"compilerOptions": {
44
"noEmit": true
55
},
6-
"exclude": [
7-
"dist/**/*"
8-
]
6+
"exclude": ["dist/**/*"]
97
}

‎packages/auth-types/tsconfig.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"compilerOptions": {
44
"noEmit": true
55
},
6-
"exclude": [
7-
"dist/**/*"
8-
]
6+
"exclude": ["dist/**/*"]
97
}

‎packages/auth/rollup.config.js

+6-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import alias from '@rollup/plugin-alias';
2424
import { generateBuildTargetReplaceConfig } from '../../scripts/build/rollup_replace_build_target';
2525
import { emitModulePackageFile } from '../../scripts/build/rollup_emit_module_package_file';
2626
import pkg from './package.json';
27+
import tsconfig from './tsconfig.json';
2728

2829
const deps = Object.keys(
2930
Object.assign({}, pkg.peerDependencies, pkg.dependencies)
@@ -47,7 +48,10 @@ const nodeAliasPlugin = alias({
4748
const buildPlugins = [
4849
json(),
4950
strip({ functions: ['debugAssert.*'] }),
50-
typescriptPlugin({ typescript })
51+
typescriptPlugin({
52+
typescript,
53+
tsconfigOverride: { exclude: [...tsconfig.exclude, '**/*.test.ts'] }
54+
})
5155
];
5256

5357
const browserBuilds = [
@@ -191,6 +195,7 @@ const webWorkerBuild = {
191195
}),
192196
typescriptPlugin({
193197
typescript,
198+
exclude: [...tsconfig.exclude, '**/*.test.*'],
194199
compilerOptions: {
195200
lib: [
196201
// Remove dom after we figure out why navigator stuff doesn't exist

‎packages/auth/tsconfig.json

+2-5
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,5 @@
33
"compilerOptions": {
44
"outDir": "dist"
55
},
6-
"exclude": [
7-
"dist/**/*",
8-
"demo/**/*"
9-
]
10-
}
6+
"exclude": ["dist/**/*", "demo/**/*"]
7+
}

‎packages/component/rollup.config.js

+9-1
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,20 @@ import typescriptPlugin from 'rollup-plugin-typescript2';
1919
import typescript from 'typescript';
2020
import { emitModulePackageFile } from '../../scripts/build/rollup_emit_module_package_file';
2121
import pkg from './package.json';
22+
import tsconfig from './tsconfig.json';
2223

2324
const deps = Object.keys(
2425
Object.assign({}, pkg.peerDependencies, pkg.dependencies)
2526
);
2627

27-
const buildPlugins = [typescriptPlugin({ typescript })];
28+
const buildPlugins = [
29+
typescriptPlugin({
30+
typescript,
31+
tsconfigOverride: {
32+
exclude: [...tsconfig.exclude, '**/*.test.ts']
33+
}
34+
})
35+
];
2836

2937
const esmBuild = {
3038
input: 'index.ts',

‎packages/component/src/provider.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -319,15 +319,15 @@ export class Provider<T extends Name> {
319319
instanceIdentifier: normalizeIdentifierForFactory(instanceIdentifier),
320320
options
321321
});
322-
this.instances.set(instanceIdentifier, instance);
322+
this.instances.set(instanceIdentifier, instance!);
323323
this.instancesOptions.set(instanceIdentifier, options);
324324

325325
/**
326326
* Invoke onInit listeners.
327327
* Note this.component.onInstanceCreated is different, which is used by the component creator,
328328
* while onInit listeners are registered by consumers of the provider.
329329
*/
330-
this.invokeOnInitCallbacks(instance, instanceIdentifier);
330+
this.invokeOnInitCallbacks(instance!, instanceIdentifier);
331331

332332
/**
333333
* Order is important
@@ -339,7 +339,7 @@ export class Provider<T extends Name> {
339339
this.component.onInstanceCreated(
340340
this.container,
341341
instanceIdentifier,
342-
instance
342+
instance!
343343
);
344344
} catch {
345345
// ignore errors in the onInstanceCreatedCallback

‎packages/component/tsconfig.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,5 @@
44
"outDir": "dist",
55
"downlevelIteration": true
66
},
7-
"exclude": [
8-
"dist/**/*"
9-
]
10-
}
7+
"exclude": ["dist/**/*"]
8+
}

‎packages/data-connect/rollup.config.js

+4
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import typescript from 'typescript';
2222
import { generateBuildTargetReplaceConfig } from '../../scripts/build/rollup_replace_build_target';
2323
import { emitModulePackageFile } from '../../scripts/build/rollup_emit_module_package_file';
2424
import pkg from './package.json';
25+
import tsconfig from './tsconfig.json';
2526

2627
const deps = [
2728
...Object.keys({ ...pkg.peerDependencies, ...pkg.dependencies }),
@@ -38,6 +39,9 @@ function onWarn(warning, defaultWarn) {
3839
const buildPlugins = [
3940
typescriptPlugin({
4041
typescript,
42+
tsconfigOverride: {
43+
exclude: [...tsconfig.exclude, '**/*.test.ts']
44+
},
4145
abortOnError: false
4246
}),
4347
json({ preferConst: true })

‎packages/data-connect/tsconfig.json

+1-4
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,5 @@
44
"outDir": "dist",
55
"strict": false
66
},
7-
"exclude": [
8-
"dist/**/*",
9-
"test/**/*"
10-
]
7+
"exclude": ["dist/**/*", "test/**/*"]
118
}

‎packages/database-compat/tsconfig.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,5 @@
55
"strict": false,
66
"downlevelIteration": true
77
},
8-
"exclude": [
9-
"dist/**/*"
10-
]
11-
}
8+
"exclude": ["dist/**/*"]
9+
}

‎packages/database-types/tsconfig.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"compilerOptions": {
44
"noEmit": true
55
},
6-
"exclude": [
7-
"dist/**/*"
8-
]
6+
"exclude": ["dist/**/*"]
97
}

‎packages/database/rollup.config.js

+4
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import typescript from 'typescript';
2222
import { generateBuildTargetReplaceConfig } from '../../scripts/build/rollup_replace_build_target';
2323
import { emitModulePackageFile } from '../../scripts/build/rollup_emit_module_package_file';
2424
import pkg from './package.json';
25+
import tsconfig from './tsconfig.json';
2526

2627
const deps = [
2728
...Object.keys({ ...pkg.peerDependencies, ...pkg.dependencies }),
@@ -38,6 +39,9 @@ function onWarn(warning, defaultWarn) {
3839
const buildPlugins = [
3940
typescriptPlugin({
4041
typescript,
42+
tsconfigOverride: {
43+
exclude: [...tsconfig.exclude, '**/*.test.ts']
44+
},
4145
abortOnError: false
4246
}),
4347
json({ preferConst: true })

‎packages/database/tsconfig.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,5 @@
55
"strict": false,
66
"downlevelIteration": true
77
},
8-
"exclude": [
9-
"dist/**/*"
10-
]
11-
}
8+
"exclude": ["dist/**/*"]
9+
}

‎packages/firebase/tsconfig.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"compilerOptions": {
44
"outDir": "dist"
55
},
6-
"exclude": [
7-
"**/dist/**/*"
8-
]
9-
}
6+
"exclude": ["**/dist/**/*"]
7+
}

‎packages/firestore-types/tsconfig.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"compilerOptions": {
44
"noEmit": true
55
},
6-
"exclude": [
7-
"dist/**/*"
8-
]
6+
"exclude": ["dist/**/*"]
97
}

‎packages/firestore/rollup.config.js

+3
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,15 @@ import typescript from 'typescript';
2828
import { generateBuildTargetReplaceConfig } from '../../scripts/build/rollup_replace_build_target';
2929

3030
import pkg from './package.json';
31+
import tsconfig from './tsconfig.json';
3132

3233
const sourcemaps = require('rollup-plugin-sourcemaps');
3334
const util = require('./rollup.shared');
3435

3536
const nodePlugins = [
3637
typescriptPlugin({
3738
typescript,
39+
exclude: [...tsconfig.exclude, '**/*.test.ts'],
3840
cacheDir: tmp.dirSync(),
3941
abortOnError: true,
4042
transformers: [util.removeAssertTransformer]
@@ -48,6 +50,7 @@ const nodePlugins = [
4850
const browserPlugins = [
4951
typescriptPlugin({
5052
typescript,
53+
exclude: [...tsconfig.exclude, '**/*.test.ts'],
5154
cacheDir: tmp.dirSync(),
5255
abortOnError: true,
5356
transformers: [util.removeAssertAndPrefixInternalTransformer]

‎packages/firestore/rollup.shared.js

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ const typescriptPlugin = require('rollup-plugin-typescript2');
2222
const typescript = require('typescript');
2323
const { terser } = require('@rollup/plugin-terser');
2424
const path = require('path');
25-
const sourcemaps = require('rollup-plugin-sourcemaps');
2625

2726
const { renameInternals } = require('./scripts/rename-internals');
2827
const { extractPublicIdentifiers } = require('./scripts/extract-api');

‎packages/firestore/test/unit/specs/describe_spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -300,8 +300,8 @@ function stringifyGroup(s: string): number {
300300
* some logically-first keys before others.
301301
*/
302302
function stringifyComparator(
303-
a: { key: string, value: unknown },
304-
b: { key: string, value: unknown }
303+
a: { key: string; value: unknown },
304+
b: { key: string; value: unknown }
305305
): number {
306306
const aGroup = stringifyGroup(a.key);
307307
const bGroup = stringifyGroup(b.key);

‎packages/functions-compat/tsconfig.json

+2-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,5 @@
33
"compilerOptions": {
44
"outDir": "dist"
55
},
6-
"exclude": [
7-
"dist/**/*"
8-
]
9-
}
6+
"exclude": ["dist/**/*"]
7+
}

0 commit comments

Comments
 (0)