Update build scripts to work with exports (#5708)

Feiyang1 · web-flow · commit 3281315fae9c · 2021-11-08T09:35:40.000-08:00
* fix standalone build

* add missing entry points to exports

* Create spotty-ducks-buy.md

* add fields back

* use the same name in all places
diff --git a/.changeset/spotty-ducks-buy.md b/.changeset/spotty-ducks-buy.md
@@ -0,0 +1,33 @@
+---
+"@firebase/analytics-compat": patch
+"@firebase/analytics": patch
+"@firebase/app-check-compat": patch
+"@firebase/app-check": patch
+"@firebase/app-compat": patch
+"@firebase/app": patch
+"@firebase/auth-compat": patch
+"@firebase/auth": patch
+"@firebase/component": patch
+"@firebase/database-compat": patch
+"@firebase/database": patch
+"firebase": patch
+"@firebase/firestore-compat": patch
+"@firebase/firestore": patch
+"@firebase/functions-compat": patch
+"@firebase/functions": patch
+"@firebase/installations-compat": patch
+"@firebase/installations": patch
+"@firebase/logger": patch
+"@firebase/messaging-compat": patch
+"@firebase/messaging": patch
+"@firebase/performance-compat": patch
+"@firebase/performance": patch
+"@firebase/remote-config-compat": patch
+"@firebase/remote-config": patch
+"@firebase/storage-compat": patch
+"@firebase/storage": patch
+"@firebase/template": patch
+"@firebase/util": patch
+---
+
+Update build scripts to work with the exports field
diff --git a/packages/analytics-compat/package.json b/packages/analytics-compat/package.json
@@ -10,6 +10,7 @@
   "exports": {
     ".": {
       "require": "./dist/index.cjs.js",
+      "esm5": "./dist/esm/index.esm.js",
       "default": "./dist/esm/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/analytics/package.json b/packages/analytics/package.json
@@ -10,6 +10,7 @@
   "exports": {
     ".": {
       "require": "./dist/index.cjs.js",
+      "esm5": "./dist/esm/index.esm.js",
       "default": "./dist/esm/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/app-check-compat/package.json b/packages/app-check-compat/package.json
@@ -10,6 +10,7 @@
   "exports": {
     ".": {
       "require": "./dist/index.cjs.js",
+      "esm5": "./dist/esm/index.esm.js",
       "default": "./dist/esm/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/app-check/package.json b/packages/app-check/package.json
@@ -10,6 +10,7 @@
   "exports": {
     ".": {
       "require": "./dist/index.cjs.js",
+      "esm5": "./dist/esm/index.esm.js",
       "default": "./dist/esm/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/app-compat/package.json b/packages/app-compat/package.json
@@ -8,10 +8,13 @@
   "module": "dist/esm/index.esm2017.js",
   "esm5": "dist/esm/index.esm5.js",
   "lite": "dist/index.lite.js",
-  "lite-esm5": "dist/index.lite.esm5.js",
+  "liteesm5": "dist/index.lite.esm5.js",
   "exports": {
     ".": {
       "require": "./dist/index.cjs.js",
+      "esm5": "./dist/esm/index.esm5.js",
+      "lite": "./dist/index.lite.js",
+      "liteesm5": "./dist/index.lite.esm5.js",
       "default": "./dist/esm/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/app-compat/rollup.config.js b/packages/app-compat/rollup.config.js
@@ -58,7 +58,7 @@ const esmBuilds = [
   {
     input: 'src/index.lite.ts',
     output: {
-      file: pkg['lite-esm5'],
+      file: pkg['liteesm5'],
       format: 'es',
       sourcemap: true
     },
diff --git a/packages/app/package.json b/packages/app/package.json
@@ -10,6 +10,7 @@
   "exports": {
     ".": {
       "require": "./dist/index.cjs.js",
+      "esm5": "./dist/esm/index.esm5.js",
       "default": "./dist/esm/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/auth-compat/package.json b/packages/auth-compat/package.json
@@ -13,6 +13,7 @@
         "import": "./dist/esm/index.node.esm.js",
         "require": "./dist/index.node.cjs.js"
       },
+      "esm5": "./dist/index.esm.js",
       "default": "./dist/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/auth/package.json b/packages/auth/package.json
@@ -19,6 +19,7 @@
       "react-native": "./dist/rn/index.js",
       "cordova": "./dist/cordova/index.esm5.js",
       "webworker": "./dist/index.webworker.esm5.js",
+      "esm5": "./dist/esm5/index.js",
       "default": "./dist/esm2017/index.js"
     },
     "./internal": {
@@ -28,6 +29,7 @@
       },
       "react-native": "./dist/rn/internal.js",
       "cordova": "./dist/cordova/internal.js",
+      "esm5": "./dist/esm5/internal.js",
       "default": "./dist/esm2017/internal.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/component/package.json b/packages/component/package.json
@@ -10,6 +10,7 @@
   "exports": {
     ".": {
       "require": "./dist/index.cjs.js",
+      "esm5": "./dist/esm/index.esm5.js",
       "default": "./dist/esm/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/database-compat/package.json b/packages/database-compat/package.json
@@ -19,6 +19,7 @@
         "import": "./dist/node-esm/index.js",
         "require": "./dist/index.js"
       },
+      "esm5": "./dist/index.esm5.js",
       "default": "./dist/index.esm2017.js"
     },
     "./standalone": {
diff --git a/packages/database-compat/rollup.config.js b/packages/database-compat/rollup.config.js
@@ -148,7 +148,7 @@ const cjsBuilds = [
     plugins: [
       ...es5BuildPlugins,
       resolveModule({
-        mainFields: ['standalone'],
+        exportConditions: ['standalone'],
         preferBuiltins: true
       }),
       commonjs()
diff --git a/packages/database/package.json b/packages/database/package.json
@@ -14,6 +14,8 @@
         "import": "./dist/node-esm/index.node.esm.js",
         "require": "./dist/index.node.cjs.js"
       },
+      "esm5": "./dist/index.esm5.js",
+      "standalone": "./dist/index.standalone.js",
       "default": "./dist/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/firebase/compat/rollup.config.js b/packages/firebase/compat/rollup.config.js
@@ -243,7 +243,7 @@ const completeBuilds = [
     plugins: [
       sourcemaps(),
       resolveModule({
-        mainFields: ['lite-esm5', 'esm5', 'module']
+        exportConditions: ['liteesm5', 'esm5']
       }),
       typescriptPluginCDN,
       json(),
@@ -265,7 +265,7 @@ const completeBuilds = [
     plugins: [
       sourcemaps(),
       resolveModule({
-        mainFields: ['lite', 'module', 'main']
+        exportConditions: ['lite']
       }),
       rollupTypescriptPlugin({
         typescript,
diff --git a/packages/firestore-compat/package.json b/packages/firestore-compat/package.json
@@ -15,6 +15,7 @@
         "require": "./dist/index.node.cjs.js"
       },
       "react-native": "./dist/index.rn.js",
+      "esm5": "./dist/index.esm5.js",
       "default": "./dist/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/firestore/package.json b/packages/firestore/package.json
@@ -54,6 +54,7 @@
         "import": "./dist/index.node.mjs"
       },
       "react-native": "./dist/index.rn.js",
+      "esm5": "./dist/index.esm5.js",
       "default": "./dist/index.esm2017.js"
     },
     "./lite": {
@@ -62,6 +63,7 @@
         "import": "./dist/lite/index.node.mjs"
       },
       "react-native": "./dist/lite/index.rn.esm2017.js",
+      "esm5": "./dist/lite/index.browser.esm5.js",
       "default": "./dist/lite/index.browser.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/functions-compat/package.json b/packages/functions-compat/package.json
@@ -13,6 +13,7 @@
         "import": "./dist/node-esm/index.node.esm.js",
         "require": "./dist/index.node.cjs.js"
       },
+      "esm5": "./dist/index.esm5.js",
       "default": "./dist/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/functions/package.json b/packages/functions/package.json
@@ -13,6 +13,7 @@
         "import": "./dist/esm-node/index.node.esm.js",
         "require": "./dist/index.node.cjs.js"
       },
+      "esm5": "./dist/index.esm.js",
       "default": "./dist/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/installations-compat/package.json b/packages/installations-compat/package.json
@@ -9,6 +9,7 @@
   "exports": {
     ".": {
       "require": "./dist/index.cjs.js",
+      "esm5": "./dist/esm/index.esm.js",
       "default": "./dist/esm/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/installations/package.json b/packages/installations/package.json
@@ -9,6 +9,7 @@
   "exports": {
     ".": {
       "require": "./dist/index.cjs.js",
+      "esm5": "./dist/esm/index.esm.js",
       "default": "./dist/esm/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/logger/package.json b/packages/logger/package.json
@@ -9,6 +9,7 @@
   "exports": {
     ".": {
       "require": "./dist/index.cjs.js",
+      "esm5": "./dist/esm/index.esm5.js",
       "default": "./dist/esm/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/messaging-compat/package.json b/packages/messaging-compat/package.json
@@ -11,6 +11,7 @@
   "exports": {
     ".": {
       "require": "./dist/index.cjs.js",
+      "esm5": "./dist/esm/index.esm.js",
       "default": "./dist/esm/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/messaging/package.json b/packages/messaging/package.json
@@ -12,6 +12,7 @@
     ".": {
       "browser": "./dist/esm/index.esm2017.js",
       "module": "./dist/esm/index.esm2017.js",
+      "esm5": "./dist/esm/index.esm.js",
       "default": "./dist/index.cjs.js"
     },
     "./sw": "./dist/index.sw.esm2017.js",
diff --git a/packages/performance-compat/package.json b/packages/performance-compat/package.json
@@ -10,6 +10,7 @@
   "exports": {
     ".": {
       "require": "./dist/index.cjs.js",
+      "esm5": "./dist/esm/index.esm5.js",
       "default": "./dist/esm/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/performance/package.json b/packages/performance/package.json
@@ -10,6 +10,7 @@
   "exports": {
     ".": {
       "require": "./dist/index.cjs.js",
+      "esm5": "./dist/esm/index.esm.js",
       "default": "./dist/esm/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/remote-config-compat/package.json b/packages/remote-config-compat/package.json
@@ -10,6 +10,7 @@
   "exports": {
     ".": {
       "require": "./dist/index.cjs.js",
+      "esm5": "./dist/esm/index.esm5.js",
       "default": "./dist/esm/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/remote-config/package.json b/packages/remote-config/package.json
@@ -10,6 +10,7 @@
   "exports": {
     ".": {
       "require": "./dist/index.cjs.js",
+      "esm5": "./dist/esm/index.esm.js",
       "default": "./dist/esm/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/storage-compat/package.json b/packages/storage-compat/package.json
@@ -10,6 +10,7 @@
   "exports": {
     ".": {
       "require": "./dist/index.cjs.js",
+      "esm5": "./dist/esm/index.esm5.js",
       "default": "./dist/esm/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/storage/package.json b/packages/storage/package.json
@@ -12,7 +12,8 @@
       "node": {
         "import": "./dist/node-esm/index.node.esm.js",
         "default": "./dist/index.node.cjs.js"
-      },
+      }, 
+      "esm5": "./dist/index.esm5.js",
       "default": "./dist/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/template/package.json b/packages/template/package.json
@@ -14,6 +14,7 @@
         "import": "./dist/node-esm/index.node.esm.js",
         "require": "./dist/index.node.cjs.js"
       },
+      "esm5": "./dist/index.esm5.js",
       "default": "./dist/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/util/package.json b/packages/util/package.json
@@ -13,6 +13,7 @@
         "import": "./dist/node-esm/index.node.esm.js",
         "require": "./dist/index.node.cjs.js"
       },
+      "esm5": "./dist/index.esm5.js",
       "default": "./dist/index.esm2017.js"
     },
     "./package.json": "./package.json"
diff --git a/packages/webchannel-wrapper/package.json b/packages/webchannel-wrapper/package.json
@@ -9,6 +9,7 @@
   "exports": {
     ".": {
       "require": "./dist/index.js",
+      "esm5": "./dist/index.esm.js",
       "default": "./dist/index.esm2017.js"
     },
     "./package.json": "./package.json"

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ const esmBuilds = [`
`58`	`58`	`{`
`59`	`59`	`input: 'src/index.lite.ts',`
`60`	`60`	`output: {`
`61`		`- file: pkg['lite-esm5'],`
	`61`	`+ file: pkg['liteesm5'],`
`62`	`62`	`format: 'es',`
`63`	`63`	`sourcemap: true`
`64`	`64`	`},`