Skip to content

Commit 178ad99

Browse files
authoredJan 24, 2025
Workflow CI: Update CHROME_VALIDATED_VERSION for Auth tests (#8722)
Update our CI's logged `CHROME_VALIDATED_VERSION` to the currently tested version. We haven't updated it in a while. Keeping this up to date should reduce support burden later.
1 parent 105d248 commit 178ad99

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed
 

‎.github/workflows/test-all.yml

+3-7
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ env:
2323
# the behavior to use the new URLs.
2424
CHROMEDRIVER_CDNURL: https://googlechromelabs.github.io/
2525
CHROMEDRIVER_CDNBINARIESURL: https://storage.googleapis.com/chrome-for-testing-public
26-
CHROME_VALIDATED_VERSION: linux-120.0.6099.71
27-
CHROME_VERSION_MISMATCH_MESSAGE: "The Chrome version doesn't match the previously validated version. Consider updating CHROME_VALIDATED_VERSION in the GitHub workflow if tests pass."
26+
CHROME_VALIDATED_VERSION: linux-132.0.6834.110
27+
CHROME_VERSION_MISMATCH_MESSAGE: "The Chrome version doesn't match the previously validated version. Consider updating CHROME_VALIDATED_VERSION in the GitHub workflow if tests pass, or rollback the installed Chrome version if tests fail."
2828
artifactRetentionDays: 14
2929
# Bump Node memory limit
3030
NODE_OPTIONS: "--max_old_space_size=4096"
@@ -117,13 +117,9 @@ jobs:
117117
npx @puppeteer/browsers install chrome@stable
118118
chromeVersionString=$(ls chrome)
119119
if [ "$CHROME_VALIDATED_VERSION" != "$chromeVersionString" ]; then
120-
echo "::warning ::The Chrome version doesn't match the previously validated version. Consider updating CHROME_VALIDATED_VERSION in the GitHub workflow if tests pass."
120+
echo "::warning ::${CHROME_VERSION_MISMATCH_MESSAGE}"
121121
echo "::warning ::Previously validated version: ${CHROME_VALIDATED_VERSION} vs. Installed version: $chromeVersionString"
122-
echo "CHROME_VERSION_NOTES=$CHROME_VERSION_MISMATCH_MESSAGE" >> "$GITHUB_ENV"
123122
fi
124-
- name: Test Evn TEMP
125-
run: |
126-
echo $CHROME_VERSION_NOTES=$CHROME_VERSION_MISMATCH_MESSAGE
127123
- name: Download build archive
128124
uses: actions/download-artifact@v4
129125
with:

0 commit comments

Comments
 (0)
Please sign in to comment.