Fix negative offset of reconnect delay (#8718) (#8719)

RTDB Fix negative offset of reconnect delay. Fixes #8718.
firebase · Jan 29, 2025 · 01f36ea · 01f36ea
1 parent dafae52
commit 01f36ea
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.changeset/chilled-clocks-remember.md b/.changeset/chilled-clocks-remember.md
@@ -0,0 +1,6 @@
+---
+"@firebase/database": patch
+'firebase': patch
+---
+
+Fix a potential for a negative offset when calculating last reconnect times. This could cause lengthy reconnect delays in some scenarios. Fixes #8718.
diff --git a/packages/database/src/core/PersistentConnection.ts b/packages/database/src/core/PersistentConnection.ts
@@ -797,8 +797,10 @@ export class PersistentConnection extends ServerActions {
         this.lastConnectionEstablishedTime_ = null;
       }
 
-      const timeSinceLastConnectAttempt =
-        new Date().getTime() - this.lastConnectionAttemptTime_;
+      const timeSinceLastConnectAttempt = Math.max(
+        0,
+        new Date().getTime() - this.lastConnectionAttemptTime_
+      );
       let reconnectDelay = Math.max(
         0,
         this.reconnectDelay_ - timeSinceLastConnectAttempt