Fix bug with CORS options for an array of one item for onCall (#1563) (#1564)

bjester · taeold · web-flow · commit 097b73c6a544 · 2024-08-26T20:12:12.000Z
Co-authored-by: Daniel Lee &lt;danielylee@google.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,4 @@
 - Fix retry in event triggered functions. (#1463)
 - Expose retry configuration in v2 RTDB trigger (#1588)
+- Fix CORS options for v2 callable functions (#1564)
 - Remove invalid `enforceAppCheck` option for v2 onRequest trigger (#1477)
diff --git a/src/v2/providers/https.ts b/src/v2/providers/https.ts
@@ -375,7 +375,7 @@ export function onCall<T = any, Return = any | Promise<any>>(
   // on the origin header of the request. If there is only one element in the
   // array, this is unnecessary.
   if (Array.isArray(origin) && origin.length === 1) {
-    origin = origin[1];
+    origin = origin[0];
   }
 
   // onCallHandler sniffs the function length to determine which API to present.

Original file line number	Diff line number	Diff line change
`@@ -375,7 +375,7 @@ export function onCall<T = any, Return = any \| Promise<any>>(`
`375`	`375`	`// on the origin header of the request. If there is only one element in the`
`376`	`376`	`// array, this is unnecessary.`
`377`	`377`	`if (Array.isArray(origin) && origin.length === 1) {`
`378`		`- origin = origin[1];`
	`378`	`+ origin = origin[0];`
`379`	`379`	`}`
`380`	`380`
`381`	`381`	`// onCallHandler sniffs the function length to determine which API to present.`