Getting rid of NSAssert--throwing a more descriptive error

asciimike · asciimike · commit 579d7e4efffd · 2016-02-21T00:26:36.000-08:00
diff --git a/FirebaseUI/Core/Implementation/FirebaseArray.m b/FirebaseUI/Core/Implementation/FirebaseArray.m
@@ -157,7 +157,9 @@ - (id)objectAtIndexedSubscript:(NSUInteger)index{
 }
 
 - (void)setObject:(id)obj atIndexedSubscript:(NSUInteger)index{
-	NSAssert(NO, @"Subscripting is read-only on FirebaseArray");
+  @throw [NSException exceptionWithName:@"FirebaseArraySetIndexWithSubscript"
+                                 reason:@"Setting an object as FirebaseArray[i] is not supported."
+                               userInfo:nil];
 }
 
 @end

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,9 @@ - (id)objectAtIndexedSubscript:(NSUInteger)index{`
`157`	`157`	`}`
`158`	`158`
`159`	`159`	`- (void)setObject:(id)obj atIndexedSubscript:(NSUInteger)index{`
`160`		`- NSAssert(NO, @"Subscripting is read-only on FirebaseArray");`
	`160`	`+ @throw [NSException exceptionWithName:@"FirebaseArraySetIndexWithSubscript"`
	`161`	`+ reason:@"Setting an object as FirebaseArray[i] is not supported."`
	`162`	`+ userInfo:nil];`
`161`	`163`	`}`
`162`	`164`
`163`	`165`	`@end`