Skip to content
This repository was archived by the owner on Sep 18, 2023. It is now read-only.
This repository was archived by the owner on Sep 18, 2023. It is now read-only.

Reference value of @activity_method(name=name) in Worker.register_activities_implementation() #11

@firdaus

Description

@firdaus

Hi,

I've found some issues regarding naming of activities (activtyType.name attribute). On the workflow side it is inferred from ActivityInterfaceClassName::method_name or you can give it a custom name by means of the name parameter of the activity_method decorator, thats all fine.

Unfortunately on the activity side (register_activities_implementation) you have very little room for setting the activityType and the two :: are always there. So consider integration with a workflow code written in Java - you have to anticipate this issue and explicitly rename the activity interface so that it fits this convention. Have you considered allowing for passing the activityType.name directly to register_activities_implementation? Or maybe it is possible to somehow make use of the name param passed via the activity_method decorator (one would expect to inherit ActivitiesImplementation from ActivitiesInterface anyway right)?

Originally posted by @Malicious1 in #6

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions