fix(aarch64): correct protoc for linux_aarch64 #2839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Chan <[email protected]>
|
@s22chan Thanks for the PR! This does not compile and is beginning to bitrot, so closing for now. While I'm in favor of adding broader architecture support, I would like test coverage for these platforms (or surrogate diligence in understanding why GitHub Actions CI does not allow this), or new releases are only going to work incidentally. |
|
It did not compile due to an unrelated issue and I wasn't sure how to retrigger a build. For the second point, that's fair, I'll just make my own builds for now. Thanks for your project btw, its' very useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protoc was always being download as x86-64 when under linux.
Fixes #2838
Pull Request Checklist
Discussions, this PR applies to.