-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some guidance on running the tests please #266
Comments
@robmoffat is your best bet for some questions.
This shouldn't happen unless you are running the manual tests. The tests are constructed such that the automated ones should never pop up the resolver as there is either only a single option available (starting an instance of a specific appId) or because the call was targeted at a specific instance. See https://fdc3.finos.org/docs/api/spec#intent-resolution and https://fdc3.finos.org/docs/api/ref/DesktopAgent#raiseintentfor confirmation that the resolver shouldn't show up if there is only a single option (intent was unambiguous, in the language used in the standard). The tests assume that the test apps are the only ones available (makes it easier to manage the complex set of different apps needed in all the intent tests - although they do also (mostly) use made-up context types to avoid conflicts. You are also in control of whether you show your own resolver somewhere or use an injected one in the window. You do so by sending your
That test has a 121 second timeout as the app never adds the intent listener that is being waited for. If your implementation uses a longer timeout (the standard doesn't specify one, only that there should be one) then extend
The test framework tries to close apps using typical usage: https://github.com/finos/FDC3-conformance-framework/blob/2_0_fdc3_for_the_web/src/test/v2.0/fdc3-2_0-utils.ts/#L10-L11 I was getting random failures of that too - possibly due to chrome throttling tabs that weren't selected. Went away when I bumped it to 2 seconds (in teh first code ref above). However, there is an additional problem in that there is no good way to close apps hosted as iframes in a parent window - |
Many thanks again @kriswest I certainly need to change our app resolution to not appear if there is only 1 option. I can also try changing the timeout to change the inconsistent close context issue. All of the apps are opening in new windows rather than iframes so they should all close correctly. |
Hi
I am at the stage where we're testing our desktop agent against the conformance tests. At the moment we have several failures and I guess there will be more problems in the future as we fix issues. What is the best way to get help with this? Is it ok to raise issues here asking for help with this?
At the moment I have the following issues and questions:
(RaiseIntentFailTargetedAppResolve4) Should throw an IntentDeliveryFailed error when raising intent with targeted app intent-i, context 'testContextY', intent 'sharedTestingIntent2'
Error: App didn't return close context within .5 secs
What does this mean?
The text was updated successfully, but these errors were encountered: