Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read configuration dynamically #31

Open
thdxr opened this issue Jan 10, 2019 · 4 comments
Open

Read configuration dynamically #31

thdxr opened this issue Jan 10, 2019 · 4 comments

Comments

@thdxr
Copy link

thdxr commented Jan 10, 2019

Instead of reading the application configuration once and caching it in a GenServer, it should be read on demand when a request is made. This fits normal Elixir convention and doesn't depend on configuration being set in an explicit order.

More information on this concept here: https://michal.muskala.eu/2017/07/30/configuring-elixir-libraries.html

@thdxr
Copy link
Author

thdxr commented Jan 10, 2019

Following up on this, is a GenServer even necessary?

@olivierbuffon
Copy link

olivierbuffon commented Sep 25, 2019

I would also be interested by that change. We use Confex in our project and unfortunately because of the current implementation it won't work.

@jvantuyl
Copy link

I have a use-case that involves hitting two vault servers. Could really use this. Would a PR be accepted?

@AtebMT
Copy link
Contributor

AtebMT commented Jan 21, 2021

Absolutely. Most of the recent changes have come from PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants