Bug report

[Nick-Mazuk]

Description

hello, trying to work with smufl_load_engraving_defaults plugin
I get this answer: "...module 'lunajson.decoder' not found"
any help? thanks

Metadata

• Finale v27
• macOS 12
• Script: smufl_load_engraving_defaults.lua

Created through the website by Alessandro Melchiorre [email protected]

[rpatters1]

They can fix it now by downloading the luajson directory to be in the directory where their script is. Longer term, that could be added to the distribution packager.

[Nick-Mazuk]

It should now be bundled. As of the bundler rewrite, it accepts any arbitrary static imports as long as it's in the src folder.

[rpatters1]

I'm looking at dist/smufl_load_engraving_defaults.lua and it included luajson.luajson but not luajson.decoder and luajson.encoder. (These are required by luajson/luajson.lua.

[Nick-Mazuk]

I see. It's likely because these require statements don't use parenthesis.

lua-scripts/src/lunajson/lunajson.lua

Lines 1 to 3 in c042930

	local newdecoder = require 'lunajson.decoder'
	local newencoder = require 'lunajson.encoder'
	local sax = require 'lunajson.sax'

This is how an import is currently defined in the parser:

lua-scripts/.github/actions/bundle/src/helpers.ts

Line 2 in c042930

const matches = line.match(/require\(["']([A-Z_a-z.]+)["']\)/iu)

[Nick-Mazuk]

#345 (nice PR number) should fix this problem, but let's leave this issue open as the long-term fix is to update the bundler to support this edge case.