Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Postgres Client in terms of StackClient? #4

Closed
jnd71 opened this issue Mar 13, 2015 · 1 comment
Closed

Implementing Postgres Client in terms of StackClient? #4

jnd71 opened this issue Mar 13, 2015 · 1 comment
Milestone

Comments

@jnd71
Copy link

jnd71 commented Mar 13, 2015

Would this project be interested in a newer PostgresClient that's implemented in terms of the StackClient, al lá finagle-mysql? I ask first instead of a PR because implementing the new PostgresClient would require either breaking changes on com.twitter.finagle.postgres.Client, or duplicating behavior into a newer client and sunsetting / leaving the original com.twitter.finagle.postgres.Client.

Thoughts?

@travisbrown
Copy link
Collaborator

This sounds like a good idea to me—once you've got a PR I'll work with @yolken to see about getting it merged internally, and if for some reason it seems like it won't be possible to do that in a timely fashion, I'll set up a new branch here for tracking the internal project.

@vkostyukov vkostyukov added this to the 0.2.0 milestone Oct 14, 2015
@jnd71 jnd71 closed this as completed Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants