Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm package request deprecated #224

Open
jasperchua99 opened this issue Feb 12, 2022 · 12 comments
Open

npm package request deprecated #224

jasperchua99 opened this issue Feb 12, 2022 · 12 comments

Comments

@jasperchua99
Copy link

request/request#3142

this npm package seam to be deprecated, any reification to use another package?

@TobiTenno
Copy link
Collaborator

Sadly, the owner didn't give me sufficient perms to merge my own fixes and no one else can review my changes. So until some configuration on this repo gets fixed, I can't fix that and some other outstanding issues.

@jasperchua99
Copy link
Author

oic

@filipedeschamps
Copy link
Owner

You guys are right. After others projects and a recently born son my life has changed significantly. I've also published a video on my channel explaining how I screwed up with my open source projects.

But what can I do to fix this? @TobiTenno you have write access to the repo I think, maybe you can start merging things to master by yourself, you are doing an amazing job. And I saw you made a PR to start using Github Actions. What do you think to remove all external dependencies (including Coverals)? Also, let's not auto-publish do npm. I prefer doing this manually.

@TobiTenno
Copy link
Collaborator

TobiTenno commented Feb 12, 2022

I think admin is required to merge my own and set up better actions.

my reasoning on auto-publishing is that it keeps fixes going out quickly (and I don't have access to do so), so it would make it easier on you and I so that in the future if others are brought on to approve, they don't also need access to publish. the keys are thankfully secrets and github doesn't allow reading them after they're written, so even I would never need to know the npm token's contents

i still think this is an awesome project and I'd love to keep it going as much as I'm able. Stuff like coveralls or codeclimate are fine to me because they give an extra eye to security checks that I might not realize. there are github actions that can do some of the same, but I've not seen one for coverage as of yet.

@jasperchua99
Copy link
Author

well im all ears to hears what yall are gonna do to make sure this project goes smoothly, for now tho, request is the only one bugging my npm to change to another file

@TobiTenno
Copy link
Collaborator

Yeah, I'll get started on that migration once I finish the 2 others (config spread and dedupe)

@TobiTenno
Copy link
Collaborator

at this point, i'm gonna have to lean on y'all, cause I can't merge my own stuff still, so if y'all can submit fixes, i can merge them

@sankemax
Copy link

sankemax commented Oct 5, 2024

@TobiTenno hey, if i create a PR, will you merge it?

@TobiTenno
Copy link
Collaborator

If it works, yes

@TobiTenno
Copy link
Collaborator

@sankemax would you be down to help me by basically resubmitting several of my old PRs that include things like reducing config spread and moving to gh actions? I can help manage more PRs and get more updated off of travis and deprecated deps

@TobiTenno
Copy link
Collaborator

@filipedeschamps we really need you to do those parts switched out on #216. it would be even better if you turned this into an org project and migrated it there, that would give you and i equal access to the configs and i'd be able to merge my own PRs without waiting for approvals, just for CI to merge

@filipedeschamps
Copy link
Owner

Done @TobiTenno 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants