-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm package request deprecated #224
Comments
Sadly, the owner didn't give me sufficient perms to merge my own fixes and no one else can review my changes. So until some configuration on this repo gets fixed, I can't fix that and some other outstanding issues. |
oic |
You guys are right. After others projects and a recently born son my life has changed significantly. I've also published a video on my channel explaining how I screwed up with my open source projects. But what can I do to fix this? @TobiTenno you have |
I think my reasoning on auto-publishing is that it keeps fixes going out quickly (and I don't have access to do so), so it would make it easier on you and I so that in the future if others are brought on to approve, they don't also need access to publish. the keys are thankfully secrets and github doesn't allow reading them after they're written, so even I would never need to know the npm token's contents i still think this is an awesome project and I'd love to keep it going as much as I'm able. Stuff like coveralls or codeclimate are fine to me because they give an extra eye to security checks that I might not realize. there are github actions that can do some of the same, but I've not seen one for coverage as of yet. |
well im all ears to hears what yall are gonna do to make sure this project goes smoothly, for now tho, request is the only one bugging my npm to change to another file |
Yeah, I'll get started on that migration once I finish the 2 others (config spread and dedupe) |
at this point, i'm gonna have to lean on y'all, cause I can't merge my own stuff still, so if y'all can submit fixes, i can merge them |
@TobiTenno hey, if i create a PR, will you merge it? |
If it works, yes |
@sankemax would you be down to help me by basically resubmitting several of my old PRs that include things like reducing config spread and moving to gh actions? I can help manage more PRs and get more updated off of travis and deprecated deps |
@filipedeschamps we really need you to do those parts switched out on #216. it would be even better if you turned this into an org project and migrated it there, that would give you and i equal access to the configs and i'd be able to merge my own PRs without waiting for approvals, just for CI to merge |
Done @TobiTenno 👍 |
request/request#3142
this npm package seam to be deprecated, any reification to use another package?
The text was updated successfully, but these errors were encountered: