Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom headers #207

Open
Sazzo opened this issue Aug 19, 2020 · 7 comments
Open

Implement custom headers #207

Sazzo opened this issue Aug 19, 2020 · 7 comments

Comments

@Sazzo
Copy link

Sazzo commented Aug 19, 2020

It would be super cool if we could specify a custom header.

@TobiTenno
Copy link
Collaborator

Why? The library is an abstraction of what's needed to pull and feed RSS, and that's a pretty low-level addition... If you can give a use-case, that'd make it possible, but at present... doesn't seem to be much of a reason.

@Sazzo
Copy link
Author

Sazzo commented Aug 22, 2020

Some RSS sites that use Cloudflare or Cors Security block us if we don't use specific headers, so I think it would be useful for that. Sorry for the very poorly explained description in the issue above.

@Sazzo
Copy link
Author

Sazzo commented Aug 22, 2020

Like Crunchyroll for exemple.

@TobiTenno
Copy link
Collaborator

What specific headers are you looking for to bypass those?
Those sound like things we should just provide in general, not give an option for.

@Sazzo
Copy link
Author

Sazzo commented Aug 22, 2020

Like "x-requested-with" or "origin", i think one of these two is nice to add, since with it you can use a cors proxy (Like cors anywhere)

@TobiTenno
Copy link
Collaborator

Sorry, been thinking about what it would mean to add those specifically.
I worry that manually setting cors headers isn't really something we should be doing. I've been looking at uplifting to something like node-fetch to work better with cors instead of needing to manually do that kind of thing

@Sazzo
Copy link
Author

Sazzo commented Jan 3, 2021

I made this issue a while ago, so seeing today I agree with you, so, feel free to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants