Skip to content

Feature: Display banner when all sections are hidden on the sidebar #7065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hefaistos68 opened this issue Nov 25, 2021 · 18 comments · May be fixed by #17039
Open

Feature: Display banner when all sections are hidden on the sidebar #7065

Hefaistos68 opened this issue Nov 25, 2021 · 18 comments · May be fixed by #17039
Labels
good first issue Good issue for new contributors to get started with

Comments

@Hefaistos68
Copy link

Hefaistos68 commented Nov 25, 2021

What's the Problem?

When disabling all sidebar items, one ends up with an totally empty space, no indication whatsoever what to do with/from it.

Requirements

  • Add graphics to fill up the space (suggestions?)
  • Add text recommending the user to right click and show sections again

Files Version

Version: 2.0.34.0

Windows Version

OS Version: 10.0.19042.1348

Additional comment

image

@gave92
Copy link
Member

gave92 commented Nov 25, 2021

Keep at least one last item always visible

Or even completely hide the sidebar maybe? Users might not know how to show it again

@yaira2 yaira2 changed the title Empty sidebar Add placeholder text when no sections are shown in the sidebar Dec 13, 2021
@yaira2 yaira2 added the good first issue Good issue for new contributors to get started with label Dec 13, 2021
@grtcoder
Copy link

I would like to work on the issue

@grtcoder grtcoder removed their assignment Dec 28, 2021
@ZPyrolink
Copy link

Hello,
I have been developing for a few years in C# and I have been using Files Community for some time. I would like to know if anyone was currently assigned at this issue, and if not, could I try to work on it?

@Josh65-2201 Josh65-2201 moved this to 🆕 New in Files task board Sep 8, 2022
@yaira2 yaira2 changed the title Add placeholder text when no sections are shown in the sidebar Feature: Display graphics and text when all sections are hidden on the sidebar Nov 1, 2022
@yaira2 yaira2 moved this from 🆕 New to 📋 Planning stage in Files task board Nov 1, 2022
@ZPyrolink ZPyrolink removed their assignment Nov 30, 2022
@yaira2 yaira2 changed the title Feature: Display graphics and text when all sections are hidden on the sidebar Feature: Display banner when all sections are hidden on the sidebar Apr 27, 2023
@yaira2 yaira2 moved this from 📋 Planning stage to 🔖 Ready to build in Files task board Apr 27, 2023
@mdtauk
Copy link
Contributor

mdtauk commented Aug 8, 2023

Can we have the button actually bring up the edit sidebar options UI.

Not sure that design works, especially if we end up moving the settings button to the bottom of the sidebar.

I'll have a play around with some ideas. Files does not have other illustrations, so we don't have a visual style or metaphor to refer to for illustrative imagery.

Home should never be removable.

@mdtauk
Copy link
Contributor

mdtauk commented Aug 8, 2023

What about something like this?
image
image

@yaira2
Copy link
Member

yaira2 commented Aug 8, 2023

Can we have the button actually bring up the edit sidebar options UI.

Should be possible, it's just a menu flyout.

@mdtauk
Copy link
Contributor

mdtauk commented Aug 11, 2023

Do we want to have an EmptyContent property on the Sidebar, that shows when other items are not visible? Handle the logic in the control itself?

Header content (Home item) and Footer content (Settings) would be excluded from the empty logic.

@yaira2
Copy link
Member

yaira2 commented Aug 13, 2023

@mdtauk we don't currently but we'll want to do something like that.

@files-community files-community deleted a comment from gave92 Nov 23, 2023
@yaira2 yaira2 moved this from 🔖 Ready to build to 📋 Planning stage in Files task board Nov 23, 2023
@kowalkos
Copy link

@yaira2 is this issue still open to work? I don't think anyone resolved it

@yaira2
Copy link
Member

yaira2 commented Jan 16, 2024

The issue is still marked as planning but the designs @mdtauk shared look good. Do you want to work on this?

@kowalkos
Copy link

sure thing

@kowalkos
Copy link

I stumbled on another issue, I hid all favourites folders and maybe i dont know or there is no option to make them visible back, so they would be visible back again. Is there an option to just add folder to favourites?

@yaira2
Copy link
Member

yaira2 commented Jan 16, 2024

Is there an option to just add folder to favourites

There should be an option when you right click a folder

@kowalkos
Copy link

Is there an option to just add folder to favourites

There should be an option when you right click a folder
missingFavourite

Yes i added folder to favourites but it doesn't appear. Is there a way to hide favourite folders? because i thought the good way of doing it would be to hide all items from favourites after that all of my items from favourites are hidden see gif

@kowalkos
Copy link

also i've seen the issue that in default browsing through files there is no option of adding folder/file to favourites. Might want to open another issue for this

@yaira2
Copy link
Member

yaira2 commented Jan 16, 2024

You turned off the favorites section from the sidebar, you can right click the sidebar to add it back.

@kowalkos
Copy link

okay i see thanks for claryfing

@kowalkos
Copy link

everything is clear now i will work on it

@yaira2 yaira2 moved this from 📋 Planning stage to 🏗 In progress in Files task board Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for new contributors to get started with
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

7 participants