Skip to content

Commit 6319362

Browse files
seer-by-sentry[bot]seer-by-sentry[bot]
authored
Code Quality: Simplify Status Center card header and subheader creation (#17647)
Co-authored-by: seer-by-sentry[bot] <157164994+seer-by-sentry[bot]@users.noreply.github.com>
1 parent dbf0807 commit 6319362

File tree

1 file changed

+16
-128
lines changed

1 file changed

+16
-128
lines changed

‎src/Files.App/Utils/StatusCenter/StatusCenterHelper.cs‎

Lines changed: 16 additions & 128 deletions
Original file line numberDiff line numberDiff line change
@@ -647,200 +647,88 @@ public static void UpdateCardStrings(StatusCenterItem card)
647647
{
648648
string headerString = string.IsNullOrWhiteSpace(card.HeaderStringResource) ? string.Empty
649649
: card.HeaderStringResource.GetLocalizedFormatResource(card.TotalItemsCount, destinationDirName);
650-
card.Header = card.FileSystemOperationReturnResult switch
651-
{
652-
ReturnResult.Cancelled => string.Format(headerString, card.TotalItemsCount, destinationDirName),
653-
ReturnResult.Success => string.Format(headerString, card.TotalItemsCount, destinationDirName),
654-
ReturnResult.Failed => string.Format(headerString, card.TotalItemsCount, destinationDirName),
655-
ReturnResult.InProgress => string.Format(headerString, card.TotalItemsCount, destinationDirName),
656-
_ => string.Format(headerString, card.TotalItemsCount, destinationDirName),
657-
};
650+
card.Header = headerString;
658651

659652
string subHeaderString = string.IsNullOrWhiteSpace(card.SubHeaderStringResource) ? string.Empty
660653
: card.SubHeaderStringResource.GetLocalizedFormatResource(card.TotalItemsCount, sourcePath, destinationPath);
661-
card.SubHeader = card.FileSystemOperationReturnResult switch
662-
{
663-
ReturnResult.Cancelled => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
664-
ReturnResult.Success => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
665-
ReturnResult.Failed => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
666-
ReturnResult.InProgress => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
667-
_ => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
668-
};
654+
card.SubHeader = subHeaderString;
669655
break;
670656
}
671657
case FileOperationType.Move:
672658
{
673659
string headerString = string.IsNullOrWhiteSpace(card.HeaderStringResource) ? string.Empty
674660
: card.HeaderStringResource.GetLocalizedFormatResource(card.TotalItemsCount, destinationDirName);
675-
card.Header = card.FileSystemOperationReturnResult switch
676-
{
677-
ReturnResult.Cancelled => string.Format(headerString, card.TotalItemsCount, destinationDirName),
678-
ReturnResult.Success => string.Format(headerString, card.TotalItemsCount, destinationDirName),
679-
ReturnResult.Failed => string.Format(headerString, card.TotalItemsCount, destinationDirName),
680-
ReturnResult.InProgress => string.Format(headerString, card.TotalItemsCount, destinationDirName),
681-
_ => string.Format(headerString, card.TotalItemsCount, destinationDirName),
682-
};
661+
card.Header = headerString;
683662

684663
string subHeaderString = string.IsNullOrWhiteSpace(card.SubHeaderStringResource) ? string.Empty
685664
: card.SubHeaderStringResource.GetLocalizedFormatResource(card.TotalItemsCount, sourcePath, destinationPath);
686-
card.SubHeader = card.FileSystemOperationReturnResult switch
687-
{
688-
ReturnResult.Cancelled => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
689-
ReturnResult.Success => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
690-
ReturnResult.Failed => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
691-
ReturnResult.InProgress => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
692-
_ => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
693-
};
665+
card.SubHeader = subHeaderString;
694666
break;
695667
}
696668
case FileOperationType.Delete:
697669
{
698670
string headerString = string.IsNullOrWhiteSpace(card.HeaderStringResource) ? string.Empty
699671
: card.HeaderStringResource.GetLocalizedFormatResource(card.TotalItemsCount, sourceDirName);
700-
card.Header = card.FileSystemOperationReturnResult switch
701-
{
702-
ReturnResult.Cancelled => string.Format(headerString, card.TotalItemsCount, sourceDirName),
703-
ReturnResult.Success => string.Format(headerString, card.TotalItemsCount, sourceDirName),
704-
ReturnResult.Failed => string.Format(headerString, card.TotalItemsCount, sourceDirName),
705-
ReturnResult.InProgress => string.Format(headerString, card.TotalItemsCount, sourceDirName),
706-
_ => string.Format(headerString, card.TotalItemsCount, sourceDirName),
707-
};
672+
card.Header = headerString;
708673

709674
string subHeaderString = string.IsNullOrWhiteSpace(card.SubHeaderStringResource) ? string.Empty
710675
: card.SubHeaderStringResource.GetLocalizedFormatResource(card.TotalItemsCount, sourcePath);
711-
card.SubHeader = card.FileSystemOperationReturnResult switch
712-
{
713-
ReturnResult.Cancelled => string.Format(subHeaderString, card.TotalItemsCount, sourcePath),
714-
ReturnResult.Success => string.Format(subHeaderString, card.TotalItemsCount, sourcePath),
715-
ReturnResult.Failed => string.Format(subHeaderString, card.TotalItemsCount, sourcePath),
716-
ReturnResult.InProgress => string.Format(subHeaderString, card.TotalItemsCount, sourcePath),
717-
_ => string.Format(subHeaderString, card.TotalItemsCount, sourcePath),
718-
};
676+
card.SubHeader = subHeaderString;
719677
break;
720678
}
721679
case FileOperationType.Recycle:
722680
{
723681
string headerString = string.IsNullOrWhiteSpace(card.HeaderStringResource) ? string.Empty
724682
: card.HeaderStringResource.GetLocalizedFormatResource(card.TotalItemsCount, sourceDirName);
725-
card.Header = card.FileSystemOperationReturnResult switch
726-
{
727-
ReturnResult.Cancelled => string.Format(headerString, card.TotalItemsCount, sourceDirName),
728-
ReturnResult.Success => string.Format(headerString, card.TotalItemsCount, sourceDirName),
729-
ReturnResult.Failed => string.Format(headerString, card.TotalItemsCount, sourceDirName),
730-
ReturnResult.InProgress => string.Format(headerString, card.TotalItemsCount, sourceDirName),
731-
_ => string.Format(headerString, card.TotalItemsCount, sourceDirName),
732-
};
683+
card.Header = headerString;
733684

734685
string subHeaderString = string.IsNullOrWhiteSpace(card.SubHeaderStringResource) ? string.Empty
735686
: card.SubHeaderStringResource.GetLocalizedFormatResource(card.TotalItemsCount, sourcePath);
736-
card.SubHeader = card.FileSystemOperationReturnResult switch
737-
{
738-
ReturnResult.Cancelled => string.Format(subHeaderString, card.TotalItemsCount, sourcePath),
739-
ReturnResult.Success => string.Format(subHeaderString, card.TotalItemsCount, sourcePath),
740-
ReturnResult.Failed => string.Format(subHeaderString, card.TotalItemsCount, sourcePath),
741-
ReturnResult.InProgress => string.Format(subHeaderString, card.TotalItemsCount, sourcePath),
742-
_ => string.Format(subHeaderString, card.TotalItemsCount, sourcePath),
743-
};
687+
card.SubHeader = subHeaderString;
744688
break;
745689
}
746690
case FileOperationType.Extract:
747691
{
748692
string headerString = string.IsNullOrWhiteSpace(card.HeaderStringResource) ? string.Empty
749693
: card.HeaderStringResource.GetLocalizedFormatResource(sourceFileName, destinationDirName);
750-
card.Header = card.FileSystemOperationReturnResult switch
751-
{
752-
ReturnResult.Cancelled => string.Format(headerString, sourceFileName, destinationDirName),
753-
ReturnResult.Success => string.Format(headerString, sourceFileName, destinationDirName),
754-
ReturnResult.Failed => string.Format(headerString, sourceFileName, destinationDirName),
755-
ReturnResult.InProgress => string.Format(headerString, sourceFileName, destinationDirName),
756-
_ => string.Format(headerString, sourceFileName, destinationDirName),
757-
};
694+
card.Header = headerString;
758695

759696
string subHeaderString = string.IsNullOrWhiteSpace(card.SubHeaderStringResource) ? string.Empty
760697
: card.SubHeaderStringResource.GetLocalizedFormatResource(sourceFileName, sourcePath, destinationPath);
761-
card.SubHeader = card.FileSystemOperationReturnResult switch
762-
{
763-
ReturnResult.Cancelled => string.Format(subHeaderString, sourceFileName, sourcePath, destinationPath),
764-
ReturnResult.Success => string.Format(subHeaderString, sourceFileName, sourcePath, destinationPath),
765-
ReturnResult.Failed => string.Format(subHeaderString, sourceFileName, sourcePath, destinationPath),
766-
ReturnResult.InProgress => string.Format(subHeaderString, sourceFileName, sourcePath, destinationPath),
767-
_ => string.Format(subHeaderString, sourceFileName, sourcePath, destinationPath),
768-
};
698+
card.SubHeader = subHeaderString;
769699
break;
770700
}
771701
case FileOperationType.Compressed:
772702
{
773703
string headerString = string.IsNullOrWhiteSpace(card.HeaderStringResource) ? string.Empty
774704
: card.HeaderStringResource.GetLocalizedFormatResource(card.TotalItemsCount, destinationDirName);
775-
card.Header = card.FileSystemOperationReturnResult switch
776-
{
777-
ReturnResult.Cancelled => string.Format(headerString, card.TotalItemsCount, destinationDirName),
778-
ReturnResult.Success => string.Format(headerString, card.TotalItemsCount, destinationDirName),
779-
ReturnResult.Failed => string.Format(headerString, card.TotalItemsCount, destinationDirName),
780-
ReturnResult.InProgress => string.Format(headerString, card.TotalItemsCount, destinationDirName),
781-
_ => string.Format(headerString, card.TotalItemsCount, destinationDirName),
782-
};
705+
card.Header = headerString;
783706

784707
string subHeaderString = string.IsNullOrWhiteSpace(card.SubHeaderStringResource) ? string.Empty
785708
: card.SubHeaderStringResource.GetLocalizedFormatResource(card.TotalItemsCount, sourcePath, destinationPath);
786-
card.SubHeader = card.FileSystemOperationReturnResult switch
787-
{
788-
ReturnResult.Cancelled => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
789-
ReturnResult.Success => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
790-
ReturnResult.Failed => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
791-
ReturnResult.InProgress => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
792-
_ => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
793-
};
709+
card.SubHeader = subHeaderString;
794710
break;
795711
}
796712
case FileOperationType.GitClone:
797713
{
798714
string headerString = string.IsNullOrWhiteSpace(card.HeaderStringResource) ? string.Empty
799715
: card.HeaderStringResource.GetLocalizedFormatResource(sourcePath, destinationDirName);
800-
card.Header = card.FileSystemOperationReturnResult switch
801-
{
802-
ReturnResult.Cancelled => string.Format(headerString, sourcePath, destinationDirName),
803-
ReturnResult.Success => string.Format(headerString, sourcePath, destinationDirName),
804-
ReturnResult.Failed => string.Format(headerString, sourcePath, destinationDirName),
805-
ReturnResult.InProgress => string.Format(headerString, sourcePath, destinationDirName),
806-
_ => string.Format(headerString, sourcePath, destinationDirName),
807-
};
716+
card.Header = headerString;
808717

809718
string subHeaderString = string.IsNullOrWhiteSpace(card.SubHeaderStringResource) ? string.Empty
810719
: card.SubHeaderStringResource.GetLocalizedFormatResource(card.TotalItemsCount, sourcePath, destinationPath);
811-
card.SubHeader = card.FileSystemOperationReturnResult switch
812-
{
813-
ReturnResult.Cancelled => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
814-
ReturnResult.Success => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
815-
ReturnResult.Failed => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
816-
ReturnResult.InProgress => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
817-
_ => string.Format(subHeaderString, card.TotalItemsCount, sourcePath, destinationPath),
818-
};
720+
card.SubHeader = subHeaderString;
819721
break;
820722
}
821723
case FileOperationType.InstallFont:
822724
{
823725
string headerString = string.IsNullOrWhiteSpace(card.HeaderStringResource) ? string.Empty
824726
: card.HeaderStringResource.GetLocalizedFormatResource(card.TotalItemsCount);
825-
card.Header = card.FileSystemOperationReturnResult switch
826-
{
827-
ReturnResult.Cancelled => string.Format(headerString, card.TotalItemsCount),
828-
ReturnResult.Success => string.Format(headerString, card.TotalItemsCount),
829-
ReturnResult.Failed => string.Format(headerString, card.TotalItemsCount),
830-
ReturnResult.InProgress => string.Format(headerString, card.TotalItemsCount),
831-
_ => string.Format(headerString, card.TotalItemsCount),
832-
};
727+
card.Header = headerString;
833728

834729
string subHeaderString = string.IsNullOrWhiteSpace(card.SubHeaderStringResource) ? string.Empty
835730
: card.SubHeaderStringResource.GetLocalizedFormatResource(card.TotalItemsCount, sourcePath);
836-
card.SubHeader = card.FileSystemOperationReturnResult switch
837-
{
838-
ReturnResult.Cancelled => string.Format(subHeaderString, card.TotalItemsCount, sourcePath),
839-
ReturnResult.Success => string.Format(subHeaderString, card.TotalItemsCount, sourcePath),
840-
ReturnResult.Failed => string.Format(subHeaderString, card.TotalItemsCount, sourcePath),
841-
ReturnResult.InProgress => string.Format(subHeaderString, card.TotalItemsCount, sourcePath),
842-
_ => string.Format(subHeaderString, card.TotalItemsCount, sourcePath),
843-
};
731+
card.SubHeader = subHeaderString;
844732
break;
845733
}
846734
}

0 commit comments

Comments
 (0)