Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate wrong address prefix for calibnet node #12767

Open
rvagg opened this issue Dec 10, 2024 · 3 comments
Open

Investigate wrong address prefix for calibnet node #12767

rvagg opened this issue Dec 10, 2024 · 3 comments
Assignees

Comments

@rvagg
Copy link
Member

rvagg commented Dec 10, 2024

Reported on Slack: https://filecoinproject.slack.com/archives/CEGN061C5/p1733812367148489

Glif are currently running v1.32.0-rc1 and this happens:

$ curl -s -X POST 'https://api.calibration.node.glif.io/rpc/v0' -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"Filecoin.ChainGetParentMessages","params":[{"/":"bafy2bzaced3dhjm77nnxe5nsqs66m3yxeohyb2mvsccplz7pintkb4jdo67s6"}],"id":1}' | jq '.result[0].Message.From'
"f1ac6ndwj6nghqbmtbovvnwcqo577p6ox2pt52q2y"

I'm running 1.30.0 still and I get the expected output:

$ curl -s -X POST 'http://localhost:1235/rpc/v0' -H "Content-Type: application/json" --data '
{"jsonrpc":"2.0","method":"Filecoin.ChainGetParentMessages","params":[{"/": "bafy2bzaced3dhjm77nnxe5nsqs66m3yxeohyb2mvsccplz7pintkb4jdo67s6"}],"id":1}' | jq '.result[0].Messag
e.From'
"t1ac6ndwj6nghqbmtbovvnwcqo577p6ox2pt52q2y"

Need to investigate why address.CurrentNetwork is not set to address.Testnet or why address.Testnet isn't resulting in an address.TestnetPrefix. Is this a 1.32.0 thing? Or might there have been a compile problem of some kind?

@rvagg rvagg self-assigned this Dec 10, 2024
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Dec 10, 2024
@masih
Copy link
Member

masih commented Dec 10, 2024

Potentially related to upstream changes which were fixed in:

There is probably still somewhere we have missed the override.

@rvagg
Copy link
Member Author

rvagg commented Dec 10, 2024

Certainly related, but they look OK to me; the fact that a node will successfully sync calibnet means it was built with the calibnet build tag so none of these paths should even be relevant.

I'll upgrade my node this week and see if it's the same to determine whether this is actually a code problem and go from there.

@rvagg
Copy link
Member Author

rvagg commented Dec 13, 2024

I just compiled and deployed 1.32.0-rc2+calibnet+git.a9718c841+api1.5.0 and it's still correct on my end:

$ curl -s -X POST 'http://localhost:1235/rpc/v0' -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"Filecoin.ChainGetParentMessages","params":[{"/":"bafy2bzacedxj55j56mv2qb7r6zlopxtdq4nh2ast2xpralakro5lixljuuage"}],"id":1}' | jq '.result[0].Message.From'
"t3rtbpyvmthqcbhz3dwy5rbmjrwpst6v4ifyghsiy54cw2git6ahwyc7lityyvbb2bocskf5vvsdgzgovyzzna"
$ curl -s -X POST 'https://api.calibration.node.glif.io/rpc/v0' -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"Filecoin.ChainGetParentMessages","params":[{"/":"bafy2bzacedxj55j56mv2qb7r6zlopxtdq4nh2ast2xpralakro5lixljuuage"}],"id":1}' | jq '.result[0].Message.From'
"f3rtbpyvmthqcbhz3dwy5rbmjrwpst6v4ifyghsiy54cw2git6ahwyc7lityyvbb2bocskf5vvsdgzgovyzzna"

@dumikau if you're going to do rc2, could you let us know in here when you've upgraded? Maybe there was a compile problem with the rc1 you had deployed. 🤷 I can't come up with a reasonable explanation for this, I can't even think how to compile a Lotus that would do this without editing some of the files first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📌 Triage
Development

No branches or pull requests

2 participants