Dealbot does not remove pvc volumes when deleting dealbots

[travisperson]

Dealbot uses the lotus-bundle helm-chart when setting up dealbot lotus daemons.

Statefulsets do not clean up pvc resources and it's left up to the administrator to remove these volumes. Dealbot currently does not handle the deleting of the pvc after uninstalling the helm chart, and helm does not support deleting pvc from statefulsets either (helm/helm#5156)

dealbot/controller/spawn/kubernetes.go

Lines 85 to 97 in 3f74c43

	func (s *KubernetesSpawner) Shutdown(regionid string, daemonid string) error {
	actionConfig, _, err := s.actionConfig(regionid)
	if err != nil {
	log.Infow("could not create actionConfig during daemon Get", "err", err)
	return err
	}
	client := action.NewUninstall(actionConfig)
	_, err = client.Run(daemonid)
	if err != nil {
	return err
	}
	return nil
	}

There is no way to delete the volume automatically. In k8s v1.23 there is an alpha feature to allow for this change. However, we will not be able to use this feature.

Dealbot will need to manually execute a delete action against the pvc for the lotus-bundle helm chart to clean up these volumes.